From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#4136: 23.1; delete-pair Date: Mon, 21 Sep 2020 22:12:29 +0300 Organization: LINKOV.NET Message-ID: <871rivdrqy.fsf@mail.linkov.net> References: <19075.45378.67131.491453@winooski.ccs.neu.edu> <873a7uc8mg.fsf@mail.jurta.org> <4A8689EE.9020402@gmx.at> <87ljlk4snf.fsf@mail.jurta.org> <87eirfs56q.fsf@mail.jurta.org> <19076.47996.128071.281272@winooski.ccs.neu.edu> <87pray9ezq.fsf@mail.jurta.org> <19078.4981.525959.210519@winooski.ccs.neu.edu> <87ab20znhd.fsf@mail.jurta.org> <19079.19478.357436.68768@winooski.ccs.neu.edu> <87k5131d3d.fsf@mail.jurta.org> <19080.51949.798286.416193@winooski.ccs.neu.edu> <87ocqezdfd.fsf@mail.jurta.org> <4A8A549E.20605@gmx.at> <87r1r48n82.fsf@gnus.org> <874ko0rx9s.fsf@mail.linkov.net> <87imcf9qe1.fsf@gnus.org> <87sgbjosqp.fsf@mail.linkov.net> <871rj0qx76.fsf@gnus.org> <87mu1npjmj.fsf@mail.linkov.net> <87wo0rjqpu.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25820"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Eli Barzilay , 4136@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 21 21:15:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKRHO-0006ad-Ax for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Sep 2020 21:15:14 +0200 Original-Received: from localhost ([::1]:37244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKRHN-0005K8-7E for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Sep 2020 15:15:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKRHC-0005Fw-Ii for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2020 15:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44728) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kKRHC-0003ft-6e for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2020 15:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kKRHC-0007xC-2h for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2020 15:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Sep 2020 19:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4136 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 4136-submit@debbugs.gnu.org id=B4136.160071568430464 (code B ref 4136); Mon, 21 Sep 2020 19:15:02 +0000 Original-Received: (at 4136) by debbugs.gnu.org; 21 Sep 2020 19:14:44 +0000 Original-Received: from localhost ([127.0.0.1]:56262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKRGu-0007vI-Cb for submit@debbugs.gnu.org; Mon, 21 Sep 2020 15:14:44 -0400 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:59077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKRGo-0007uY-A2 for 4136@debbugs.gnu.org; Mon, 21 Sep 2020 15:14:38 -0400 Original-Received: from mail.gandi.net (m91-129-108-13.cust.tele2.ee [91.129.108.13]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 3D78320000D; Mon, 21 Sep 2020 19:14:29 +0000 (UTC) In-Reply-To: <87wo0rjqpu.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 18 Sep 2020 12:59:09 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188638 Archived-At: > (ert-deftest lisp-delete-pair-quotes-in-text-mode () > "Test \\[delete-pair] against string in Text Mode for #15014." > (with-temp-buffer > (text-mode) > (insert "\"foo\"") > (goto-char (point-min)) > (delete-pair) > (should (string-equal "fo\"" (buffer-string))))) > > So in text mode, delete-pair just deletes two characters, and that > doesn't seem helpful. The patch I reverted made it bug out instead, > which seems better. Yes, it's better to bug out than to delete text instead of deleting quotes. > I think the current thing delete-pair does in text-mode is bad, so I'm > inclined to re-apply the patch, and announce this as an incompatible > change in NEWS (and explain how to get the behaviour described above > back). > > Any opinions? If it's really impossible to delete a pair in text-mode, then better to signal an error.