From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#44294: No widen by xref-find-definitions Date: Sat, 31 Oct 2020 21:41:03 +0200 Organization: LINKOV.NET Message-ID: <871rhep4j4.fsf@mail.linkov.net> References: <87mu06p1aw.fsf_-_@mail.linkov.net> <5cfcbbf0-beef-3c0a-9641-a010925dbda4@yandex.ru> <87r1pgivdz.fsf@mail.linkov.net> <871rhgcgen.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20877"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 44294@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 31 20:47:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYwqJ-0005LL-TH for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Oct 2020 20:47:15 +0100 Original-Received: from localhost ([::1]:56120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYwqI-0002E7-Ul for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Oct 2020 15:47:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYwp8-0001l6-SV for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2020 15:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51270) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYwp8-0003Mi-Iy for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2020 15:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYwp8-0004bY-H3 for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2020 15:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Oct 2020 19:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 44294-submit@debbugs.gnu.org id=B44294.160417353617646 (code B ref 44294); Sat, 31 Oct 2020 19:46:02 +0000 Original-Received: (at 44294) by debbugs.gnu.org; 31 Oct 2020 19:45:36 +0000 Original-Received: from localhost ([127.0.0.1]:34580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYwoh-0004aR-CG for submit@debbugs.gnu.org; Sat, 31 Oct 2020 15:45:35 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:36715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYwof-0004Zi-1n; Sat, 31 Oct 2020 15:45:33 -0400 X-Originating-IP: 91.129.102.160 Original-Received: from mail.gandi.net (m91-129-102-160.cust.tele2.ee [91.129.102.160]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 3B54FFF803; Sat, 31 Oct 2020 19:45:25 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Fri, 30 Oct 2020 18:54:34 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192301 Archived-At: tags 44294 fixed close 44294 28.0.50 thanks >> I see now what you mean. Then maybe better to revert the change in >> etags-goto-tag-location to restore its original behavior, and >> fix only its usage by xref, i.e. exactly the same change >> for xref-location-marker ((l xref-etags-location)) as was made >> for xref-location-marker ((l xref-elisp-location)): > > Sounds good. 'find-tag-in-order' calls 'widen' already, so 'find-tag' is > probably fine. > > I would personally combine the revert and the new change in one commit, but > either option will work, obviously. Thanks for the suggestion. Now installed and closed.