From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-devel@gnu.org
Cc: "Mattias Engdegård" <mattiase@acm.org>
Subject: Re: master aea9365 3/3: * lisp/gnus/gnus-search.el (gnus-search-contact-tables): Fix type.
Date: Fri, 06 Nov 2020 09:17:02 -0800 [thread overview]
Message-ID: <871rh676cx.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <20201106130103.DF32C20CAE@vcs0.savannah.gnu.org> ("Mattias Engdegård"'s message of "Fri, 6 Nov 2020 08:01:03 -0500 (EST)")
Mattias Engdegård <mattiase@savannah.gnu.org> writes:
> branch: master
> commit aea936562b033899f0b7160cc492bbea1006863b
> Author: Mattias Engdegård <mattiase@acm.org>
> Commit: Mattias Engdegård <mattiase@acm.org>
>
> * lisp/gnus/gnus-search.el (gnus-search-contact-tables): Fix type.
>
> A more precise type is desirable but at it is now correct ('list' is not).
> ---
> lisp/gnus/gnus-search.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/gnus/gnus-search.el b/lisp/gnus/gnus-search.el
> index 15d96e3..7ee7c53 100644
> --- a/lisp/gnus/gnus-search.el
> +++ b/lisp/gnus/gnus-search.el
> @@ -410,7 +410,7 @@ returned by `completion-at-point-functions'. That usually means
> a list of strings, a hash table, or an alist."
> :group 'gnus-search
> :version "28.1"
> - :type 'list)
> + :type '(repeat sexp))
Doesn't this type demand a list of lists? It could also be a list of
hashtables, or functions, or a mix of alist/list/function/hashtable...
next parent reply other threads:[~2020-11-06 17:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201106130101.11980.32709@vcs0.savannah.gnu.org>
[not found] ` <20201106130103.DF32C20CAE@vcs0.savannah.gnu.org>
2020-11-06 17:17 ` Eric Abrahamsen [this message]
2020-11-06 21:30 ` master aea9365 3/3: * lisp/gnus/gnus-search.el (gnus-search-contact-tables): Fix type Mattias Engdegård
2020-11-07 5:02 ` Eric Abrahamsen
2020-11-06 21:33 ` Basil L. Contovounesios
2020-11-06 21:54 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rh676cx.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.