From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Some minor suggestions to Tab Bar Date: Tue, 06 Apr 2021 00:19:27 +0300 Organization: LINKOV.NET Message-ID: <871rbojuox.fsf@mail.linkov.net> References: <87o8fhekvx.fsf@mail.linkov.net> <385DDC1B-F508-4165-87FD-FFE2461348A6@kuaishou.com> <87ft0nyrfb.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39437"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel To: Zhiwei Chen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 05 23:22:29 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTWg0-000AB1-L4 for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Apr 2021 23:22:28 +0200 Original-Received: from localhost ([::1]:41074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTWfz-0000yj-NL for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Apr 2021 17:22:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTWdn-0007vf-6q for emacs-devel@gnu.org; Mon, 05 Apr 2021 17:20:11 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:46735) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTWdj-00064L-9l for emacs-devel@gnu.org; Mon, 05 Apr 2021 17:20:10 -0400 X-Originating-IP: 91.129.107.223 Original-Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 2290360003; Mon, 5 Apr 2021 21:20:02 +0000 (UTC) In-Reply-To: (Zhiwei Chen's message of "Tue, 23 Mar 2021 12:17:56 +0000") Received-SPF: pass client-ip=217.70.183.195; envelope-from=juri@linkov.net; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267440 Archived-At: >> On Mar 23, 2021, at 2:47 AM, Juri Linkov wrote: >> >>> `tab-bar-switch-to-next-tab` and `tab-bar-switch-to-prev-tab` should have a >>> repeat-map property. >> >> #+begin_src emacs-lisp >> (defvar tab-bar-move-repeat-map >> (let ((map (make-sparse-keymap))) >> (define-key map "m" 'tab-move) >> (define-key map "M" (lambda () >> (interactive) >> (tab-move -1))) >> map) >> "Keymap to repeat tab move key sequences `C-x t m m'. >> Used in `repeat-mode'.") >> (put 'tab-move 'repeat-map 'tab-bar-move-repeat-map) >> #+end_src > > One nitpicking is that `C-x t m M m’ is not allowed since `(tab-move -1)` hasn’t a `repeat-map’ property. > Maybe name it tab-move-prev and set the property? These repeat maps are pushed as well in c049c8da58.