From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sergey Organov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: Should (buffer-list) ever return killed buffers? Date: Mon, 24 May 2021 18:14:03 +0300 Message-ID: <871r9wyxj8.fsf@osv.gnss.ru> References: <87wnrpujo0.fsf@osv.gnss.ru> <871r9w5jws.fsf_-_@osv.gnss.ru> <83a6okdx60.fsf@gnu.org> <6381ce45-24d5-90f7-c490-7006460f7f43@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4246"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org, cpitclaudel@gmail.com, monnier@iro.umontreal.ca To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 24 17:14:43 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llCHw-0000mZ-AK for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 17:14:40 +0200 Original-Received: from localhost ([::1]:51824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llCHv-0003yx-Dc for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 11:14:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llCHQ-0003KQ-MJ for emacs-devel@gnu.org; Mon, 24 May 2021 11:14:08 -0400 Original-Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]:42874) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llCHP-0005QZ-73; Mon, 24 May 2021 11:14:08 -0400 Original-Received: by mail-lf1-x12d.google.com with SMTP id a2so41129788lfc.9; Mon, 24 May 2021 08:14:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=oZedzQcvoujmAsHKzRUkbOI62j6cQ4qwTf38Z80gXG4=; b=VX+1lC+u0NpuyMDi696xaG+GQHqRvfBBhKw9UtZYkcaqa60ZiNT0RPC8VEZhXCAXKK LPGtV3xkxVMagiAhjUa1bzvpb+89XI9XahBWXi7Brm+P1lO6XIIJ6GCZfnxo+tIWNp1g VB5nALPGuKRKDB3/CS7ReajptysT65NAP1OzUs7piyEb3d4hAzaHLBFWGKvVXJd6T9Ur XKugqWuohP6dsA8VW80XLSA2sVuhjHyz0/PW6MLJm//6GmfZu6MHfBMYpL4isAdDLHMj qKix4d1MbnhfFeeJTIPTgFakCGiJtzloqnI7vSbQC0Iu40pOTipmh/h1QI4PA4fyMoKf 9izw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=oZedzQcvoujmAsHKzRUkbOI62j6cQ4qwTf38Z80gXG4=; b=UTqUBCrQrT2jz8W1wWZo+/AjmHmzmlEWasmphCXLHgyyDJiNTMX/3eeNEfmZvIxXpl pGuMQTLaShkyL21R8Z56yKsjq5I7pYrb3xGAIGd8lfrFaaWrFUGNRaOxiJVgTikP09St STvmo0lmHwUz1K3ndNdS71/GKMzhXi5ZeCseZ9OTRD0DMbytxOiFqPmTjgRw1exRdD5z 13p0c8OtfAEjYt22nmlI4mqu4fw/J0nXWydBdSQA+oNYJKoKv5KMJSwvp3IGMMAymTls rqlbguj9nLVpRx5Db+uOp+KwAD3a6Xn+ZpVzra0qWV8iZAQBSFA4w1uJREp3TfTLGNeu E+Kg== X-Gm-Message-State: AOAM533pULv4+scNnAqvWJADDT2dj1YvFKMbxXCNqRl2E6qCMRdddFiW sdlEbBmRQHnVM60nshZeascbAAPpugA= X-Google-Smtp-Source: ABdhPJxhOe8opr6zx+6qXAMXHQRxpUcWG8+JCRXBzNrDwC1L8uAmf5ssYry0fbjWMg+/woo0dDgJLg== X-Received: by 2002:a05:6512:220b:: with SMTP id h11mr10787584lfu.17.1621869245000; Mon, 24 May 2021 08:14:05 -0700 (PDT) Original-Received: from osv.localdomain ([89.175.180.246]) by smtp.gmail.com with ESMTPSA id e17sm1791525ljl.73.2021.05.24.08.14.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 May 2021 08:14:04 -0700 (PDT) In-Reply-To: <6381ce45-24d5-90f7-c490-7006460f7f43@gmx.at> (martin rudalics's message of "Mon, 24 May 2021 16:50:48 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::12d; envelope-from=sorganov@gmail.com; helo=mail-lf1-x12d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269765 Archived-At: martin rudalics writes: >>> + (unless (or (nill bufname) >>> + (eq (aref bufname 0) ?\s) ;; Don't kill internal buffers >>> (string-match-p preserve-regexp bufname)) >>> (kill-buffer buffer))))) >>> (delete-other-windows) >> >> AFAICT, kill-buffer already is a no-op when the buffer is dead. So >> what exactly does this fix? (Apologies if I'm missing something: I >> cannot say that I've read all the discussions in this thread to the >> last detail.) > > Sergey never told us but it's likely `aref' choking on nil. Exactly. Sorry for not saying from the beginning! -- Sergey