From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sergey Organov Newsgroups: gmane.emacs.devel Subject: [PATCH] Re: Should (buffer-list) ever return killed buffers? Date: Mon, 24 May 2021 16:41:07 +0300 Message-ID: <871r9w5jws.fsf_-_@osv.gnss.ru> References: <87wnrpujo0.fsf@osv.gnss.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36546"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , =?utf-8?Q?Cl=C3=A9ment?= Pit-Claudel , Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 24 15:42:30 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llAqk-0009BY-0Z for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 15:42:30 +0200 Original-Received: from localhost ([::1]:57152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llAqj-0007F7-1d for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 09:42:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llApU-00067T-9z for emacs-devel@gnu.org; Mon, 24 May 2021 09:41:12 -0400 Original-Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]:34415) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llApS-0006Pk-M7; Mon, 24 May 2021 09:41:12 -0400 Original-Received: by mail-lf1-x129.google.com with SMTP id f30so3709398lfj.1; Mon, 24 May 2021 06:41:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=fYFuwD2OdRwVcvTHYJSoB0qIYFgbukMC0RLXiHuHh3s=; b=p7A9touYz6SA/bpi7ND4zA7madVtXiTbKrZd7d5L4wZ452NVRbT9S37k7Fci8/T2Jz yOVI6YJroQJEZTgt5vm4Cud2N32g1LnENdQXRGL/hnYz2cZn3T+nrYgX6tnO+VR6OzYs 8Xq0bG/L/xIzpyo/3l/QOT+Vi6bWCugZH3ryZbpDLdKVD3cJGksXPVm3LC1VCLa7yqTW 3lN1SEIHlvxEHkSs6VvVouBZbZDJNVnePxGYcUGPRqu+zFS7cTp0q0MNAEgPghg3ypC7 nm2H4PaF+naqT1ZM3VOXBp0sP4PvswJu3tVapUoSZNmEgSBjZRKLhBW0RqiywuCtfFV8 C34A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=fYFuwD2OdRwVcvTHYJSoB0qIYFgbukMC0RLXiHuHh3s=; b=M2UdEBQAs3e7D2menUXbaYV+akYigUathrwFNeRKWcS4JCCu9SBjf5Aw7vtJdD6czB aEUFh5IHjzKbRgWvzwBViNdwfUDqFiW1Q0FuU6Glu8t/I2JFd6fLkEnsussq9pNTDgKR AtnOr33FJhbpbWu29jUr+nXtQ2cHni0b+NqYoJFZBq1L6KU16D2sYIpEOK4JF96JOR/L T9hnBCdsecX15VgHQ8S81nbiwjYguCRBQRSaun9Fwx0G5YoPHJWgq9WVMQVYk74q4nYD zjXDXY9bwZmrh0/yFozzMUK7vrVFl/8AAURb7RvpLROpWShZGDyk1hYciSR4RVxfPUvj Douw== X-Gm-Message-State: AOAM532dvgUZXf9Pbeyqc7DnaIbHGeoF/X4KwfnFjC1Ti4qf4AonfTjy 4slv6lV7zXqtXdRC4wnvPj8= X-Google-Smtp-Source: ABdhPJzCa0Q6/og6efgHLJdbl1Q6n2d1NnwT7HcpYEbwGhIc6/cOy/NwvCvJHVFjoF9E905NilnIvw== X-Received: by 2002:a05:6512:6ca:: with SMTP id u10mr10892696lff.179.1621863668453; Mon, 24 May 2021 06:41:08 -0700 (PDT) Original-Received: from osv.localdomain ([89.175.180.246]) by smtp.gmail.com with ESMTPSA id y16sm1192826lji.56.2021.05.24.06.41.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 May 2021 06:41:08 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sun, 23 May 2021 19:41:42 -0400") Received-SPF: pass client-ip=2a00:1450:4864:20::129; envelope-from=sorganov@gmail.com; helo=mail-lf1-x129.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269754 Archived-At: Stefan Monnier writes: >> Somehow it happens when `desktop-clear` is called from a timer and there >> is *Info* buffer out there, and apparently the one that is killed is >> >> "#" >> >> I'd like to know if this is a bug in `destop-clear`, `buffer-list`, >> info, or elsewhere? > > I strongly suspect that the problem goes as follows: > - buffer-list returns a list of buffers that are all live (i.e. no bug > there). > - while processing that list, some of its buffers die. > So I think the bug is in `desktop-clear` which should skip buffers that > have died between the call to `buffer-list` and the moment we get to > process them. OK, here is a patch that fixes the issue: lisp/desktop.el: check for killed buffers in desktop-clear diff --git a/lisp/desktop.el b/lisp/desktop.el index fb7c6c79a1..20d9e0f268 100644 --- a/lisp/desktop.el +++ b/lisp/desktop.el @@ -706,7 +706,8 @@ if different)." "\\)\\'"))) (dolist (buffer (buffer-list)) (let ((bufname (buffer-name buffer))) - (unless (or (eq (aref bufname 0) ?\s) ;; Don't kill internal buffers + (unless (or (nill bufname) + (eq (aref bufname 0) ?\s) ;; Don't kill internal buffers (string-match-p preserve-regexp bufname)) (kill-buffer buffer))))) (delete-other-windows) Thanks, -- Sergey Organov