From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Tue, 01 Jun 2021 13:00:45 +0100 Message-ID: <871r9laj6a.fsf@gmail.com> References: <87zgwlb4xc.fsf@gmail.com> <617d06ca-27bf-2ae8-26eb-1042123499d3@daniel-mendler.de> <87pmxhb1rs.fsf@gmail.com> <23510125-37b9-e87e-3590-5322f44772ce@daniel-mendler.de> <87y2c5nhsr.fsf@mail.linkov.net> <87h7irss50.fsf@mail.linkov.net> <43d1599e-2ba9-2efb-45c3-76c67d29a69d@daniel-mendler.de> <87tumrgqrb.fsf@gmail.com> <87tumq92pe.fsf@mail.linkov.net> <87lf82g10g.fsf@gmail.com> <87y2c24lww.fsf@mail.linkov.net> <871r9t2lsy.fsf@mail.linkov.net> <22880197-6d05-c821-2c58-328ed3cfc02e@daniel-mendler.de> <87eedruui3.fsf@gmail.com> <8dd915fe-fe67-2a45-67ff-8aaa3e9b9aca@daniel-mendler.de> <878s3zuq47.fsf@gmail.com> <09f2a253-84ba-5cfd-552e-0b89109864a5@daniel-mendler.de> <875yyxaoxp.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12927"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Dmitry Gutov , "emacs-devel@gnu.org" , monnier@iro.umontreal.ca, Juri Linkov To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 01 14:02:42 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lo36X-000389-8K for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Jun 2021 14:02:41 +0200 Original-Received: from localhost ([::1]:42750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lo36W-0006hm-Bp for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Jun 2021 08:02:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo34s-0005h4-0w for emacs-devel@gnu.org; Tue, 01 Jun 2021 08:00:58 -0400 Original-Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:42716) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lo34p-0004ix-QH for emacs-devel@gnu.org; Tue, 01 Jun 2021 08:00:57 -0400 Original-Received: by mail-wr1-x433.google.com with SMTP id c5so2838010wrq.9 for ; Tue, 01 Jun 2021 05:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=5XivHQA5RKF/CN4ObUcDzv6wGUVrNRiZ9n6Esyaorm0=; b=sxMZGjdRjsCJSRkB0uHC2DB5lOa/jD4zN1zE/nSH6RymA4EYnNl6u6xSqNHXp960dy mOqCDlgJyU3kzpd7a0H0hUaQY+jqC3qfBam5r38S8v1koPweJo0oNzTG8l+ABE1ScVnu uuaQ083Egs7dty/vcX79juruweF4FKYYgn2+qxgtSNhCpUS0zkZ/M2BoD0JDkmpXiKab wQNjfWDpAI3HkYlpltfexwIECpaBS/M+dKE8yizOgR+WI4LepkxrAxnFTCF7N/0NGnM4 5S+EwW0d2MC/dLeRxtHqLJ64MuDSdByOH9MDqRFAivT9raFZ037GMzsW1ZFIhcayB1Kl noLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=5XivHQA5RKF/CN4ObUcDzv6wGUVrNRiZ9n6Esyaorm0=; b=tGXN14uDXayj9dQhB2kHItx6IS7ekOqeyHJEPka0CATeGbq/plv/nBwUTzkyZ53O1i bH8gY/YxSGbrelp/08fVR5H5iHHpaV95uEnxqp0d2a8O7ciC8W06OCKhzIifhHgfvk8Z w4AXjB8HjGyKnQSPtUuyORubZ5y9QPFa7JHCaowLZTN3G3+Zne42Df+wI0XPYXKF6ljZ CskiX2pXmeit5cBJ7VgrnbIIMBOB6SP5IcOIznHR3MZer0XszawuVNp2kli+ZsmNZsK1 YL6NVN6O05iTqqoRpY9P+lpG30Seb1BxXWZzMHF2iuKWna/bfWLxI/TltIVtTr9PFOqH nTOA== X-Gm-Message-State: AOAM530U6I/WI9NxqVnM0n8xoD4uE1ppxE/q0MA5qaMTHwzxSSDbQpkm Ic/Uao6eGzpzZ4TyVmXKT7xaEXmeguA= X-Google-Smtp-Source: ABdhPJzyE+KBlLkDl9qn9AwrdN1g0skp7C1uJgpEkrDe7BprcC37JMrvTgZsv23R5Xash6nzP0lzWQ== X-Received: by 2002:a5d:4dd0:: with SMTP id f16mr6511224wru.192.1622548848557; Tue, 01 Jun 2021 05:00:48 -0700 (PDT) Original-Received: from krug (a94-133-55-152.cpe.netcabo.pt. [94.133.55.152]) by smtp.gmail.com with ESMTPSA id v18sm3263636wrb.10.2021.06.01.05.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 05:00:48 -0700 (PDT) In-Reply-To: (Daniel Mendler's message of "Tue, 1 Jun 2021 13:27:41 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=joaotavora@gmail.com; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270192 Archived-At: Daniel Mendler writes: > On 6/1/21 11:56 AM, Jo=C3=A3o T=C3=A1vora wrote: >>> From my side the changes in your icomplete-vertical-mode-improvements >>> branch are fine. >>=20 >> I didn't get a terrible amount of feedback, but I spent the week testing >> that branch, making small adjustments, and verifying that the default >> Icomplete and Fido behaviour are unchanged. So I've now pushed the >> icomplete-vertical-mode rework to master. I quite like it, to be >> honest. I also added little filtered/total indicator idea found in >> Vertico and many other completers. >>=20 >> Here's a gif showing how to use it with Fido, my preferred option. To >> try it out, just M-x fido-mode and M-x fido-vertical-mode together. > > Thanks! I just gave it another try. It looks good and feels similar to > my Vertico. It works also well with Marginalia. > > * I observed an issue with the last candidate with `icomplete-scroll=3Dt` > - The candidate is one line off the minibuffer screen. Hmm, I don't see that problem. Are you sure you're using the version in master? Else you may be seeing a bug that was in scratch/icomplete-vertical-mode-improvements (which should now be scratched, as the name implies). > * Is it possible to disable the index/count indicator? In Vertico I use > `vertico-count-format` for that, if nil, the indicator is disabled. I normally don't add a knob for things until someone actually requests it. If you're requesting it, then it can be added (and you can too). > * Do you plan to add more scroll commands, scroll forward/backward by > one page as Vertico has it? See > https://github.com/minad/vertico#key-bindings for the Vertico > keybindings. Could be added, yes. > * Do you plan to support the `group-function`? Maybe, but nothing in Emacs uses it so I can't test. You can add it too, of course. I don't understand one thing about that protocol: why the extra TRANSFORM argument flag? Why not just have that function return a tuple with the group title and transformed name? Jo=C3=A3o