From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Context menus and mouse-3 Date: Wed, 14 Jul 2021 02:32:35 +0300 Organization: LINKOV.NET Message-ID: <871r8123jg.fsf@mail.linkov.net> References: <20200914061111.3trmuzhdvv7nwdcc@Ergus> <87y2acv2tw.fsf@mail.linkov.net> <87sg0jt7bo.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29569"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: philipk@posteo.net, Richard Stallman , spacibba@aol.com, emacs-devel@gnu.org, arthur.miller@live.com, dgutov@yandex.ru, ghe@sdf.org, drew.adams@oracle.com To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 14 01:36:22 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m3Rws-0007Yf-93 for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Jul 2021 01:36:22 +0200 Original-Received: from localhost ([::1]:53860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3Rwq-0006S6-8b for ged-emacs-devel@m.gmane-mx.org; Tue, 13 Jul 2021 19:36:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3RwG-0005h6-Pe for emacs-devel@gnu.org; Tue, 13 Jul 2021 19:35:44 -0400 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:45945) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3RwE-0006MP-GJ; Tue, 13 Jul 2021 19:35:44 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 62E16240004; Tue, 13 Jul 2021 23:35:33 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Mon, 12 Jul 2021 23:01:13 -0400") Received-SPF: pass client-ip=217.70.178.230; envelope-from=juri@linkov.net; helo=relay10.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271204 Archived-At: >> I tried to override the global [context-menu] with e.g. menu-bar-custom-menu >> (that later could be replaced with the value returned from mouse-context-menu-function): >> >> (let ((map (make-sparse-keymap))) >> (define-key map [context-menu] menu-bar-custom-menu) >> (set-transient-map map)) >> (push (cons 'context-menu (cdr event)) unread-command-events) >> >> However, it doesn't override the global [context-menu], but prepends >> the transient [context-menu] before the global one. > > Yes, if the key is bound in various keymaps and all the bindings are to > a keymap, then those keymaps get merged, as usual for prefix keymaps. > > Two ways to solve that: > - use `mouse-context-menu-function` instead of adding a new local > key binding for `context-menu`. > - don't bind `context-menu` to a keymap but to a command (that > presumably then uses `popup-menu` internally). `popup-menu` has the same problems: it doesn't run post/pre-command-hook, etc. because it uses `call-interactively`. So any code that is based on `popup-menu` such as `org-mouse-show-context-menu` has the same problems, and any code that uses `call-interactively` such as `tmm-prompt`. But it's possible to replace `call-interactively` with something like: (let ((command (car (x-popup-menu event menu-bar-custom-menu))) (map (make-sparse-keymap))) (define-key map [next-command] command) (set-transient-map map t)) (push (cons 'next-command (cdr event)) unread-command-events) It works surprisingly well, and I really see no problems with this.