bug#46913: dired-do-compress doesn't work on files in inserted subdirectories

["Michalis V." <mvar.40k@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]


hi Eli,

Eli Zaretskii <eliz@gnu.org> writes:
>> So another solution which is a bit more hackish is the following
>> (and also attached as a patch)
>
> Why not use file-relative-name instead?

i was totally, 100% oblivious that this existed. It simplifies the
solution even more.

> Btw, please don't use "path" for anything that is not PATH-style
> directory lists: the GNU Coding Standards frown on such uses.  We use
> "file name" or "absolute file name" or "leading directories" instead,
> as appropriate for the context.
>
> Thanks.

i'll do so, thank you!

Michalis


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: dired-aux.patch --]
[-- Type: text/x-patch, Size: 679 bytes --]

diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
index f2cb745ad4..023531038f 100644
--- a/lisp/dired-aux.el
+++ b/lisp/dired-aux.el
@@ -1246,7 +1246,7 @@ dired-do-compress-to
                                   (?i . ,(mapconcat
                                           (lambda (in-file)
                                             (shell-quote-argument
-                                             (file-name-nondirectory in-file)))
+                                             (file-relative-name in-file)))
                                           in-files " "))))))
              (message (ngettext "Compressed %d file to %s"
 			        "Compressed %d files to %s"