From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] New tab-bar-detach-tab command Date: Wed, 29 Sep 2021 14:54:52 -0500 Message-ID: <871r57i2cz.fsf@alphapapa.net> References: <87h7e4ikkz.fsf@alphapapa.net> <87pmsrrh7y.fsf@mail.linkov.net> <875yujizgi.fsf@alphapapa.net> <87o88bb21y.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23312"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 29 22:03:15 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVfnO-0005ot-9Z for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Sep 2021 22:03:14 +0200 Original-Received: from localhost ([::1]:59856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVfnM-0003Sa-Vj for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Sep 2021 16:03:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVffX-00009e-Jh for emacs-devel@gnu.org; Wed, 29 Sep 2021 15:55:07 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:55628) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVffV-0005oD-03 for emacs-devel@gnu.org; Wed, 29 Sep 2021 15:55:07 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mVffR-0005c8-Nb for emacs-devel@gnu.org; Wed, 29 Sep 2021 21:55:01 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275830 Archived-At: Juri Linkov writes: > I confirm that the issue Matt noted is corrected by your patch. > So I pushed your patch (with a small correction of 0/1 indexing). > Thanks to you and to Matt. Thanks. > Also I fixed another issue noted by Matt: > “tab-close: Attempt to delete the sole tab in a frame”. > This is fixed now to delete the whole frame when its last tab > was moved to another frame. Great! >>>> It might be worth binding it to something like "C-x t D" as well, >>>> assuming the command is worth merging. :) >>> >>> Currently I'm developing a command that will detach a window >>> to a new tab, i.e. it will delete the selected window >>> from the current tab after moving it to the new tab. >>> And I'd like to add a keybinding to it with the same mnemonics "D" :-) >> >> Hm, what if the new window-detaching command were on "C-x t d", and the >> new tab-detaching command were on "C-x t D"? Of course, "C-x t d" is >> currently bound to 'dired-other-tab', but it seems like that should be >> covered by 'other-tab-prefix', i.e. "C-x t t C-x d". > > 'C-x t d' was modeled after 'C-x 5 d' (dired-other-frame), > and since I use 'C-x t d' all the time, I expect that other users > might be accustomed to it as well. We need to find a new key > or better a key prefix to accommodate more future keys. Makes sense. Thanks.