From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Alan Mackenzie <acm@muc.de>, 50946-done@debbugs.gnu.org
Subject: bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands
Date: Sat, 02 Oct 2021 01:48:31 +0100 [thread overview]
Message-ID: <871r54xnds.fsf@gmail.com> (raw)
In-Reply-To: <831r54einq.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 01 Oct 2021 20:53:13 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Fri, 1 Oct 2021 17:10:57 +0000
>> From: Alan Mackenzie <acm@muc.de>
>>
>> In emacs -Q in the emacs-28 branch, create the following two line file,
>> foobar.el, and try to load it:
>>
>> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
>> (defvar foo-baz "foobar-baz")
>> FOOBARELISP-SHORTHANDS: (("foo" . "foobar")))
>> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
>>
>> This will throw an error, but that isn't important.
>>
>> What is important is that the symbol foobar-baz is created by the
>> elisp-shorthands facility.
>>
>> This shouldn't happen since:
>> 1/- There is no Local Variables section.
>> 2/- There is no variable elisp-shorthands in that non-existent section.
>>
>> The following errors are evident in hack-elisp-shorthands:
>> 1/- The code doesn't check for a correctly formatted Local Variables
>> section.
>> 2/- The code, even if it did check, would only check the last 3000 bytes
>> in the file. The section can occur anywhere in the last 3000
>> CHARACTERS.
>> 3/- The code doesn't do a case-sensitive search for "elisp-shorthands".
>> 4/- The code doesn't check for "elisp-shorthands" being a complete
>> symbol.
>> 5/- The code doesn't even check that "elisp-shorthands" is in a comment.
>
> Thanks.
>
> João, could you please look into this?
Done. In the Emacs 28 branch. All tests pass (except a strange
'seccomp' one that never did). Let me know if some more bugs lurk.
Addressed all the points except the last one which doesn't make much
sense, since normal `hack-local-variables` also doesn't do any such
check. In fact what I'm doing is re-using
hack-local-variables--find-variables from files.el, as I had wanted to
anyway.
João
next prev parent reply other threads:[~2021-10-02 0:48 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 17:10 bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands Alan Mackenzie
2021-10-01 17:53 ` Eli Zaretskii
2021-10-01 21:15 ` João Távora
2021-10-02 6:10 ` Eli Zaretskii
2021-10-02 0:48 ` João Távora [this message]
2021-10-02 10:50 ` Alan Mackenzie
2021-10-02 11:13 ` João Távora
2021-10-02 11:38 ` João Távora
2021-10-02 12:38 ` Alan Mackenzie
2021-10-02 12:52 ` Eli Zaretskii
2021-10-02 13:57 ` Alan Mackenzie
2021-10-02 14:19 ` Eli Zaretskii
2021-10-02 14:45 ` Alan Mackenzie
2021-10-02 15:00 ` Eli Zaretskii
2021-10-02 20:07 ` Alan Mackenzie
2021-10-03 11:45 ` Eli Zaretskii
2021-10-03 12:10 ` bug#50946: insert-file-contents can corrupt buffers. [Was: bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands] Alan Mackenzie
2021-10-03 12:40 ` Eli Zaretskii
2021-10-03 13:33 ` Alan Mackenzie
2021-10-03 15:04 ` bug#50946: insert-file-contents can corrupt buffers Alan Mackenzie
2021-10-03 15:25 ` Eli Zaretskii
2021-10-03 17:21 ` Alan Mackenzie
2021-10-03 17:36 ` Eli Zaretskii
2021-10-03 18:19 ` Alan Mackenzie
2021-10-03 15:34 ` bug#50946: insert-file-contents can corrupt buffers. [Was: bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands] João Távora
2021-10-03 15:42 ` João Távora
2021-10-03 15:56 ` Eli Zaretskii
2021-10-03 16:02 ` João Távora
2021-10-03 16:20 ` Eli Zaretskii
2021-10-03 17:05 ` João Távora
2021-10-03 17:56 ` Eli Zaretskii
2021-10-03 18:59 ` João Távora
2021-10-03 19:51 ` Eli Zaretskii
2021-10-03 19:59 ` João Távora
2021-10-02 15:02 ` bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands João Távora
2021-10-04 0:14 ` Richard Stallman
2021-10-02 14:47 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r54xnds.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=50946-done@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.