* 2021-12-02 16:06:33-0800, Stefan Kangas wrote:

> I would like to suggest that we start signing git tags in our
> repository.

Good idea, at least in general.

> -     cd EMACS_ROOT_DIR && git tag -a TAG -m "Emacs TAG"
> +     cd EMACS_ROOT_DIR && git tag -a -s TAG -m "Emacs TAG"

Don't use "-a" and "-s" together, just use "-s". A quote from git-tag(1)
manual:

       -a, --annotate
           Make an unsigned, annotated tag object

       -s, --sign
           Make a GPG-signed tag, using the default e-mail address’s key.
           The default behavior of tag GPG-signing is controlled by
           tag.gpgSign configuration variable if it exists, or disabled
           otherwise. See git-config(1).

> -     git tag -a TAG -m "Emacs TAG" SHA1
> +     git tag -a -s TAG -m "Emacs TAG" SHA1

> -     git tag -a emacs-28.0.90  -m "Emacs 28.0.90 pretest"
> -     git tag -a emacs-28.1-rc1 -m "Emacs 28.1 RC1"
> -     git tag -a emacs-28.1     -m "Emacs 28.1 release"
> +     git tag -a -s emacs-28.0.90  -m "Emacs 28.0.90 pretest"
> +     git tag -a -s emacs-28.1-rc1 -m "Emacs 28.1 RC1"
> +     git tag -a -s emacs-28.1     -m "Emacs 28.1 release"

The same here.

-- 
/// Teemu Likonen - .-.. https://www.iki.fi/tlikonen/
// OpenPGP: 6965F03973F0D4CA22B9410F0F2CAE0E07608462