all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, 52380@debbugs.gnu.org
Subject: bug#52380: ERT, buffers and windows
Date: Fri, 10 Dec 2021 21:58:16 +0100	[thread overview]
Message-ID: <871r2k9nyv.fsf@gmail.com> (raw)
In-Reply-To: <831r2krymd.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 Dec 2021 22:30:50 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
>> Date: Fri, 10 Dec 2021 21:09:30 +0100
>> Cc: 52380@debbugs.gnu.org
>> 
>> If I amend the test as follows:
>> 
>> diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/python-tests.el
>> index 15bda5c197..783f115fc7 100644
>> --- a/test/lisp/progmodes/python-tests.el
>> +++ b/test/lisp/progmodes/python-tests.el
>> @@ -5454,6 +5454,7 @@ python-tests--bug31398
>>    "Test for https://debbugs.gnu.org/31398 ."
>>    (skip-unless (executable-find python-tests-shell-interpreter))
>>    (let ((buffer (process-buffer (run-python nil nil 'show))))
>> +    (should (eq (get-buffer-window buffer) (selected-window)))
>>      (should (eq buffer (current-buffer)))
>>      (pop-to-buffer (other-buffer))
>>      (run-python nil nil 'show)
>> 
>> … then (should (eq (get-buffer-window buffer) (selected-window)))
>> passes, but (should (eq buffer (current-buffer))) does not.  Does that
>> make sense to anyone?
>
> You assume that the selected window always shows the current buffer?
> That's not in general true.

Mmm, thanks.  I see that "(elisp) Current Buffer" has things to say on
the subject:

>    When an editing command returns to the editor command loop, Emacs
> automatically calls ‘set-buffer’ on the buffer shown in the selected
> window (*note Selecting Windows::).

In the context of ERT, what would be the correct way to test that after
calling M-x run-python (≡ (run-python nil nil 'show)), the *Python*
buffer is visible, and its window is selected?

Should we just disregard (current-buffer) when writing ERT tests, and
assert things in terms of (selected-window)?  Or is there a way to make
ERT "return to the editor command loop", thereby selecting the buffer
shown in the selected window?





  reply	other threads:[~2021-12-10 20:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-08 23:10 bug#52380: 28.0.50; [PATCH] run-python no longer focuses interpreter Kévin Le Gouguec
2021-12-10 12:06 ` Lars Ingebrigtsen
2021-12-10 12:08   ` Lars Ingebrigtsen
2021-12-10 19:26     ` Kévin Le Gouguec
2021-12-10 20:09       ` bug#52380: ERT, buffers and windows (was: bug#52380: 28.0.50; [PATCH] run-python no longer focuses interpreter) Kévin Le Gouguec
2021-12-10 20:30         ` Eli Zaretskii
2021-12-10 20:58           ` Kévin Le Gouguec [this message]
2021-12-11 22:23     ` bug#52380: 28.0.50; [PATCH] run-python no longer focuses interpreter Kévin Le Gouguec
2021-12-12  6:40       ` Lars Ingebrigtsen
2021-12-12 14:03         ` bug#52380: 28.0.50; [PATCH v2] " Kévin Le Gouguec
2021-12-13  4:17           ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r2k9nyv.fsf@gmail.com \
    --to=kevin.legouguec@gmail.com \
    --cc=52380@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.