From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' Date: Wed, 29 Dec 2021 16:00:44 +0100 Message-ID: <871r1v8nhf.fsf@gnus.org> References: <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org> <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30158"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , Sam Steingold To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 29 16:01:59 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2aSl-0007er-PE for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Dec 2021 16:01:59 +0100 Original-Received: from localhost ([::1]:54000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2aSk-0006vL-9I for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Dec 2021 10:01:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2aRg-000696-Vy for emacs-devel@gnu.org; Wed, 29 Dec 2021 10:00:53 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=60350 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2aRf-0001Vh-FE; Wed, 29 Dec 2021 10:00:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2VQfjXANkLmHOJ2kx24fWmzK2i05cIkPZICJZWznZp0=; b=TllV2odOf2KtVvXQjNfG431tIy aT4exVl7Km8T+dAQDQcsuxoFTG9TkWcyeekGkBV0uV6rn4GAHP8dWnle3uOP3YV0l/A4Po8YVxv0+ aTVObEXbHCxo7UpXGZqhVj1j6GUK1MJlaqZNZBmw/jsjzgtxnE8to6/nN/IDURt3squY=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2aRa-0006xp-AE; Wed, 29 Dec 2021 16:00:48 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEW4t7VGR0qHhXv/ ///x/LKyAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+UMHQ46Mgo+4CEAAAGxSURBVCjPnZHBitswEIZ/ RFMUHQuGdk9uaIKjpwhlL+0pBY9xdVoMhsRP4Zq2JDotJQohJ1XUxtZTdrx9g+qkb/5h5p8Z4H/e InfFiFY1NjJc3B+OpTYG4PXFmRGQKnoI2YqwpvrpFFsOyXerhOr9SXtAxO0vR/XB8h9ilSREx0Zn 2QxvtrOC7jCn3bUzUfnAeUm5uNx9qmK8MRST6dsMw1whKfrwA6maRAsiMnO7GH7vZiAqYlXFA5t6 W56PH/wo1MiwLte0wKQsuKn2S5PQs7IdKyJdmiuNme86hrDcOwrSZtwnevu0psMQKp60r05+TWW8 bDTSqbIzNNvYYzVVnxnMYYoDBIJsWbHDOI8K2T5QOdnR8sLw+O3KaWLzk4X2u3e1CTZq3mjj9gnD 7hSg+i914Zy5Ba+h6MjzkOE6G5zpExW6L6UMI8Oxzl9tykzrgJ52fYkpV21nX2Avmhyru8VAO7sX 4gKpI66uu7GpOzqtMWjM8ID3Ywre3+zW8glTRNk9ppkQEBwbFsfi/nweRLsCcj7b13JqFOcjd0Su 7Cu2mf5b/K2vPipWXqAh4yXwF3+OrVImlzwHAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTEyLTI5 VDE0OjU4OjQ5KzAwOjAwLcSN4wAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0xMi0yOVQxNDo1ODo0 OSswMDowMFyZNV8AAAAASUVORK5CYII= X-Now-Playing: Four Tet's _Paws_: "Glue of the World" In-Reply-To: <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org> (Sam Steingold's message of "Tue, 28 Dec 2021 17:30:09 -0500 (EST)") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283563 Archived-At: Sam Steingold writes: > Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' > > * lisp/window.el (display-comint-buffer-action): New `defcustom`, > defaults to 'display-buffer-same-window' for backward compatibility. Others have noted the technical problems with this patch, but as the discussion in bug#52467 showed, Emacs already has capabilities for customising the behaviour here (via the general display machinery), and adding something cross-cutting but specific to the coming-derived modes just seems odd to me, so I'd be in favour of reverting this patch. Any opinions? Eli? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no