all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tsdh@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, mardani29@yahoo.es, raman@google.com
Subject: Re: info-lookup-alist mangled, breaks C-h S
Date: Tue, 04 Jan 2022 17:19:33 +0100	[thread overview]
Message-ID: <871r1n320e.fsf@gnu.org> (raw)
In-Reply-To: <83ee5nblfv.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

Hi Eli,

>> FWIW, the problematic entry doesn't seem to come from some external
>> package, at least I can reproduce the error using
>> 
>>   1. emacs -Q
>>   2. M-x fundamental-mode RET in *stratch*
>>   3. C-h S
>> 
>> with GNU Emacs 29.0.50 of 2022-01-03.  The step 2 above is needed
>> because `C-h S' in an emacs-lisp-mode or lisp-interaction-mode buffer
>> works just fine whereas I get the error in fundamental-mode or
>> Info-mode.  I can't reproduce with emacs 27 or 28.
>
> Does the patch below give good results?

Yes, it does, thanks!

Bye,
Tassilo

> diff --git a/lisp/info-look.el b/lisp/info-look.el
> index e6f267d..9224aa3 100644
> --- a/lisp/info-look.el
> +++ b/lisp/info-look.el
> @@ -347,7 +347,10 @@ info-lookup-select-mode
>  
>  (defun info-lookup-change-mode (topic)
>    (let* ((completions (mapcar (lambda (arg)
> -				(cons (symbol-name (car arg)) (car arg)))
> +                                (let ((mode-spec (car arg)))
> +                                  (and (consp mode-spec)
> +                                       (setq mode-spec (car mode-spec)))
> +				  (cons (symbol-name mode-spec) mode-spec)))
>  			      (info-lookup->topic-value topic)))
>  	 (mode (completing-read
>  		(format "Use %s help mode: " topic)




  parent reply	other threads:[~2022-01-04 16:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-02 16:52 info-lookup-alist mangled, breaks C-h S T.V Raman
2022-01-03 10:35 ` Daniel Martín
2022-01-03 14:45   ` T.V Raman
2022-01-03 20:02     ` Tassilo Horn
2022-01-04 14:54       ` Eli Zaretskii
2022-01-04 15:03         ` Eli Zaretskii
2022-01-05 15:33           ` Lars Ingebrigtsen
2022-01-05 16:46             ` Eli Zaretskii
2022-01-05 17:33             ` T.V Raman
2022-01-04 16:19         ` Tassilo Horn [this message]
2022-01-04 16:27           ` T.V Raman
2022-01-04 16:46           ` Eli Zaretskii
2022-01-05 13:18             ` Eli Zaretskii
2022-01-04 15:45       ` T.V Raman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r1n320e.fsf@gnu.org \
    --to=tsdh@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mardani29@yahoo.es \
    --cc=raman@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.