From: Lars Ingebrigtsen <larsi@gnus.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 53715@debbugs.gnu.org
Subject: bug#53715: 29.0.50; [PATCH] Improve correctness of pipelines in Eshell
Date: Wed, 02 Feb 2022 19:10:22 +0100 [thread overview]
Message-ID: <871r0lrvg1.fsf@gnus.org> (raw)
In-Reply-To: <75056e6b-c739-a48c-2bf8-56ddc456da8e@gmail.com> (Jim Porter's message of "Tue, 1 Feb 2022 19:32:10 -0800")
Jim Porter <jporterbugs@gmail.com> writes:
> This happens because Eshell only keeps track of the tail process when
> running an external process, so when sending stdin, it gets sent to
> the tail process (`rev'), not the head (`tr'). I fixed this in the
> second patch by recording both the head and tail processes and
> updating the various places that use the current process to use the
> right one.
These patches seem to lead to a number of tests failing:
Test eshell-test/last-result-var2 condition:
(void-variable eshell-last-async-proc)
FAILED 22/34 eshell-test/last-result-var2 (0.001074 sec) at lisp/eshell/eshell-tests.el:164
passed 23/34 eshell-test/lisp-command (0.000350 sec)
passed 24/34 eshell-test/lisp-command-args (0.000308 sec)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-02-02 18:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 3:32 bug#53715: 29.0.50; [PATCH] Improve correctness of pipelines in Eshell Jim Porter
2022-02-02 18:10 ` Lars Ingebrigtsen [this message]
2022-02-02 19:41 ` Jim Porter
2022-02-02 19:49 ` Lars Ingebrigtsen
2022-02-02 21:01 ` Jim Porter
2022-02-03 2:35 ` Jim Porter
2022-02-03 19:03 ` Lars Ingebrigtsen
2022-02-05 6:51 ` Jim Porter
2022-02-05 6:59 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r0lrvg1.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=53715@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.