From: Stephen Berman <stephen.berman@gmx.net>
To: Po Lu <luangruo@yahoo.com>
Cc: 52697-done@debbugs.gnu.org
Subject: bug#52697: 29.0.50; pgtk: wrong initial frame parameter values
Date: Tue, 08 Feb 2022 15:12:26 +0100 [thread overview]
Message-ID: <871r0d1m7p.fsf@rub.de> (raw)
In-Reply-To: <87leyl4gvu.fsf@yahoo.com> (Po Lu's message of "Tue, 08 Feb 2022 21:39:17 +0800")
On Tue, 08 Feb 2022 21:39:17 +0800 Po Lu <luangruo@yahoo.com> wrote:
> Stephen Berman <stephen.berman@gmx.net> writes:
>
>> Thanks very much, I confirm your patch essentially fixes the bug, except
>> for mistakenly switching the top and left parameters:
>>
>> diff --git a/src/pgtkterm.c b/src/pgtkterm.c
>> index e9fd5f83b7..8faffe94d4 100644
>> --- a/src/pgtkterm.c
>> +++ b/src/pgtkterm.c
>> @@ -5552,7 +5552,7 @@ configure_event (GtkWidget *widget,
>>
>> if (f->win_gravity == NorthWestGravity)
>> gtk_window_get_position (GTK_WINDOW (widget),
>> - &f->top_pos, &f->left_pos);
>> + &f->left_pos, &f->top_pos);
>> else
>> {
>> f->top_pos = event->configure.y;
>>
>>
>> Steve Berman
>
> Thanks, should be fixed now on master.
Thanks, with that I'm closing the bug.
Steve Berman
prev parent reply other threads:[~2022-02-08 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 9:05 bug#52697: 29.0.50; pgtk: wrong initial frame parameter values Stephen Berman
2022-02-08 11:57 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-08 12:48 ` Stephen Berman
2022-02-08 13:39 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-08 14:12 ` Stephen Berman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r0d1m7p.fsf@rub.de \
--to=stephen.berman@gmx.net \
--cc=52697-done@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.