From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew Cohen Newsgroups: gmane.emacs.bugs Subject: bug#54532: [PATCH] sorting Date: Thu, 24 Mar 2022 07:31:41 +0800 Message-ID: <871qysgs9u.fsf@ust.hk> References: <87k0clr12o.fsf@ust.hk> <83cziceq8e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4433"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 54532@debbugs.gnu.org, Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , larsi To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 24 00:33:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXATY-0000xJ-3F for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Mar 2022 00:33:13 +0100 Original-Received: from localhost ([::1]:41288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXATW-0004wA-NL for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Mar 2022 19:33:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49876) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXATO-0004u5-Bc for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2022 19:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52417) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nXATO-0008CM-2J for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2022 19:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nXATN-0000Xh-Ms for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2022 19:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrew Cohen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Mar 2022 23:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54532 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54532-submit@debbugs.gnu.org id=B54532.16480783232012 (code B ref 54532); Wed, 23 Mar 2022 23:33:01 +0000 Original-Received: (at 54532) by debbugs.gnu.org; 23 Mar 2022 23:32:03 +0000 Original-Received: from localhost ([127.0.0.1]:46314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXASR-0000WO-Gd for submit@debbugs.gnu.org; Wed, 23 Mar 2022 19:32:03 -0400 Original-Received: from mail-os0jpn01on2101.outbound.protection.outlook.com ([40.107.113.101]:38341 helo=JPN01-OS0-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXASP-0000Vu-1V for 54532@debbugs.gnu.org; Wed, 23 Mar 2022 19:32:02 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dW8rkXe7ojjJfdpCoXcqa3SArxwNaX4Src2d4EhLwzW8j+DXSxYqRzghknAoJTPVRDIKAwbffNtW8sLFSAsFzCzIyZt5csZaDCYPvcLyXuCA5+ppnCF/6Nu0g9cRXznQR/uvNmixJSXoIBhNwS1P6mLyWmoafgLPIo/OxIe2UsxzLTlQqtMsN/KCQUsCfTl4MuAvnLvrhAHCBLvzD/XqzkX6uj14jXWQe0cE7TkGn8buwXX1SMyCg9i3peWUErYe9MPHuZ57Qw01U3p4o2+CnO2T42lpf3ON+/g0qtuidUS3dmSZJp7IFgAPDJNnEabI8AR2ho67nFc3pgv4UX6qlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Fz/PxUdzUjY2w4J7r/zr+gny46AGSYhw0LIZLaP+tU=; b=S2VdqWMKml4bOsVY/Ebh4+e2uFZVzQbCM3JhTz30SLHYNhZdFi9axIghh6SPbWdakWvmeFdYeCSCA1v9MLmeRTL/69pthOeBJtiYSlhjxOkwTeYJWqzW70CpBTmSnALweVJqz/wvv3Dkb5+FTELKLCD6h+SvEN2kNcjbNTMYtYdt8MY9Id7kn2zk3tWHtW0R9+ChjbrEgEufe1qDK1Nw56I6qmqMlGpn7Rvc5TxJVCk5xWySBKbkxYR9q5IteUY8fkg8sA/3q3UVlVLHOgwcjiued4vjFNt5whwP/eraAz9vcvCveTtDGw/c8HoJONEzpzlX8OebHODf1uu5Nr9qxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ust.hk; dmarc=pass action=none header.from=ust.hk; dkim=pass header.d=ust.hk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ust.hk; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Fz/PxUdzUjY2w4J7r/zr+gny46AGSYhw0LIZLaP+tU=; b=xKmuay+ejIMfm6JKQXAFFKnaek39IOXJ7NYppqXgsOobsGtuJNx3dyuz7THyqX8rVxlO9tRxxnxjalBEQ6BrnoHQ8MvHRumS8jRpnWTWDgQt+SUP6zR1yjW2eXklFFCD8EYTJOzuWS3IC9IRBtSpx2bdjBsh3f62PDS4tc0uM3+utUZ26Q8ofFun2sf/BVsqNJhT79Prbj2oJyP5uI5HPE6am643ekp6g+JD3zH7+xRFgx80lKNIExyqjsMoyNtzPc9upT0l5W3cB8abNe/Ucf8izg1yavpICsa2dESwQLpcttlh2XRQRcAl0l6byYitk/o40ULyJGRCP5Jshah/hQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ust.hk; Original-Received: from OSZP286MB1870.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:167::9) by OS3P286MB0707.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:e5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.17; Wed, 23 Mar 2022 23:31:53 +0000 Original-Received: from OSZP286MB1870.JPNP286.PROD.OUTLOOK.COM ([fe80::134:8477:848b:b601]) by OSZP286MB1870.JPNP286.PROD.OUTLOOK.COM ([fe80::134:8477:848b:b601%3]) with mapi id 15.20.5102.017; Wed, 23 Mar 2022 23:31:53 +0000 In-Reply-To: <83cziceq8e.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 23 Mar 2022 09:46:38 -0400") X-ClientProxiedBy: HK2PR04CA0070.apcprd04.prod.outlook.com (2603:1096:202:15::14) To OSZP286MB1870.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:167::9) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 80795e3f-cce1-4c7b-fa45-08da0d254fa3 X-MS-TrafficTypeDiagnostic: OS3P286MB0707:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qUh9FqzLk5T4NIVAknMj3sVaL4I9rcPHlce9JqP/1rY7qBLP1/NDon9SKlz5R55YDplonRow/m2JBkDz9iwFv+QA6LuB0iJJ7HMG9QpralrxPclJskbiBVO2+3/Zjhhs7N08vwxY4gxETD9h0zIrv+TjPw6afARPhfStk+oVxCQcal8EFFu170z8E3hMREM2379sEYT2657QaftSGcVGfIRhV5f+RebLhr4888GfCVY2ldOF2rk4sZobw6jQoTBcU+xreFdz+L1NQw6qWvs0boDKhHGaeo2m99viK7Xm/38Wk6b7+geHk65/CX+S2HFdLHBvAWtLchjaEvcgyH/75IKV8AGd2f9IAYbW5A4UW66ioPr7rsbtPQDHiFt+fsb1tZ26ONQSf6DP8BPF30YBM7Yk5s+9N4k437ZART1VjC6BHaiSK66MbV1XrC2cydaBxTPj80G5FEM9rpWNFaWGpKFzdwzyfFgEM4y0KqJtgozFDUSHBQM1CfVo9po8FIej6L0NvyAmiybukMMwbPgVvumUJZG410UcFN7OMfdF4cXNQ0yjKuAo11UqteO6wuIGKCyrBueXgLfY7YrOvYhGdTqhU5ygR8zCqsBGrZ+sRgy7XulFeX0BIcN0Hkd1DA6cTVbI+0akJs6r8zEk0/pDAA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OSZP286MB1870.JPNP286.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6512007)(2616005)(6486002)(508600001)(5660300002)(8936002)(6666004)(6506007)(36756003)(186003)(26005)(38100700002)(6916009)(54906003)(786003)(66556008)(316002)(4744005)(4326008)(8676002)(2906002)(86362001)(66946007)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: HA+AD+jYjk1JOXrMfdjW3uN9mePMR+CXwx99YMO7uyeFE/97a+xyJdeUlal+nx1S7ocI7muWcXC29tff3qFq+kGmNL4J5+95QEVvDWE8PdoaPYm7WYzcFZgmV20zvYND4ra6ogJzUx8GA/1hnpUpezlhc+sJCJyUtBoSIkLx9nTEGvFsUwuTdyTgBlTQAseTrGHPRVcez3RTxEJ65aiCFWzFh8FZA5++VahtLct0jV8hsDWsUPjmowkiT5o4AbryA5p1ItT93CCKhuCjMfEw7Uuf7KYN87+VCU+iE45MxLDwSLElPV/vXu/KaKbCXrd6jhYpGocjuv4QJ+cP5AFi2hXyGCe+yyqf9EEVkyho+PgPxT71hH34C/EjR7bLHRAm1LhD4P49Cb03ZL/tYTf4iCNWUuQSNa6o1iZ6lPvfsl27uu632WQ0B2Ad5rwNwHOh2zr/tQ8bCcLcAqUc6cw4xalW7c6q3/ZA3mrtOI4UcsdsfOv1st7NZyyOzJg+Q08glAw6tgiO0fseihmfGIaSXW7QX4JBGkzbqiMH9GnzDqdgteDCLmOH1KfYBXoCS7nWVgfg3+gimzU0HS4VTNIIhiYZvyCxMiWrDQD61dq5+5F47Tu2YPGQhGHjGe/QumMVx6vOcBQZA3nkdLZ52H7ZAZ3+4rQ+urR4MF+3m/rQzD7/LfUfdPOuDxHE+z/vWPYPqlyi/ErYkUtY0vBMGL5TufGD0pUFsCgVvE4ESJ1A8ksbe4C+9QYzz2L+Ku xe7Zzm/brS3Z8alCEEND1e9K6+295TQUdTganu6uoepaxP88bx040L7kWMXncjSsGXGnJ6dAHaUiQuSOebpdrLrr+VZf6XRlDt X-OriginatorOrg: ust.hk X-MS-Exchange-CrossTenant-Network-Message-Id: 80795e3f-cce1-4c7b-fa45-08da0d254fa3 X-MS-Exchange-CrossTenant-AuthSource: OSZP286MB1870.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2022 23:31:53.0869 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: c917f3e2-9322-4926-9bb3-daca730413ca X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C0cK1mJ49uX/iIwnUxVy+OQGkUVPXffpfNpC6DDsvUyI9Asa+3Z0GRl00oUT7Xsm X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3P286MB0707 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228841 Archived-At: >>>>> "EZ" == Eli Zaretskii writes: >> From: Andrew Cohen Date: Wed, 23 Mar 2022 >> 07:59:11 +0800 >> >> The patch has 4 parts: [...] EZ> Thanks, a few minor stylistic issues: [...] EZ> Please fix your commentary that documents functions with the EZ> above rules in mind. Will do. >> +static ptrdiff_t +count_run (merge_state *ms, Lisp_Object *lo, >> const Lisp_Object *hi, bool *descending) EZ> This line is too long, please break it in two. Yes. >> + eassume (lastofs == ofs); /* Then a[ofs-1] < key <= a[ofs]. */ >> + return ofs; +} EZ> Is this really eassume, or is eassert better here? See the comment by Mattias (this is outside my area of expertise). -- Andrew Cohen