From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Date: Thu, 28 Apr 2022 16:39:11 +0200 Message-ID: <871qxh6zf8.fsf@fastmail.fm> References: <87wnfa3cop.fsf@fastmail.fm> <87czh2qpkc.fsf@gmail.com> <86bkwly9qy.fsf@mail.linkov.net> <875ymt70jl.fsf@fastmail.fm> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17472"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.7.13; emacs 29.0.50 Cc: Juri Linkov , No Wayman , 55149-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 28 17:30:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nk661-0004H3-UN for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 17:30:23 +0200 Original-Received: from localhost ([::1]:46380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nk660-0004vp-IB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 11:30:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk5OB-00080B-0G for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 10:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55668) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nk5OA-0007Eb-M4 for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 10:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nk5OA-0003eg-KQ for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 10:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2022 14:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55149-done@debbugs.gnu.org id=D55149.165115704413950 (code D ref 55149); Thu, 28 Apr 2022 14:45:02 +0000 Original-Received: (at 55149-done) by debbugs.gnu.org; 28 Apr 2022 14:44:04 +0000 Original-Received: from localhost ([127.0.0.1]:49559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk5NE-0003cv-8I for submit@debbugs.gnu.org; Thu, 28 Apr 2022 10:44:04 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:50923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk5NC-0003cJ-Oh for 55149-done@debbugs.gnu.org; Thu, 28 Apr 2022 10:44:03 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 311D15C0042; Thu, 28 Apr 2022 10:43:57 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 28 Apr 2022 10:43:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651157037; x=1651243437; bh=phf+K3/IKA I2IsdxpUn1DuYXdKL5rv0RBnxCfOl9UJs=; b=ZUwWw6EVNcMgB1PGhvx1TkAKOZ lPU3m/cELFY4HPz/zp8F6cTQE0Q6bypH7+UEGFLXnBpI3S5U7wP7dufl9der5nMx EjSL/2cH35S2ziIzTwFkYEWXgYAY7KkAkgGKiHxsJG/BbRwui8L+gnqAYX2wnAXm ySwQJAyl8abX7PeD6hWKeUqW/zN2VczzaN9m5hQ/1mw5Sk7hhJu2F/DFc8kl6hee pt63JkwBF5PBddAJt+8o7lU1rPZarspM/5WFHmbBbfG3XIksY4F6OO66DmSECJeR XF3IX92NKSbj8u1uXaHfqAm/SBLtkiasPaSM/mBS3IDzfICXZfQS3pKdqiSA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651157037; x= 1651243437; bh=phf+K3/IKAI2IsdxpUn1DuYXdKL5rv0RBnxCfOl9UJs=; b=r 9iQgYxmcK7db57Edmm7tS/zdX9hAgwYZPCVgsWU9Vq9PuHy8p+JWcvJTbdWDKXUW Wa6TA4eUW32xSeZC9XnIoG8J/kECweIE8f0Y+hSDitVrKOlH0Zfnq/qUJaoNGq9Z xEN9p9HTtqtlgxHSZbK//BAanPkwnp9NIsAhpe9S2CqyWQ5zng0uDFtbssvM72oX ZeOV/Nhs7aPBCX44K8Gv/rfVJoaWOQeRcxVmibLYdN1XLacDvzt+ZG0GH3zjTzjY WAFwYlhxw7IM/KmBcrIp4bFkd87t5RjNh4xOBr2caUvAkdDv3jMi/T+60OVB4Kai efSWWv4YnrdPj1j+sQ1fQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejgdekudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehthhhorhhnsehfrghsthhmrghilhdrfhhmqeenucggtffrrghtth gvrhhnpeegffeihfejkeeuieeuheettefgheetgfffgeefudehjeeihffgheetkeethfdv gfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthh horhhnsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Apr 2022 10:43:56 -0400 (EDT) In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230886 Archived-At: Stefan Monnier writes: >> It is, thanks. Shouldn't you also adapt the add-function docstring? >> Oh, that's adapted automatically! Interesting approach. > > :-) > Actually, it was done to avoid copy&paste between the docstrings of > `add-function` and `advice-add`, but it's nice that it also avoids > duplication between the code and the doc and makes sure the doc is in > sync with the code. Indeed, and I think until recently advice-add didn't document HOW but just referred to add-function which was a bit annoying because usually one uses advice-add so does C-h f on that and then needs to TAB to add-function to get the docs on that. Would you mind adding this magic also to define-advice so that the HOW is described there as well? Bye, Tassilo