From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#55269: 29.0.50; Infinite recursion causes segmentation fault Date: Thu, 05 May 2022 12:55:38 +0200 Message-ID: <871qx8uu39.fsf@gnus.org> References: <87levge24r.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24321"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 55269@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 05 12:56:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmZ9h-00068Q-7h for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 May 2022 12:56:21 +0200 Original-Received: from localhost ([::1]:49120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmZ9g-0005Em-6x for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 May 2022 06:56:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmZ9O-0005Bf-L6 for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 06:56:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50579) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmZ9N-0005Mi-S3 for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 06:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nmZ9N-0001nE-QI for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 06:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 May 2022 10:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55269 X-GNU-PR-Package: emacs Original-Received: via spool by 55269-submit@debbugs.gnu.org id=B55269.16517481556871 (code B ref 55269); Thu, 05 May 2022 10:56:01 +0000 Original-Received: (at 55269) by debbugs.gnu.org; 5 May 2022 10:55:55 +0000 Original-Received: from localhost ([127.0.0.1]:44473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmZ9F-0001me-5b for submit@debbugs.gnu.org; Thu, 05 May 2022 06:55:55 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:52016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmZ9C-0001mN-L9 for 55269@debbugs.gnu.org; Thu, 05 May 2022 06:55:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qICJPt/ZMdtvv37I+cG3VINesmkMUXipmjT5pHO8zH0=; b=XgMcu1lnsV4W/vBTw4xl2JJ6Th UqO5dT4c66LRKLZLWpjjAESemA+0WT36RZTGBrf8FYPg1ZeKKEWptmEChWrXy4rpY7nP3ae3Ij9AN U7N4i7/AMrqrraZtBNpiRtzjDw7wQLsyje0uHsfbBz+F/vbeiMsIbdi1y98zT/zyAkLU=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmZ93-0000eY-C1; Thu, 05 May 2022 12:55:43 +0200 X-Now-Playing: Betty Davis's _Betty Davis_: "If I'm In Luck I Might Get Picked Up" In-Reply-To: <87levge24r.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 05 May 2022 09:53:56 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231412 Archived-At: Philip Kaludercic writes: > #12 0x0000000000686c42 in print_error_message (data=0x1fc6273, stream=0x7ffff4881285, context=0x0, caller=0x0) at print.c:957 > #13 0x0000000000686978 in Ferror_message_string (obj=0x1fc6273) at print.c:902 > #14 0x00000000006569f5 in skip_debugger (conditions=0x7ffff44534b3, data=0x1fc6273) at eval.c:1888 Hm... so the backtrace here seems to say that skip_debugger (which is supposed to be a predicate) is itself bugging out (i.e., the Ferror_message_string is erroring)? Hm... Oh, it's coming from here? void print_error_message (Lisp_Object data, Lisp_Object stream, const char *context, Lisp_Object caller) [...] if (!NILP (Ffboundp (Qsubstitute_command_keys))) errmsg = call1 (Qsubstitute_command_keys, errmsg); I think the fix here would be to ensure that that call never signals an error (i.e., slap a condition-case around that call1). I.e., could you try this patch and see whether it fixes the problem? diff --git a/src/print.c b/src/print.c index 54d8bdfa3d..5255ea3632 100644 --- a/src/print.c +++ b/src/print.c @@ -954,7 +954,11 @@ print_error_message (Lisp_Object data, Lisp_Object stream, const char *context, errmsg = Fget (errname, Qerror_message); /* During loadup 'substitute-command-keys' might not be available. */ if (!NILP (Ffboundp (Qsubstitute_command_keys))) - errmsg = call1 (Qsubstitute_command_keys, errmsg); + { + Lisp_Object subs = safe_call1 (Qsubstitute_command_keys, errmsg); + if (!NILP (subs)) + errmsg = subs; + } file_error = Fmemq (Qfile_error, error_conditions); } -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no