From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#55676: [PATCH] non-recursive Lisp reader Date: Sun, 29 May 2022 09:15:11 +0800 Message-ID: <871qwddtr4.fsf@yahoo.com> References: <83v8trm0b1.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19779"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 55676@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 29 03:16:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nv7XP-0004xo-On for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 May 2022 03:16:11 +0200 Original-Received: from localhost ([::1]:50006 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nv7XO-00049o-TM for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 May 2022 21:16:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nv7XG-00049g-Jy for bug-gnu-emacs@gnu.org; Sat, 28 May 2022 21:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45236) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nv7XG-0005K7-As for bug-gnu-emacs@gnu.org; Sat, 28 May 2022 21:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nv7XG-0005LI-29 for bug-gnu-emacs@gnu.org; Sat, 28 May 2022 21:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 May 2022 01:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55676-submit@debbugs.gnu.org id=B55676.165378692720491 (code B ref 55676); Sun, 29 May 2022 01:16:02 +0000 Original-Received: (at 55676) by debbugs.gnu.org; 29 May 2022 01:15:27 +0000 Original-Received: from localhost ([127.0.0.1]:39133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nv7Wg-0005KR-Tp for submit@debbugs.gnu.org; Sat, 28 May 2022 21:15:27 -0400 Original-Received: from sonic311-25.consmr.mail.ne1.yahoo.com ([66.163.188.206]:43689) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nv7Wd-0005KA-TZ for 55676@debbugs.gnu.org; Sat, 28 May 2022 21:15:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653786918; bh=e+6jQ36h67Pd8hOauigrojrm7R8sRF96+hRPY+llBz4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=a7pfB77+VTBC1QvoeH5rt4GUfsMmQVsdjM4yQ/EViMxMnE8HG/pmYSb007pWcmYoL35jnxQKixvH9/Z/LieY1mHTSJ3D7q3D0dGCknravQeRKVRA5P14XjDO8BpVy+8szkXPNSOmxFoCCopV/9npOJmxWgxTgDTd2PzGID2yl7vxd+4X/pAmQx/UVRpqwalL/tzRWVKtUEUl/8HeCuHrqouNySQUjOWN2NxfIWT0aGmdq7jEMPfVgw1au0fzeDpkbmmC4vHNjLaC6RG7WeAibq/A0WW87detWaPYPGmFZ6OZtec0XQOHDFS9kcg4bpQLZAqaJL1f8GvRuGUocBs6Mg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653786918; bh=l/CYbiiaFbJhKvh2+fkSkWoxIuSzSiKuO+QdWthK/y2=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=N4vktOB3/gRiwx+Y//Mu97K1LstDoZE+qwF4VeNmBSI1kaaA2GYSD6IRpUyTfFLNQHdMb/eXMbn6EOVnPGP7w9hYqorb6TzUi7AkKDwvO2AJ1zZ0ULL4jKwbSJ+VvYtAsb22ZAMIAnUzWuvEcZS1Z7Gm4m0rVpm1H+jxSIKOfswSUYV7eqbvDtkS5O5x+4W9v6uDtBIA6UBQKSqbw7dKEKCT7j6Uz6o79gOxLwEXRT1g+h0ghjFu9w87aOwbfCLjmTFvq2amJtrIXz2Y2Og4937L0xBdw55Nv5xT6GOgV+TW3ePKiCRPtr4BokOxas0966MguV4HRtXIKW8mg0GRQQ== X-YMail-OSG: 4BpzGxsVM1mqRijiCqfjgy1Z_dGQnv2D4vQ22jsrHaVS1q4ARfduhk6Xi1yvzTB 3yIvr8iQ3UcX8j6hDG_YLUFEBrY_Re7inzKvZ36rFX8LsqciOhBcje0qGWZ2soYKE8TjB5Dm2mHR MsJmTHm0iRRh2tR1o9HD70nGEwyyW.AdJH39VtWoUUu1HmOv_MJGMthzcUqqhrRTiEw0HVWLTXQL MiqWh5Z8E7oc3gXtYqXtpks9qZHCr6IiysxTUIMVhUJmDnxL9LpbnJ4OjLrPCT0StvRkPj4Zj89K .wIFJe9Oxv30B94o0cmZvgnJXQF3Lb9irtc1EgOqBshHSg14P_zSisMVAlEN7hiC9mnnAd6AO86o KEoabmp9MhsXfWjLaPe5gU2x9wgng54FPj87GYv26rj0bCIWY.6sEN7iYgYBEiyqkDaZdFWLVvFU NEiTgCu55QjX.__42gxUJF4i2PBpkT.tbMdQdQV5Wq4sdKzcT6lEB9OQLOE8io4LeSJSnK8OVTbC 4PkxPO1aWiMIJ8HIms.Q5jyXIdcqjpYvVcx.7hALplH5Q6HpeRossZb7isxSFVJHML6N5jNehW1s TOdsmn4npS7r.zsPI.2g8H6kYcMtsTt9yRkN72jqdzvoZ8WsjH57kJ_hQ1m2vQIJuTuG3tnzkJaC DPXiTMdV5WwtJM5r0YwDE4zNGbh8WqedHL5zJhfgUZf8DYkcQ7Tzb6EQTQzTa8vh_JB7uVEFfjsZ K7Xn2f0R50.1XKVhHSQwq2v6LoDt_Xb4SLePynYL0ihXne398yCmmHMBT6vZADdZkH0a5lwdrQPW 8o5BgfR96OMZlQtHLHe2Sy0cW.HrHA6KBlPU1tNVA8 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ne1.yahoo.com with HTTP; Sun, 29 May 2022 01:15:18 +0000 Original-Received: by hermes--canary-production-sg3-5f7658c994-rpd7c (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b1ca7d5a1eafea9d7db6236f5e040935; Sun, 29 May 2022 01:15:16 +0000 (UTC) In-Reply-To: <83v8trm0b1.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 27 May 2022 19:01:54 +0300") X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233285 Archived-At: Eli Zaretskii writes: > Thanks. One minor nit: you seem to have customized indentation in C > source files in a way that is different from our conventions. Please > reformat using our defaults (which use a mix of TABs and SPACEs). Another minor nit: >> + read_stack_push ((struct read_stack_entry){ >> + .type = RE_record, >> + .u.vector.elems = Qnil, >> + .u.vector.old_locate_syms = locate_syms, >> + }); >> + locate_syms = false; >> + goto read_obj; There should at least be a space between the cast and the opening brace of the compound literal, right? That applies to the rest of the printer code you installed lately. And I think using compound literals in `read_stack_push' (and `print_stack_push') is very ugly, but there's no rule against it. Thanks.