From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#12890: read-face-attribute, face-valid-attribute-values do not handle all :underline etc forms Date: Thu, 09 Jun 2022 16:08:40 +0200 Message-ID: <871qvy3p5j.fsf@gnus.org> References: <87zgjpinqn.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32066"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 12890@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 09 16:55:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzJZ4-0008BN-5a for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jun 2022 16:55:14 +0200 Original-Received: from localhost ([::1]:47876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzJZ2-0007Az-Oz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jun 2022 10:55:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzIqM-0003qg-KV for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 10:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53239) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nzIqM-0000uc-Bv for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 10:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nzIqM-0006oz-7B for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 10:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jun 2022 14:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12890 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 12890-submit@debbugs.gnu.org id=B12890.165478373326199 (code B ref 12890); Thu, 09 Jun 2022 14:09:02 +0000 Original-Received: (at 12890) by debbugs.gnu.org; 9 Jun 2022 14:08:53 +0000 Original-Received: from localhost ([127.0.0.1]:47136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzIqD-0006oV-9O for submit@debbugs.gnu.org; Thu, 09 Jun 2022 10:08:53 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:50118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzIqB-0006oE-9Z for 12890@debbugs.gnu.org; Thu, 09 Jun 2022 10:08:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=D+4a0nBc9DRLRmKF8QXyUPfiev3kSIOwsfhDZGRNPIg=; b=YzIaC2D+47DNB8UEG+N8tpIJK1 6zV6Kg5mhDNUsysCjUMRwl1LXsGf6vYglRzfm0BA3flActxpnpLr2rCbw+X71t0xwka64/1u+0S56 ynnrvbWcuqGEBmX4UsHchOeUcGq/unLaATqKPCrqhRBid45HKoTY7ZoBMHp1maEX9YCU=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzIq2-0000f3-7S; Thu, 09 Jun 2022 16:08:44 +0200 X-Now-Playing: Prince's _Sign 'O' the Times (7): Live in Utrecht II_: "Kiss (Live In Utrecht)" In-Reply-To: <87zgjpinqn.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 10 May 2022 14:19:28 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234084 Archived-At: Lars Ingebrigtsen writes: > I tried reproducing this in Emacs 29. It does indeed still need `C-q' > to enter the space, but after doing that, it seems to actually do the > rest correctly. > > I did: > > M-x set-face-underline RET > default RET > (:colorC-q "red") RET > > and the default face got a red underline. > > The `C-q' should be fixed, but do you also see the same behaviour for > the rest? Actually, I have no idea how to fix the `C-q' here. We do want completion because we want to complete over colour names, and (by default) `SPC' does completion. It might be nice to have the `SPC' in minibuffer-local-completion-map to be more DWIM -- don't try to complete if it's "obvious" that the user doesn't want completion. Myself, I've disabled completion on `SPC' because it's really annoying, but perhaps there is something we could do here? I.e., if there are no completions, then just insert a `SPC' and make that the new default binding for `SPC' here? Because I think that would make usability here a lot better. (It could say "No completions; inserting space".) Opinions? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no