From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#56366: 29.0.50; eww: Exclude radio links when suggesting URIs Date: Sun, 03 Jul 2022 18:53:08 +0530 Message-ID: <871qv2gwjn.fsf@gmail.com> References: <87mtdqlk5y.fsf@gmail.com> <87sfni9y0h.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30918"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56366@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 03 15:24:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o7zaA-0007up-PS for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Jul 2022 15:24:14 +0200 Original-Received: from localhost ([::1]:51634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o7za9-0002Qf-4n for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Jul 2022 09:24:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7za2-0002Q9-E3 for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2022 09:24:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49716) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o7zZy-0000Hd-A7 for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2022 09:24:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o7zZy-0007TP-4o for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2022 09:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jul 2022 13:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56366 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56366-submit@debbugs.gnu.org id=B56366.165685460928689 (code B ref 56366); Sun, 03 Jul 2022 13:24:02 +0000 Original-Received: (at 56366) by debbugs.gnu.org; 3 Jul 2022 13:23:29 +0000 Original-Received: from localhost ([127.0.0.1]:43613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7zZQ-0007Sd-Tv for submit@debbugs.gnu.org; Sun, 03 Jul 2022 09:23:29 -0400 Original-Received: from mail-pf1-f196.google.com ([209.85.210.196]:36706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7zZL-0007SM-IV for 56366@debbugs.gnu.org; Sun, 03 Jul 2022 09:23:27 -0400 Original-Received: by mail-pf1-f196.google.com with SMTP id f85so2878822pfa.3 for <56366@debbugs.gnu.org>; Sun, 03 Jul 2022 06:23:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=YTquP3QFQUnnN3SD60q+8H7ZwiLgcdcJ0xuts+b/zwQ=; b=iqTQyC7Y668uu4eIIvmyFgwDeThRPCepbhGB4X909/9HwkoLYm7TVAAkkaCB351FTc wLVyM7hVw6omXGxmZXn3CCm/4jF333f83bRFaunt4GsVIDLFYcSevbyeFqPqpwaT/nhQ xPgGktK+G0GPTQtGOMIQZkpHswoknR0GTrhiTGx6sXOcI6qCI++mB9vPvfTUVjuY5I4T YmSX6bXsXNRC2DFFp+Lhlm7cI3z16JKClqCbkGn2wJ8Cz9claHBgizKnI+/2SMUYJCse x3wfDv+N8RkekjBsTaSP4L2er0rkbYOJi87WAmkqXCdvZOoxGqeLOElDBigvMga56KVb 4ETw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=YTquP3QFQUnnN3SD60q+8H7ZwiLgcdcJ0xuts+b/zwQ=; b=FMhBmH710r9K+eDGLeap/pi8nsacH7ptpanRBqQcOazT0+NED9h/PtznEf6eq3aKK9 QVe4fgoM8F3jAJl5bSBSZouoTFcSoCZ7l08Uhd/0maQ6fxgYeoLV+yLFT9p6XUW8bZ3t aa1Xbe+LX3NvUEh8oRXLcNrbF5ZuxCepXPo+wVzDRG5Mn6YEtbYQK5yGRWLiaujS+wqS cISJSh56SPFVL+qvHgrOL+oXmnAF+ksMeYp/Sjoyeio+F/gSihDRA0cIKCMBzxvL6bEC Zr7ZfS8HZ0De2qq3FL6rxJA5Nt/MKie6stGWL440J9tYReTmXrqX+VVdTrapa+WHuMw4 Z8xQ== X-Gm-Message-State: AJIora+HIlBT4dI2wEAncOb56/ykMfJAW80itRw92I6kjaj8DtCj1LEV cdrvV4NKXlVU6Sa3nalClPM= X-Google-Smtp-Source: AGRyM1tqSqK13dgZbqKrkcENMsueioYAoiC+y0O+Z/NE4uvWgP6jqXTh9MEdnpT2cWxdQJYVT3kXfg== X-Received: by 2002:a63:2a92:0:b0:3fd:3da3:86ae with SMTP id q140-20020a632a92000000b003fd3da386aemr20716914pgq.284.1656854597698; Sun, 03 Jul 2022 06:23:17 -0700 (PDT) Original-Received: from localhost ([49.204.130.133]) by smtp.gmail.com with ESMTPSA id u62-20020a626041000000b005283f9e9b19sm3838058pfb.180.2022.07.03.06.23.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Jul 2022 06:23:16 -0700 (PDT) In-Reply-To: <87sfni9y0h.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 03 Jul 2022 14:33:18 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235996 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [=E0=AE=9E=E0=AE=BE=E0=AE=AF=E0=AE=BF=E0=AE=B1=E0=AF=81 =E0=AE=9C=E0=AF=82= =E0=AE=B2=E0=AF=88 03, 2022] Lars Ingebrigtsen wrote: > Visuwesh writes: > >> The attached patch fixes the error but maybe the right place to fix it >> is in eww-links-at-point? > > Yes, I think that would be better. How about the attached patch? --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Exclude-radio-buttons-when-suggesting-URI-in-eww.patch >From a3e3755efc251b10a3f95985e6021022845f71eb Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Sun, 3 Jul 2022 18:47:44 +0530 Subject: [PATCH] Exclude radio buttons when suggesting URI in eww * lisp/net/eww.el (eww-links-at-point): Exclude radio links. (bug#56366) --- lisp/net/eww.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 3c16942e7c..b4606d0221 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -932,7 +932,7 @@ eww-current-url (defun eww-links-at-point () "Return list of URIs, if any, linked at point." - (remq nil + (seq-filter #'stringp (list (get-text-property (point) 'shr-url) (get-text-property (point) 'image-url)))) -- 2.35.1 --=-=-=--