From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#56372: 29.0.50; [PATCH] Avoid BadMatch X11 error Date: Mon, 04 Jul 2022 12:19:23 +0200 Message-ID: <871qv19o44.fsf@gnus.org> References: <87czemtfv0.fsf@dick> <87r131fpmm.fsf@dick> <87r1319ojr.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18723"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Po Lu , 56372@debbugs.gnu.org To: dick Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 04 12:21:53 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8JDE-0004iH-1z for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Jul 2022 12:21:52 +0200 Original-Received: from localhost ([::1]:54554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8JDC-00085l-T1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Jul 2022 06:21:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8JBT-0005zw-ND for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2022 06:20:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52235) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8JBS-0003eR-OO for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2022 06:20:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o8JBS-0006Pn-FL for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2022 06:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jul 2022 10:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56372 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56372-submit@debbugs.gnu.org id=B56372.165692997624616 (code B ref 56372); Mon, 04 Jul 2022 10:20:02 +0000 Original-Received: (at 56372) by debbugs.gnu.org; 4 Jul 2022 10:19:36 +0000 Original-Received: from localhost ([127.0.0.1]:46132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8JB2-0006Oy-0A for submit@debbugs.gnu.org; Mon, 04 Jul 2022 06:19:36 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:59430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8JB0-0006Ol-Pp for 56372@debbugs.gnu.org; Mon, 04 Jul 2022 06:19:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+s++2gQx4rbVOccxIwoW5nq4MvKCkEeN4A7dAfPly6A=; b=QwS1i6x2132Pa492o3cDUYuZF/ EOgC17PvyYFsudlgcncAyBQ2THjF8A4TNQd3yC2ENKBV1fAH0ShkHMRD7K8prwlw/jjRSA37Vq1dH AlJcbbHuhE/CvVSOxvMDwG007MK0NycD3tyqZMH9/tzIv1i4IdK4hp50+UtlaXgA/smo=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8JAr-0006HZ-R3; Mon, 04 Jul 2022 12:19:28 +0200 In-Reply-To: <87r1319ojr.fsf@yahoo.com> (Po Lu via's message of "Mon, 04 Jul 2022 18:10:00 +0800") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEXEaDflmFTJxsRW dKVaa4////95E3pLAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YHBAoPKI4xKJsAAAGdSURBVDjLnZPr dcMgDIXhnAyAcQcIkhcwMEBPYP+ZeiVhGzfpnyqOE/NZ6HVxzi1qDubx1T+fTEBMRG/rMCIq5QPA an4HzmNdbDzJDgGXc4+u1u5g8Y9eW++lzx7CDofZA1X44EtpEqGW82U1v5bDRt1LXJaEHy69dly1 DRAGZuzSDAjxXjPS2s6tbsZ/AWSECLWe6R7WW2tVwv8CUl0Vr9avrXQOZYohjbMxBL9Q4pyp5Fx4 gBiXFHxMaQWA7evsgZHunIlL5rKaBLCLvMBzDDcUotn2VrXnkq4/gXfIsh4MM7Aow6Nfg1JgervH wEIkei5TD9GZooIh6i8CWaEn1isLiAKIUgAgYqmPM5uDGgo0gBppBmkA+QiIdLr4EduymoB7pLjq mKSOG9gZoFjlspQHcJnWquqFB00e/qgbEj3Aph4qhtZUcJG2l4CN7HRU7eQVvNt5ZEi0WVaexAG3 5EwoeXR3agkeAvEubWRr+gVwGmIhqMG6i822px2tAMnzGJS6bDpgH2xetdkEN4q3s74dov66BPEt t+D+YT/qaHW8auKAUgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wNy0wNFQxMDoxNTo0MCswMDow MIIhk7YAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDctMDRUMTA6MTU6NDArMDA6MDDzfCsKAAAA AElFTkSuQmCC X-Now-Playing: Joe Jackson's _Big World_: "Shanghai Sky" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236040 Archived-At: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > That piece of code is already inside "if (dpyinfo)" Indeed. And aren't we testing for dpyinfo twice already in that code? Unless I'm misreading, it's: /* If DPYINFO is null, this means we didn't open the display in the first place, so don't try to close it. */ if (dpyinfo) { ... no code here that sets dpyinfo ... [...] if (dpyinfo->terminal == terminal_list && !terminal_list->next_terminal) { fprintf (stderr, "%s\n", error_msg); if (!ioerror && dpyinfo) { That && dpyinfo seems redundant? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no