bug#56491: [PATCH] Don't create file rmail-loaddefs.el

bug#56491: [PATCH] Don't create file rmail-loaddefs.el

[Stefan Kangas]

[-- Attachment #1: Type: text/plain, Size: 146 bytes --]

Severity: wishlist

It seems like the rmail-loaddefs.el file is not really used for
anything?  Maybe we could just remove it, as in the attached.

[-- Attachment #2: 0001-Don-t-create-unused-file-rmail-loaddefs.el.patch --]
[-- Type: text/x-diff, Size: 1361 bytes --]

From 0918c41a2f93368ea3308addbafea51f5ba08cb9 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefan@marxist.se>
Date: Mon, 11 Jul 2022 01:58:56 +0200
Subject: [PATCH] Don't create unused file rmail-loaddefs.el

* lisp/mail/undigest.el: Remove 'generated-autoload-file' local
variable.
(unforward-rmail-message, undigestify-rmail-message): Don't
autoload.
---
 lisp/mail/undigest.el | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/lisp/mail/undigest.el b/lisp/mail/undigest.el
index c6d29bc4e7..2321706f6c 100644
--- a/lisp/mail/undigest.el
+++ b/lisp/mail/undigest.el
@@ -201,7 +201,6 @@ rmail-digest-parse-rfc934
 
 (declare-function rmail-update-summary "rmailsum" (&rest ignore))
 
-;;;###autoload
 (defun undigestify-rmail-message ()
   "Break up a digest message into its constituent messages.
 Leaves original message, deleted, before the undigestified messages."
@@ -277,7 +276,6 @@ undigestify-rmail-message
 	  (set-buffer buff)
 	  (rmail-show-message current))))))
 \f
-;;;###autoload
 (defun unforward-rmail-message ()
   "Extract a forwarded message from the containing message.
 This puts the forwarded message into a separate rmail message following
@@ -378,8 +376,4 @@ unforward-rmail-message
 
 (provide 'undigest)
 
-;; Local Variables:
-;; generated-autoload-file: "rmail-loaddefs.el"
-;; End:
-
 ;;; undigest.el ends here
-- 
2.30.2

bug#56491: [PATCH] Don't create file rmail-loaddefs.el

[Lars Ingebrigtsen]

Stefan Kangas <stefan@marxist.se> writes:

> It seems like the rmail-loaddefs.el file is not really used for
> anything?  Maybe we could just remove it, as in the attached.

The two commands in rmail-loaddefs.el/undigest.el are only used from
rmail buffers, I guess?  But just removing the autoload cookies would be
wrong (because then people can't say `M-x unforward-rmail-message') --
perhaps rmail.el should autoload the two commands.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#56491: [PATCH] Don't create file rmail-loaddefs.el

[Stefan Kangas]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> The two commands in rmail-loaddefs.el/undigest.el are only used from
> rmail buffers, I guess?  But just removing the autoload cookies would be
> wrong (because then people can't say `M-x unforward-rmail-message') --
> perhaps rmail.el should autoload the two commands.

This file is not required from anywhere, so I don't see what changes if
we remove the autoload cookies.  What am I missing?

bug#56491: [PATCH] Don't create file rmail-loaddefs.el

[Lars Ingebrigtsen]

Stefan Kangas <stefan@marxist.se> writes:

> This file is not required from anywhere, so I don't see what changes if
> we remove the autoload cookies.  What am I missing?

Oh, I missed that.  Then I guess this is just a file that was missed
when the rest of the rmail-loaddefs things were removed -- so the
correct fix here is to just remove

;; Local Variables:
;; generated-autoload-file: "rmail-loaddefs.el"
;; End:

but leave the ;;;###autoload cookies as is.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#56491: [PATCH] Don't create file rmail-loaddefs.el

[Stefan Kangas]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> the correct fix here is to just remove
>
> ;; Local Variables:
> ;; generated-autoload-file: "rmail-loaddefs.el"
> ;; End:
>
> but leave the ;;;###autoload cookies as is.

OK, makes sense.  Now done on master (commit d9732425a6).