From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57216: 29.0.50; [PATCH] Provide ERT explainers for Eshell test functions Date: Mon, 15 Aug 2022 09:01:52 +0200 Message-ID: <871qtic7mn.fsf@gnus.org> References: <75bf09ff-fcd3-85a6-cfe5-b300e46ba41c@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34981"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: eliz@gnu.org, 57216@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 15 09:03:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNU88-0008ud-Ix for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Aug 2022 09:03:20 +0200 Original-Received: from localhost ([::1]:53880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNU87-0001Ty-Er for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Aug 2022 03:03:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNU7q-0001T1-H7 for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 03:03:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50740) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oNU7q-0005Hx-0Z for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 03:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oNU7p-0005KQ-Qo for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 03:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Aug 2022 07:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57216 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57216-submit@debbugs.gnu.org id=B57216.166054692420400 (code B ref 57216); Mon, 15 Aug 2022 07:03:01 +0000 Original-Received: (at 57216) by debbugs.gnu.org; 15 Aug 2022 07:02:04 +0000 Original-Received: from localhost ([127.0.0.1]:40486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNU6u-0005Iy-0t for submit@debbugs.gnu.org; Mon, 15 Aug 2022 03:02:04 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNU6s-0005IQ-IV for 57216@debbugs.gnu.org; Mon, 15 Aug 2022 03:02:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4fpugi9I7ppxXrXxS98D9wQYZTqaubHjaC6Y2WKdhaE=; b=bi/9zIUwNSFdMaaEHYu4i0UAgN TWPK9nkbdj8r2HO3glK24mw0GpFVXSthwqYPveFVwiKlmPbCnfyV0ebJjsWuwwTl2jGs2Rtyt3qSJ BgKG01lnLcknnqEE6weRdKW4ZQICaFHAV9L+LhCAQ7br2qvBJe4Di3rhEHyMmo0PZl8M=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNU6k-0004kL-7u; Mon, 15 Aug 2022 09:01:56 +0200 In-Reply-To: <75bf09ff-fcd3-85a6-cfe5-b300e46ba41c@gmail.com> (Jim Porter's message of "Sun, 14 Aug 2022 14:20:25 -0700") X-Now-Playing: Aksak Maboul's _Un Peu De L'Ame Des Bandits_: "Palmiers en Pots" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239742 Archived-At: Jim Porter writes: > It can be difficult to diagnose test failures in the Eshell ERT test > suite, since it doesn't print useful details like the command that was > executed. See bug#57129 for example. I'm generally not in favour of making ert tests less trivial (because that makes dealing with them less easy if you're not familiar with the specific harness), but in this case, it makes sense, I think. > Most of the first two patches are purely-mechanical changes to update > function calls. The diffs ended up being pretty big, but I think it > improves matters. Let me know if I should do it differently > (especially for the commit message; I didn't see much benefit to > listing *every* test function I touched, but maybe I should do that?) Looks OK to me -- we don't really follow the ChangeLog conventions for the tests much.