From: Michael Albinus <michael.albinus@gmx.de>
To: Javier Olaechea <pirata@gmail.com>
Cc: Philip Kaludercic <philipk@posteo.net>, 55199-done@debbugs.gnu.org
Subject: bug#55199: 28.1; rcirc auth-source integration doesn't handle port being a number
Date: Mon, 22 Aug 2022 17:05:40 +0200 [thread overview]
Message-ID: <871qt8gvy3.fsf@gmx.de> (raw)
In-Reply-To: <CAFVS=zASaZy=N7dXzc5nOvnwMJpqKE_gmf8XYBh4wNzqdaWmDA@mail.gmail.com> (Javier Olaechea's message of "Sun, 21 Aug 2022 14:02:21 -0500")
Version: 29.1
Javier Olaechea <pirata@gmail.com> writes:
> Hi Michael,
Hi Javier,
> I can confirm patch fixes the issue. I don't think we need to change
> the create function. The issue is that a valid spec, meant for another
> backend, results in an error when searching the secrets backend.
Thanks for the feedback. And yes, the create function in auth-source.el is
rarely used, so we might live with the current implementation.
> An alternative solution would be for auth-source-secrets-search to
> return an empty list (no secrets found iirc) when the spec contains a
> non-string value.
Perhaps. But since the patch is simple, and it is consistent with the
behavior of the plstore backend, I've applied it. I've also updated the
auth-source manual, explaining it:
--8<---------------cut here---------------start------------->8---
Attribute values in the auth-source spec, which are not strings (like
port numbers), are stringified prior calling the ‘secrets.el’ functions.
--8<---------------cut here---------------end--------------->8---
Closing the bug. Change will appear with Emacs 29.
Best regards, Michael.
prev parent reply other threads:[~2022-08-22 15:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-30 19:15 bug#55199: 28.1; rcirc auth-source integration doesn't handle port being a number Javier Olaechea
2022-05-18 23:26 ` Philip Kaludercic
2022-06-11 3:46 ` Javier Olaechea
2022-08-21 6:00 ` Javier Olaechea
2022-08-21 8:02 ` Michael Albinus
2022-08-21 19:02 ` Javier Olaechea
2022-08-22 15:05 ` Michael Albinus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qt8gvy3.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=55199-done@debbugs.gnu.org \
--cc=philipk@posteo.net \
--cc=pirata@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.