From: Tassilo Horn <tsdh@gnu.org>
To: Arash Esbati <arash@gnu.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [elpa] externals/auctex cb0a1e6be1 72/77: Improve function calls to retrieve key=vals in style hooks
Date: Sat, 27 Aug 2022 09:25:44 +0200 [thread overview]
Message-ID: <871qt2i158.fsf@gnu.org> (raw)
In-Reply-To: <86y1vaqhkh.fsf@gnu.org>
Arash Esbati <arash@gnu.org> writes:
> So take fancyvrb.el for example which has a variable
> `LaTeX-fancyvrb-key-val-options'[1] (which can declared by defconst now)
> and a function `LaTeX-fancyvrb-key-val-options'[2] which returns the
> current keyvals.
>
> So my last requirement was to be able to do something like this:
>
> (TeX-add-style-hook
> "foo"
> (lambda ()
> (TeX-add-symbols
> '("bar" (TeX-arg-key-val
> (append (func1-returning-keyval-alist)
> (func2-returning-keyval-alist)))))))
>
> And this didn't work with the (apply head tail) version. Any other
> suggestion how to implement this in `TeX-arg-key-val' is highly
> welcome.
So what's wrong with this one?
(TeX-add-style-hook
"foo"
(lambda ()
(TeX-add-symbols
`("bar" (TeX-arg-key-val
,(lambda ()
(append (func1-returning-keyval-alist)
(func2-returning-keyval-alist))))))))
That's again caught by the functionp case and can simply be funcalled.
I'd rather prefer to keep the DSL simple, e.g., TeX-arg-key-val
arguments can either be a literal alist, a function of no args
delivering an alist, or a symbol denoting an alist variable (checked in
that order). That is, I wouldn't even distinguish functions from
variables syntactically but prefer functions in general, e.g.,
(TeX-arg-key-val (LaTeX-enumitem-key-val-options))
would become
(TeX-arg-key-val LaTeX-enumitem-key-val-options)
where LaTeX-enumitem-key-val-options is funcalled and takes precedence
of the variable of the same name.
Sorry, I know we had a discussion back then where I haven't been
explicit enough or haven't had an informed opinion yet. :-(
Bye,
Tassilo
next prev parent reply other threads:[~2022-08-27 7:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166154439039.10036.933483657788018296@vcs2.savannah.gnu.org>
[not found] ` <20220826200639.2B668C00889@vcs2.savannah.gnu.org>
2022-08-26 20:28 ` [elpa] externals/auctex cb0a1e6be1 72/77: Improve function calls to retrieve key=vals in style hooks Stefan Monnier
2022-08-26 20:47 ` Tassilo Horn
2022-08-26 21:15 ` Stefan Monnier
2022-08-26 21:17 ` Tassilo Horn
2022-08-27 7:19 ` Arash Esbati
2022-08-27 7:25 ` Tassilo Horn [this message]
2022-08-29 19:34 ` Arash Esbati
2022-08-30 5:33 ` TeX-arg-key-val syntax and let go of eval (was: [elpa] externals/auctex cb0a1e6be1 72/77: Improve function calls to retrieve key=vals in style hooks) Tassilo Horn
2022-08-26 22:51 ` [elpa] externals/auctex cb0a1e6be1 72/77: Improve function calls to retrieve key=vals in style hooks Emanuel Berg
2022-08-28 4:04 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qt2i158.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=arash@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.