From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Mon, 19 Sep 2022 09:58:13 +0200 Message-ID: <871qs7ztgq.fsf@gnus.org> References: <875yhzmz25.fsf@posteo.net> <875yhzmj50.fsf@gnus.org> <875yhzl3a1.fsf@posteo.net> <87fsh25bso.fsf@gnus.org> <871qsil3jm.fsf@posteo.net> <87fsgygo7c.fsf@gnus.org> <87a676jfx2.fsf@posteo.net> <87bkrmdt46.fsf@gnus.org> <8735cxpx2r.fsf@posteo.net> <87k066yyn0.fsf@posteo.net> <877d269kgv.fsf@gnus.org> <87bkriyqci.fsf@posteo.net> <874jxa6kyj.fsf@gnus.org> <87o7vdg97w.fsf@posteo.net> <831qs926np.fsf@gnu.org> <871qs9fzz5.fsf@posteo.net> <83h715yxz2.fsf@gnu.org> <87h715dnut.fsf@posteo.net> <87edw955ls.fsf@gnus.org> <8735coewsk.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29188"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , 57639@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 19 10:16:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaBwu-0007Mv-HR for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 10:16:16 +0200 Original-Received: from localhost ([::1]:42166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaBwt-0003qz-C3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 04:16:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaBgE-0001vN-JR for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 03:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53136) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oaBgE-0005uX-9x for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 03:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oaBgE-0007fC-5o for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 03:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Sep 2022 07:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.166357430729415 (code B ref 57639); Mon, 19 Sep 2022 07:59:02 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 19 Sep 2022 07:58:27 +0000 Original-Received: from localhost ([127.0.0.1]:52214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaBff-0007eN-GG for submit@debbugs.gnu.org; Mon, 19 Sep 2022 03:58:27 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:47354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaBfd-0007eA-L8 for 57639@debbugs.gnu.org; Mon, 19 Sep 2022 03:58:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZXAKqE/RPGaUVfCdzkaoVFOLOMHXt/gUaoKr8BkDkx0=; b=UioqkDfenrLraFtUDXkzDjJI8p vUfoI9EZFvC8k55wkkYCcuADInZqoeq/Hk7/KwGw9oPkplC0q+4+yJA59bGYBbvVmWQnJfIKbjZny o4tfmtXjYUlMPQb9Bz7xFjIabjNdNCK0Rxy98PG0bDj33OjS2rrM+F3adFMXrElgk5+Q=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaBfU-0006va-FO; Mon, 19 Sep 2022 09:58:18 +0200 In-Reply-To: <8735coewsk.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 18 Sep 2022 11:39:39 +0000") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEXu7u3Y0NfGoK/P NkTdV2e3rsuZeYdLOkUTBw9kV14nEhlLJio2IiosGiP////Zf5E1AAAAAWJLR0QOb70wTwAAAAd0 SU1FB+YJEwcsIERlldwAAAGOSURBVDjLrdK9TsJQFAfwYuJOE0kMkcHi4iq+AKUvwEA0xBV4Az4S WeV4oaNCBRcXLhe7Yk2ZhVSZ+xH6LrYF1J7WxMH/eH+959xzeznuKzz330nyPJ8Mr2Rzu5xtlxKC kD+RxKzkJ3cuSTvYE0VRkIRsTioUQju2OZB2yf/xPIlU9ZjfJAz7NbgpBSkiOJ0+xUPfaFXiIKUs G9/wY/pU8aESX6o0qsSXKtUqA9tbr96F4aLfrw5pS2nDbRjKzKR2GwAIgittDJN5DJTpmKrUA1zq EkyHAIlC2V3QWDj6WPt1SBRc1weg0R0r73tCZQwZdwlkOKXgIDhULZnN3y2QEaQpdHVdN2J6LLtz XVcdhnuoBmGMMAtDmvjDgRPZkWZTzYOXXhTWj8DgTXUjwEYe2E0jCg2v1HNzjU/F4BpkCosOBkJW /t3OiMmF3lWGBceFWdPGpZh35xQmA9wcZOIPYtcioAalVKWDwSLBr62bGOgGXhuoOQSPCmCi/ALd ezygBsw3gqGnseBhkTrHfQIpVOojvKi+iAAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wOS0xOVQw Nzo0NDozMiswMDowMHsDNFgAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDktMTlUMDc6NDQ6MzIr MDA6MDAKXozkAAAAAElFTkSuQmCC X-Now-Playing: Anne Clark's _Hopeless Cases_: "Cane Hill" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243041 Archived-At: Philip Kaludercic writes: > One last additional, I've added a property to all the themes indicating > that they are colour schemes. This would make it easier to toggle > between dark and light modes if multiple themes are enabled of which > only one is a colour theme: Makes sense. One thing that occurred to me now that I didn't think of before is: > (deftheme adwaita > "Face colors similar to the default theme of Gnome 3 (Adwaita). > The colors are chosen to match Adwaita window decorations and the > -default look of the Gnome 3 desktop.") > +default look of the Gnome 3 desktop." > + :background-mode 'light > + :kind 'color-scheme) Is this backwards compatible, and is that something we need to care about? I know that some (many?) themes are also distributed outside of Emacs, and should work under a range of Emacs versions. I don't think extending `deftheme' in this way would be backwards compatible, though, even if it makes sense from a language design point of view.