From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master cd88f6de4b: Adjust zero-width grapheme clusters so they are displayed (Bug#50951) Date: Tue, 27 Sep 2022 10:47:25 +0800 Message-ID: <871qrxa5z6.fsf@yahoo.com> References: <166423829576.7468.2672204708444997712@vcs2.savannah.gnu.org> <20220927002456.D4AC2C11D7D@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6646"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: YAMAMOTO Mitsuharu To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 27 04:49:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1od0f3-0001Jg-O5 for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Sep 2022 04:49:29 +0200 Original-Received: from localhost ([::1]:33296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1od0f2-0000XO-JL for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Sep 2022 22:49:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1od0dI-0007rF-Q9 for emacs-devel@gnu.org; Mon, 26 Sep 2022 22:47:41 -0400 Original-Received: from sonic304-22.consmr.mail.ne1.yahoo.com ([66.163.191.148]:43083) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1od0dG-0005j9-HC for emacs-devel@gnu.org; Mon, 26 Sep 2022 22:47:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1664246854; bh=rQKor5w/Qsef6VBOKWQ/xyqtHKNQGj4SpVaADciCYlc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=agNqsJVY6Njezq3axASgOWKT4tyyEQyyXOuVtzHcU/MHdeYDclvSL/gZs8R95+BLVRYiE1zvE7QBRb8kMNRUknqMtla0fm9Wi28rkuJNX6yT9WH892R5mnBX50JnuA7vlj52skFJ8T2iAa0BfGX89fZd56J4BOaj7PJrwQ4HG5ZFrbkTq78SWbT0VdWWU3UT+c6CWnqZZongHY3nu5WP+UWgVG6e07sY1ShRWI9LGcWmBPw6i4FnpzaVHieCN801e7bAlAxIa+eror9V/1CswtSBY7qAwe8VvM0frb3sHMzvMW9n8Zd7fmcoyM/Y6YAQxGw4wvxhazcJ8wTt1wyLLw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1664246854; bh=Py3XThmtjF0Muu9i8irk/xqWxz7/5hP7XY+PA1M7H9j=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=CgloHSFoRXN4VsQWYrNJNfSj4hn2jexdZp4+1XXciNbL/6SsM0ewYgoU+AnS3rYqt/Of+0ds+z6HJfnyok7DcapoJ1Gr6pVPW5bciHppEIJb11gF/Gj70fR8Qee7C1Sd5M4w8dszBPsoRi6b8BRBUBAW6ks1eDisS0duPdEkL4XY9w7x3xwYIDLlxp+0aGBKnCfoJnscd69FHsTMR2mPixhyOMafmg7m1MLJVuXDotIpChS+4JMUmHyPI+sFpX83DiJXny4ndHpvpTvdl+RAbBRGuhk5+s+SQhr0g5q0ESyKgsTlS3ZHti/HOuf3FZhxoziEguLU/vHtnTQme7netw== X-YMail-OSG: QJcIvJ8VM1miXCTyvmOmLtNHQWt7AuG1L691JyEFBFf.fBo0wVcgCZxRP3kUjm_ TGIvaMiG_q1_jMPI6xQhL6xny5qRnA.dZ8qNZU8jlORQCryIKjRQIn0t2QplNzmwzWT43zhZowl1 vumm4ZIeYnd0P4kLtHvsyx1glw6VyvmVW33xmC3VhbROdvO5uxbxs3XhD97hCKNWxCns5gSMTgMb KLZNdxHSWBIykVVDT4F44WJTpGLtArK4dZ4ByvrJ3Px7zJ6Ntb0M4vrkvXi7.OAQIBZc3pPRJa7M eLfvp_5G.RdYLbIS7ldyArZxLYn9pvofoyLyS7BHfOr9gQbbxUTOuSXJzlhu3UzWmzi0Eib75EmA 5sN0.mdo_sMzzWsTkGY5Jfh8zEicx61_2LoAV5E4tz4C4TlesL62EmQ5rwY0JhZx.fo_hL6FJIhf SlD1AouXPlGvskZI5wuBVM39K4WYlMmbxaZPraHVUVoH7F..vchg28.Zjmc7BEYktNZSEyg8d4qV NvY_ayLhtI3RazbOzGCS4Qn.7OaK1iEf98X_FP75KKICjZHmral1Fu_I6NYfA1SelI7RW9dyNCNm xVL_Z3S1dZMBzzUpQ31kDOPYGWWFSBOQvuOn5_VoN9.eU8n25D4al0NutrcgybyuY899f546.pR0 hfJnQSWZvdpbuzoO4m0YhI3MJ30xRpgBfS6nh7bI8HnozjvA4NcyuzOqoliHdDQh8s1tJKirYSyG wy79lJz2hObog1CHWmt4smKJDOtC1ZrCtWRIT7XdbGK_DgmSHUxPcfx5LUfiZ.9GbyNvNVkdS258 9VRcwqLExXemFDplhZlrHj9vM5i5Rn385GW8byEjkN X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Tue, 27 Sep 2022 02:47:34 +0000 Original-Received: by hermes--production-sg3-dfffdfbd4-cpz6p (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 17912693a47cca708a479f2e8595671f; Tue, 27 Sep 2022 02:47:32 +0000 (UTC) In-Reply-To: <20220927002456.D4AC2C11D7D@vcs2.savannah.gnu.org> (YAMAMOTO Mitsuharu's message of "Mon, 26 Sep 2022 20:24:55 -0400 (EDT)") X-Mailer: WebService/1.1.20702 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.191.148; envelope-from=luangruo@yahoo.com; helo=sonic304-22.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296311 Archived-At: YAMAMOTO Mitsuharu writes: > branch: master > commit cd88f6de4be1f8eba1db038b371d769f584be53b > Author: YAMAMOTO Mitsuharu > Commit: YAMAMOTO Mitsuharu > > Adjust zero-width grapheme clusters so they are displayed (Bug#50951) >=20=20=20=20=20 > * src/composite.c (composition_gstring_adjust_zero_width): New functi= on. > * src/composite.h: Declare it. > * src/font.c (Ffont_shape_gstring): Use it before putting gstring to = cache. This gives: In file included from composite.c:29: In function =E2=80=98AREF=E2=80=99, inlined from =E2=80=98composition_gstring_adjust_zero_width=E2=80=99 at= composite.c:839:11: lisp.h:1941:35: warning: =E2=80=98glyph=E2=80=99 may be used uninitialized = [-Wmaybe-uninitialized] 1941 | return XVECTOR (array)->contents[idx]; | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~ composite.c: In function =E2=80=98composition_gstring_adjust_zero_width=E2= =80=99: composite.c:816:19: note: =E2=80=98glyph=E2=80=99 was declared here 816 | Lisp_Object glyph; | ^~~~~