From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#58447: [PATCH] In project-find-file, add absolute file name to history Date: Wed, 26 Oct 2022 11:04:44 +0200 Message-ID: <871qqvj6qb.fsf@gmail.com> References: <8735budxiz.fsf@gmail.com> <83a662dvgo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36585"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58447@debbugs.gnu.org, Dmitry Gutov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 26 11:05:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oncLd-0009JB-Da for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Oct 2022 11:05:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oncLQ-00058N-NY; Wed, 26 Oct 2022 05:05:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oncLO-0004wk-7p for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 05:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oncLN-0001jJ-VV for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 05:05:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oncLN-0006LX-Ql for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 05:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Oct 2022 09:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58447 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58447-submit@debbugs.gnu.org id=B58447.166677510024383 (code B ref 58447); Wed, 26 Oct 2022 09:05:01 +0000 Original-Received: (at 58447) by debbugs.gnu.org; 26 Oct 2022 09:05:00 +0000 Original-Received: from localhost ([127.0.0.1]:53373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oncLL-0006LD-W5 for submit@debbugs.gnu.org; Wed, 26 Oct 2022 05:05:00 -0400 Original-Received: from mail-ed1-f52.google.com ([209.85.208.52]:37843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oncLG-0006Kw-PC for 58447@debbugs.gnu.org; Wed, 26 Oct 2022 05:04:58 -0400 Original-Received: by mail-ed1-f52.google.com with SMTP id t15so5695869edd.4 for <58447@debbugs.gnu.org>; Wed, 26 Oct 2022 02:04:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=oVPdFHQ20R42xoboDySCoc4orzfRCRKEOSjF5neiGh8=; b=KNYMmYMeAanRig2Oq4hPBRMBfXzFnLdlbfWzTuI3a9I0vtNF1zRIfXReAwfB0cvH3j 2f7G8fCq2XiOhISGaneXzMWbHBZmShgv7K7Ut1K3TvjAejzNOeLfCez0/IZJY23jYBid z1z9MdSagAlikoIqOzCBFkIRtb1oyDofUPQgFfX2aNS2E+uPuTFgJtbuU2EDGykSYHqR gChgBEJ2LAvi7mc4zvDHvYOj5bKqlLmXrR6f5we15ZreRMlRldo6gfRqYNdzwUgT7iDT +G2b42SOcKfjt3lyQfgGeYZp4y+/ynvGR/2K7cYbliT+2Q/oCXXDdaqJBOiRwHcY95/R YjJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oVPdFHQ20R42xoboDySCoc4orzfRCRKEOSjF5neiGh8=; b=BKHg9Fvz1yVC/AdHV0QAGQxmqXQWP/M3DGLhCGikmy3nxWK15+qHhmr+LFBItxp8Hp DD90I6M/cCoHXNFGfyqu/DC/K7Vgrb1OsEcSODUIwk2zZoa3XdlMtQDFebOfU/HI+dbq PuE6S0pykzn2/Zv7VEoAYUKUwppOYTERT2sO/A8nS/xyl/ROiRtGj0QNncoLhF9BBcce pB9bSpoNhtCQvnAxTR9I//1uGjHATzWDv3CB0G7psKFT65nG/mGfp4BGLziESSj/iLhu vbcOMd8LTUyfQmw76wH0mJChvO9ncI3wZ7OboHpGmgKmTr7yNvqkoiyQ/ugB2g5dBn5Y Gz/Q== X-Gm-Message-State: ACrzQf2OkfrGaJmWjn2yxZ+Z1cWvMy5uRRnt7GvtNF511NB/1RQyfOZf g7vymL21PVjnsFBHs8mmGAM= X-Google-Smtp-Source: AMsMyM7WeViYGgiz85BZ7UhE45VYiN6oncgQ8i4zbt281/LSsS+OKsH2ZK/vfsJCi2VHEcPS8v9ycg== X-Received: by 2002:a05:6402:5191:b0:45c:dea0:2c7 with SMTP id q17-20020a056402519100b0045cdea002c7mr39071462edd.239.1666775087724; Wed, 26 Oct 2022 02:04:47 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::89aa]) by smtp.gmail.com with ESMTPSA id y18-20020a17090668d200b0079e11b8e891sm2660424ejr.125.2022.10.26.02.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 02:04:46 -0700 (PDT) In-Reply-To: <83a662dvgo.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 11 Oct 2022 22:13:59 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246211 Archived-At: I'm copying Dmitry. On Tue, 11 Oct 2022 at 22:13, Eli Zaretskii wrote: >> From: Augusto Stoffel >> Date: Tue, 11 Oct 2022 20:29:24 +0200 >> >> `project-find-file' and related commands share their history with more >> general commands like `find-file', so they should add the absolute file >> name to history. Currently, file names relative to the project root are >> added. The attached patch fixes this. > > Shouldn't project.el have its separate history of file names, I'm not sure that's useful, but then the history items should be absolute file names anyway. > perhaps even a project-specific history? This might make sense.