From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#58799: Make winner key sequences repeatable in repeat-mode Date: Fri, 28 Oct 2022 11:36:15 +0200 Message-ID: <871qqss31s.fsf@gmail.com> References: <87y1t2zl1s.fsf@cassou.me> <87fsf9vdr6.fsf@gmail.com> <87v8o5ts06.fsf@gmail.com> <87lep1tmie.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5857"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Damien Cassou , Lars Ingebrigtsen , 58799@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 28 11:37:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooLnq-0001K6-FW for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Oct 2022 11:37:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooLnb-0000xn-Vf; Fri, 28 Oct 2022 05:37:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooLnS-0000xM-Mh for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 05:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ooLnS-0001An-GF for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 05:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ooLnS-0005Wt-7i for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 05:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Oct 2022 09:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58799-submit@debbugs.gnu.org id=B58799.166694978821208 (code B ref 58799); Fri, 28 Oct 2022 09:37:02 +0000 Original-Received: (at 58799) by debbugs.gnu.org; 28 Oct 2022 09:36:28 +0000 Original-Received: from localhost ([127.0.0.1]:60440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooLmt-0005W0-Qj for submit@debbugs.gnu.org; Fri, 28 Oct 2022 05:36:28 -0400 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:56126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooLmq-0005Vl-Tg for 58799@debbugs.gnu.org; Fri, 28 Oct 2022 05:36:25 -0400 Original-Received: by mail-wm1-f52.google.com with SMTP id t4so2783807wmj.5 for <58799@debbugs.gnu.org>; Fri, 28 Oct 2022 02:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=SZ725RMwJ8x3udrdBNPPIdNjigVVHtK7obFTohvtZcA=; b=maYeKDGIVGTf23Vm237gjIXhLIB90td9YOT/7OQuTz8gsrIp5zTpMIRxdWCTZbx5w1 3FZvEzWO6N6TwiERLg6phBm/CrgRI0788hrQM/RwpmwomoOJmSnGescewsNs/R+qUtw7 fpm5ziqnkPeOUg1YNMC8DyYcLb9UFxfNWz1GFhimFm/gf+s3Yl8KJAvZDWF4S3ZUbamb PCgG0fWwwSS3bXzmxs7yCsOLYqO5tOuSHo0RG3MqKeDqXF83QOl5kA4wpQqo0f0+xA1G PNad+OwlBajNqcUYSB5yvvJAk7LOXcT3ykedTBC1YXvPSoi5x08NoxqyYvQo73jcntJO ND3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SZ725RMwJ8x3udrdBNPPIdNjigVVHtK7obFTohvtZcA=; b=S7xjT9rGhPoYLqi6inZPnprRbbYvINGo37h4SGNIUsGNHRZbbR+uN5d0hnbbh7G3Hd gU1HEd6dBfIQma1yA5Njki6YiScPbT7fyAbFxM8ucmI1y5xEWFm7827tdSeSkJOc8mUE hwXof99lt/bfX4HLP9Zl3G2Zd9+e8QH9GUXt9hTzYGfupj9iFJDSAwktI+pAEvusZLi2 1a6PWZ9ECyaGK+LCiVtWVbjCRzLluzKPCqtYNaZ5i+5IMZmx6JvxZNvfXdW8s4YdkzUI qx5w5Wr7WllBn0ftxumDvuQ0tv59oBHJXBtcwrHj2TRIAfGvfXze22xn3jhNTTVQMrwO a27A== X-Gm-Message-State: ACrzQf3Q38N3SWaQd9/N5FGi2j6R3q8ZVq2xBc6RNQv8SWD+5SCFGeDa qHks9mb4959e3jNsh8K9v7dCzwT72REZVA== X-Google-Smtp-Source: AMsMyM4UuCw9YzVPnlhwEH20kKTPuQQVKTiOIvPz3YS/1gO26xZpHQcELHrbj56rZ66fQBJyToO+Yg== X-Received: by 2002:adf:fc07:0:b0:236:6f04:2010 with SMTP id i7-20020adffc07000000b002366f042010mr17518285wrr.227.1666949777488; Fri, 28 Oct 2022 02:36:17 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id 6-20020a05600c230600b003cf37c5ddc0sm3629793wmo.22.2022.10.28.02.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 02:36:16 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Thu, 27 Oct 2022 09:10:12 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246410 Archived-At: >>>>> On Thu, 27 Oct 2022 09:10:12 -0700, Stefan Kangas said: >> diff --git a/lisp/keymap.el b/lisp/keymap.el >> index 107565590c..73a9e657fe 100644 >> --- a/lisp/keymap.el >> +++ b/lisp/keymap.el >> @@ -581,6 +581,10 @@ defvar-keymap >> (setq key (pop defs)) >> (pop defs) >> (when (not (eq key :menu)) >> + (when (not (key-valid-p key)) >> + (error >> + "Invalid key '%s' in keymap '%s' (see `key-valid-p')" >> + key variable-name)) >> (if (member key seen-keys) >> (error "Duplicate definition for key '%s' in keymap '%s'" >> key variable-name) Stefan> LGTM. I now think this would be a bad idea, because of the following type of code: (defvar-keymap footnote-minor-mode-map :doc "Keymap used for binding footnote minor mode." (key-description footnote-prefix) footnote-mode-map) That=CA=BCs perfectly valid, but fails with the above patch unless we 1. Check (key-valid-p (eval key)) 2. Add an autoload cookie for footnote-minor-mode-map That seems too high a price to pay for avoiding the original problem. Robert --=20