From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server Date: Sat, 12 Nov 2022 18:03:04 +0100 Message-ID: <871qq8xfzr.fsf@gmx.de> References: <8cf8ba5d-c604-b2dc-274a-7597b19fb73f@dfreeman.email> <87ilk5xq01.fsf@gmail.com> <87r0yrwfn3.fsf@gmail.com> <37716e41-5955-99f6-5204-e760a716fbf6@yandex.ru> <9bb290c8-f000-31d8-265d-b5441c33eb38@dfreeman.email> <4d50b820-7053-75eb-5b11-d3d36a02b013@dfreeman.email> <87v8nxsrq6.fsf@gmail.com> <87cza40xgs.fsf@dfreeman.email> <83edubrvf0.fsf@gnu.org> <87cz9v9irh.fsf@gmail.com> <83o7terf9a.fsf@gnu.org> <87k042tqze.fsf@dfreeman.email> <87fseqtpiu.fsf@dfreeman.email> <875yfm8lzf.fsf@gmail.com> <83wn82osoo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7217"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: felician.nemeth@gmail.com, danny@dfreeman.email, 58790@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , dgutov@yandex.ru, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 12 18:04:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ottvS-0001eE-J3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Nov 2022 18:04:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ottvH-0000rv-Au; Sat, 12 Nov 2022 12:04:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ottvG-0000rd-Kd for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 12:04:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ottvG-0005sh-CX for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 12:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ottvG-0007YZ-85 for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 12:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Nov 2022 17:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58790 X-GNU-PR-Package: emacs Original-Received: via spool by 58790-submit@debbugs.gnu.org id=B58790.166827259628995 (code B ref 58790); Sat, 12 Nov 2022 17:04:02 +0000 Original-Received: (at 58790) by debbugs.gnu.org; 12 Nov 2022 17:03:16 +0000 Original-Received: from localhost ([127.0.0.1]:48894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ottuW-0007Xa-Dn for submit@debbugs.gnu.org; Sat, 12 Nov 2022 12:03:16 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:37327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ottuU-0007XL-Ho for 58790@debbugs.gnu.org; Sat, 12 Nov 2022 12:03:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1668272585; bh=Fz/Q9f+m5bPqNLzvLHa2PLjdkMVxJzDuKzBrFf4DLBw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=q+BN3d14BI0oR2Z9fZUVir1DWZmmwNEL1ZgQ2gqd0iFZYSPo8KWTMNhihlUv8/mE6 vSlnnHuhboNg+zre0IFEfXFi0Qj/B2YiiEzxZ0277zw4t6qbr1SBbo8Awy0xp788Uj MLJdPYlLf+thB3iAcecTiZfL2DQpZ4+bUaaxfrWuAk51EktZyWYEdr4MRRYxoIYVeu H+0m0LY0pFQiqNQtITa2LBk64/PH5JEqmk3dlW2KwjqDK5X++Tx8NHf1kyUPQHRs8L gi8AwkAq8iz1f2qRWC+rZHe5dDd+b/ns68cM4mIV/Y5h3olArGVlVTdDEM48GUUkrt k5T+sXUU2PHzQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.18]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N17UW-1ozmx11L2Y-012UB1; Sat, 12 Nov 2022 18:03:05 +0100 In-Reply-To: <83wn82osoo.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Nov 2022 09:29:11 +0200") X-Provags-ID: V03:K1:aAPHvc2qrCyQ8NSf5GrYKWzDikt/vOITZqX33wUzQqknB68h02L jRUGGEc5FOvPaopvD87jh5VYQzYq9EpRpAdoozIVWR93UVV6rYfgFvCaGgZfasBhmGsklvb gBojoepBSxrH84PRI/aF18QFUEKQaD9YcC1ZwsZdii01Xjw37khGpPsDi724OITRuSbwEbg KqkLHHhmM4aQWDfnKizpA== UI-OutboundReport: notjunk:1;M01:P0:os2DvbjtEA0=;Ecso2n0nTMtFVgD9ycCWCbTihL2 mCcpl3FnFVL1jMrG0MkzuCmkE9tKrRbCqRNiOBF3k0FLC+70/X6QEY/KN1WGO9lUvNkfqulSH HXuK/e3A+BXDNTPLNe7f0PN9C5VC2ubEkGdhjWhbaRjLstamP7wQkp8P8rbbOyiEe/b11MJ5C B6NSj3nkKhbiWjvl9pQRYgUTHJpoftp0cinxKq2yNBHLvCNuKA93ty1El67d4Uw6LSR+K7WCe VlnL57YHEFvbR8peHNp1IGK59bQSZ7okXtLJl543WrMQrEBot8+XF24w3LbEmy0jrvr0fGXez U8sxj5Vq+bALukneUWWohNfzPg8ukTjcEpB7Iuz+7a1ed5SlWXtwsZ/tBPuAEgcdFOJzNXys1 Xs1IOg5R7wKmmrPS5pDIcML8SE51zwy7afrWraHs31GZ9zYtcz0LeaC8hu7DZxPnrP/cdDgo7 94B+PBdmgcAzroH65kUz3ksl//vWQ0mIFfh3EmQkWFe57IZqCQTgR58XfXHKPzgy+l9uWIm7o 5dsOj1Fh+bsmoqsDqeU3dFrF3F13v1FcBzxlyPmmBCtoYJqB2NjweqV4/yqYgDRutDsBreBCB d3v+R2vumGWSitN3F+pVa3hRefpuMU+G6hBFJ4RahIYP1ndOIhnD6E+1R/8bmpPVxUvFbgOOv QjgJpQAIPE4OQ82vH1JHRyv/BVoYueUSz08ZSi/ZujojKCgLlygjqPm8q/75iXR3Oz8SJAq8P peHyJMSQzC8s6dVKebkuQHBCvF0SegIpkNdvkHofiRVnzjtt08uSjaj+rFDPSyuZOZbrXx+E X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247670 Archived-At: Eli Zaretskii writes: Hi, >> > In reviewing the comments over and over I've made a modification to >> > the second patch involving the warning message. Instead of using an >> > arbitrary symbol I realized that the function `find-file-name-handler= ' >> > works when a nil value for the second argument (operation). >> >> I've now pushed the first patch, but I held off the second patch. >> >> I don't see this OPERATION=3Dnil option documented in the docstring of >> find-file-name-handler, so I'm not sure we should rely on it. >> >> I think we should provide OPERATION here, because what we want to check >> is if we, Emacs, can actually visit the file designated by the URI. So >> I think passing something like 'access-file' as the OPERATION argument >> makes more sense. But Eli probably has more knowledge here. Maybe >> passing nil is indeed correct. > > I think you are right, but Michael (CC'ed) will know for sure. Well, using nil as operation might work in this special case, but it disables an important feature of file name handlers: use of inhibit-file-name-operation. That's why it shouldn't be documented as such. Using just an arbitrary symbol as operation looks better to me. If you use an existing operation name, like access-file, it could conflict later with the inhibit-file-name-operation/inhibit-file-name-handlers machinery. This said, I don't understand why you need this check at all. But I haven't followed the eglot discussion closely. Best regards, Michael.