From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#59888: [PATCH] Add 'grep-heading-mode' Date: Fri, 09 Dec 2022 12:58:49 +0100 Message-ID: <871qp8eqkm.fsf@gmail.com> References: <87v8mndrla.fsf@gmail.com> <86bkodkpwa.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5053"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59888@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 09 12:59:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3c2C-00019d-DL for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Dec 2022 12:59:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3c1y-0006eT-Mh; Fri, 09 Dec 2022 06:59:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3c1u-0006cq-KH for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 06:59:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3c1u-0002GB-AU for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 06:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3c1u-0006s2-67 for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 06:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Dec 2022 11:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59888 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59888-submit@debbugs.gnu.org id=B59888.167058713926397 (code B ref 59888); Fri, 09 Dec 2022 11:59:02 +0000 Original-Received: (at 59888) by debbugs.gnu.org; 9 Dec 2022 11:58:59 +0000 Original-Received: from localhost ([127.0.0.1]:35600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3c1r-0006rh-3G for submit@debbugs.gnu.org; Fri, 09 Dec 2022 06:58:59 -0500 Original-Received: from mail-ed1-f50.google.com ([209.85.208.50]:43000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3c1p-0006rb-As for 59888@debbugs.gnu.org; Fri, 09 Dec 2022 06:58:57 -0500 Original-Received: by mail-ed1-f50.google.com with SMTP id a16so2770827edb.9 for <59888@debbugs.gnu.org>; Fri, 09 Dec 2022 03:58:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=l2njeQq8cw9YewUrDKlLSPOAyaewxnDnlXJGDUe516s=; b=nZHCwLcmypMmrcWZ4lEoO48pQcBNZG2CuGGL/QGkwumWrglUlCwwQ8KGfL1p/iHTde bVoAS1B+z2EoD+XEWT3MlnrOa8T4eij3PFnUJAlXjidoaycSwXePVJeuE8tzuc6HRtch VNFN5MoKUq7nGfxrAWK9FDwWe8TSKoUTnuYbAonfKSnvXZ0ZIftqwZ0Q8Spv8biul6y7 jrlD7AiW0gLYenwh/8L0C1H2m/g/1ebU1N9zZcZcLa+aqKei0zsEBe5l+9/xnjA3M7cX 6vmDN0bUGq1E3WIgcH8RM7VqcfNtaBXwg8Xzn9lXhaCJ9iN4nseCVyu/LS9u1ejH6zHy lHsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l2njeQq8cw9YewUrDKlLSPOAyaewxnDnlXJGDUe516s=; b=Y20dffHAhq+lx/gxcIfv1BghsEwy6odPInvtHi72kg7WMd9fjs8Td7rSjH7DmKW0um ytgMcjTK4h6+T0ixXeXc6ftzUJJV+WNVK5pi+guj8lPI+mEyQGiNi9YFqY0vbuDfCMS7 kRJaTuHABEpDE7RFT45J3Vl0teXo/BfcHlv6J6l7AwCt2HJOBtoCmEwFl1d39iV2RW6C 0yrYdbwF8QMhb8mqjwyDs0e7R6+UzLuioDoC56PdLLMVfIz5lIsTtIMd8bFsNg0FbqaS OT1sDMr5EinBdLCl0+nGKBhDjxgsXYtR59VPkkvo7QlrfytUMbGNhTlkTrv1BJlRiJe5 hpKw== X-Gm-Message-State: ANoB5pl2hHmQ71yg2Ua4dDmfegW7mfKn7dOCfXlXCRWhVGmWvejVMDCN MypjrLufSMzarbEJSeLgqSHhB3yrxJ7qsQ== X-Google-Smtp-Source: AA0mqf4Y/JYHJukR6qvHu1DPFAYpkHGXAO7tCmrsJd+Ls9LWtjvqu6Tm9u5TIC/UwQEZhlfVXzKJKA== X-Received: by 2002:a05:6402:4442:b0:45c:835b:944f with SMTP id o2-20020a056402444200b0045c835b944fmr5009125edb.11.1670587131306; Fri, 09 Dec 2022 03:58:51 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::a4bf]) by smtp.gmail.com with ESMTPSA id s5-20020a170906bc4500b007c0deb2449fsm480963ejv.82.2022.12.09.03.58.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Dec 2022 03:58:50 -0800 (PST) In-Reply-To: <86bkodkpwa.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 09 Dec 2022 09:28:53 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250383 Archived-At: On Fri, 9 Dec 2022 at 09:28, Juri Linkov wrote: >> +(defface grep-heading '((t :inherit font-lock-function-name-face)) >> + "Face of headings when using `grep-heading-mode'.") > > I suggest to keep the existing color scheme, thus inheriting from > compilation-info. This is the same color used by both grep.el and > xref.el by default. Yes, I came to the same conclusion in the meanwhile. >> +(defvar grep--heading-format >> + #("\n%s\n" 1 3 (font-lock-face grep-heading outline-level 1)) > > xref.el doesn't insert extra newlines between file sections. > It would be nice to keep the output closer to the existing > output in xref buffers. Okay, I agree with your reasoning and will make the change. However, I must say find the result less appealing. Note that, because of the lack of newlines, xref-file-header was naturally chosen as a heavier face. But it's all customizable anyway.