From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#61149: 29.0.60; keymap-local-set rejects key sequences Date: Sun, 29 Jan 2023 16:28:44 +0100 Message-ID: <871qndbbrn.fsf@rub.de> References: <83wn5578vn.fsf@gnu.org> <875ycpbe8l.fsf@rub.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8098"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61149@debbugs.gnu.org, Robert Pluim To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 29 16:29:07 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pM9cB-0001zy-OX for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Jan 2023 16:29:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pM9c8-0000s3-WF; Sun, 29 Jan 2023 10:29:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pM9c7-0000ru-QS for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 10:29:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pM9c6-0004fM-NY for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 10:29:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pM9c6-0007tY-H2 for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 10:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2023 15:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61149 X-GNU-PR-Package: emacs Original-Received: via spool by 61149-submit@debbugs.gnu.org id=B61149.167500613430332 (code B ref 61149); Sun, 29 Jan 2023 15:29:02 +0000 Original-Received: (at 61149) by debbugs.gnu.org; 29 Jan 2023 15:28:54 +0000 Original-Received: from localhost ([127.0.0.1]:45223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM9bx-0007t9-Nb for submit@debbugs.gnu.org; Sun, 29 Jan 2023 10:28:54 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:47083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM9bv-0007sv-40 for 61149@debbugs.gnu.org; Sun, 29 Jan 2023 10:28:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1675006125; bh=HvaVjXGK8Cca9gXvvWo/U80uDFwZxotvlC/iqRYjVsk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Hki6MFtpRZ3tX7WCCk52l/3zpGhDeWbXgjoyMLWd+vFQxo6DkOTqzqPwgupRgr2Tj 3/r7azsOgjubSQqyJKfOjjoJC2FpxYSQBUA/K9luWpcGkWJaSBL60PuY04nqud96ei usW5Tm1AtmV/ZvbrIhfj6cTzmOq9/XVI45o5X77t413/deDWbUFWGn0MIQn9UX8MiR RKtWahkG0cW5RehkHDcAhOGOiJQK0AhTW7ehmFM2A8DwDRvYRB5thpt1uN/5Mwluyb YvmV8scsGCpWc7kSSHTEXexMQw3Qn7vOEyY8Ze5+/iucSRRdPgXkbYklwLGD76MNhf 2uz8XoaQ2oszQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs ([89.246.36.185]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N0oFz-1oQ3HV3sfd-00wiKj; Sun, 29 Jan 2023 16:28:44 +0100 In-Reply-To: <875ycpbe8l.fsf@rub.de> (Stephen Berman's message of "Sun, 29 Jan 2023 15:35:22 +0100") X-Provags-ID: V03:K1:5ADZd2wm2Pxk4aEYKyECIOLF9VlXGNiwfPJy2MkJxAmkjFVzCzX kajkOmfyeWp5YCV8YTv94kYC5L+3RUZhSMVsa0xQFPJjgkZK6gB0XooLzEGbRj69t+e6ON6 QXyV0VIVK6N/9+Pyw6a6/lNh+DixiOob4quA+fQwAaNLGfm2wF+d9sryKk8VKJZJ1qip0Ig D4WYwBqvU6JcSNAMV/a8Q== UI-OutboundReport: notjunk:1;M01:P0:Cj4nIXHTdaA=;ubBFzYlIVCc6xGNEfLq0L6mUfIf YWYbyGke47JE3bfLN3YkoqS1P4R586cXiqVM2cWfDxCF81ast6w1nk1qMbOsegeEwhVH2wFyp 6s5q65iRMwPR7+YuoDmTMd43huA4eS08yTlL7RZJoQhA/BBAGPC8HO951bDxNMnJoECR/JInH W9UnfIItjOfLR90ljUH1u3LOMet6PtbLAr6+MMDXoUaAsczcFQISwaOHiVzI3AsPH5vMD7O2+ RcpFycTUkBLbhM0sLWBcuXRFoBEURsvQoJOlYLVRU1W9KqNt7w7Ip16kcJMtyPiGBZfCqqYcA 6KCnMj6KJDIFrJPtjMlwEQ2euvqBig1UZv9CC+QLp0EcbQilgTT04G83PDsryZGxu+hSGWTJa +LpbJ6tUuYPX9hNwilGmYoP5ds4RDYe5md5aLZnued/6+LC3U5f9AvJuAuCckuIQNii25nPPu QizONptd2+3PEczxqk5rz9FXNNhGFNdJ2cBIA/CEz9s+WuUq48PpFP7Cxg7jfEISZOPkJZgsa V8LQNjDDZCeyv6cYSfxi+tNINA8zFm9EcQQgohd4w/LWz6hJV0yreyvQsM7JjcQ4VDYRZA/kT 9FsaN9p7fy0AMvr4y30dTTEP8WaCqsWtRNDjAsW40/6tEV+7qARyeB+DnPh/5YiLCF0jTZeIW DRokXcluKDuRw841MY8P7dLBYM+53Tjry/7qkECmkeJ9WXDUfU9mBFB0NWTR+oHgf2QIbMbiw IRmwiRhYnfh1ZKvTuhcRfbF0VjF1g5QiFEY2qKCt/TJQ44pmXaTa/Uy8mV3fTrZSj/HpaZ1e X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254363 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sun, 29 Jan 2023 15:35:22 +0100 Stephen Berman = wrote: > On Sun, 29 Jan 2023 15:44:44 +0200 Eli Zaretskii wrote: > >> To reproduce: >> >> emacs -Q >> M-x keymap-local-set >> C-c . >> forward-line RET >> >> Observe the error message: >> >> [3 46] is not a valid key definition; see =E2=80=98key-valid-p=E2=80=99 >> >> (The error message comes from keymap--check.) >> >> To type the key sequence, I actually pressed Ctrl and typed 'c', then >> released Ctrl and typed '.'. Isn't that what one is supposed to use? >> >> So the above basically makes keymap-local-set useless, or am I missing >> something? The following does work: >> >> M-: (keymap-local-set "C-c ." 'forward-line) RET >> >> However, I could find no way of typing the string "C-c ." at the >> prompt of keymap-local-set. > > This patch seems to DTRT: > > diff --git a/lisp/keymap.el b/lisp/keymap.el > index 791221f2459..9643dce5f9c 100644 > --- a/lisp/keymap.el > +++ b/lisp/keymap.el > @@ -95,7 +95,8 @@ keymap-local-set > cases is shared with all other buffers in the same major mode." > (declare (compiler-macro (lambda (form) (keymap--compile-check key) fo= rm))) > (interactive "KSet key locally: \nCSet key %s locally to command: ") > - (let ((map (current-local-map))) > + (let ((map (current-local-map)) > + (key (key-description key))) > (unless map > (use-local-map (setq map (make-sparse-keymap)))) > (keymap-set map key command))) ... but not in your non-interactive case; so maybe this instead: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: keymap-local-set patch Content-Transfer-Encoding: quoted-printable diff --git a/lisp/keymap.el b/lisp/keymap.el index 791221f2459..48ec91d03c8 100644 =2D-- a/lisp/keymap.el +++ b/lisp/keymap.el @@ -98,6 +98,8 @@ keymap-local-set (let ((map (current-local-map))) (unless map (use-local-map (setq map (make-sparse-keymap)))) + (unless (stringp key) + (setq key (key-description key))) (keymap-set map key command))) (defun keymap-global-unset (key &optional remove) --=-=-= Content-Type: text/plain Steve Berman --=-=-=--