From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' Date: Fri, 03 Mar 2023 07:58:07 +0530 Message-ID: <871qm6po08.fsf@gmail.com> References: <877cw4tpap.fsf@ledu-giraud.fr> <838rgfe39g.fsf@gnu.org> <87ttz3jnzo.fsf@ledu-giraud.fr> <831qm7dzpg.fsf@gnu.org> <87lekfjh4q.fsf@ledu-giraud.fr> <87h6v3jgm8.fsf@ledu-giraud.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12617"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 61816@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 03 03:29:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXvAY-00034U-Dg for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Mar 2023 03:29:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXvAN-0005T1-Ex; Thu, 02 Mar 2023 21:29:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXvAM-0005Sp-CT for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 21:29:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXvAL-0007lZ-UM for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 21:29:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pXvAL-0002Sb-Pn for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 21:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Mar 2023 02:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61816-submit@debbugs.gnu.org id=B61816.16778105129421 (code B ref 61816); Fri, 03 Mar 2023 02:29:01 +0000 Original-Received: (at 61816) by debbugs.gnu.org; 3 Mar 2023 02:28:32 +0000 Original-Received: from localhost ([127.0.0.1]:59352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXv9r-0002Rs-Q7 for submit@debbugs.gnu.org; Thu, 02 Mar 2023 21:28:32 -0500 Original-Received: from mail-pj1-f68.google.com ([209.85.216.68]:55265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXv9q-0002Rf-4E for 61816@debbugs.gnu.org; Thu, 02 Mar 2023 21:28:30 -0500 Original-Received: by mail-pj1-f68.google.com with SMTP id bo22so1095963pjb.4 for <61816@debbugs.gnu.org>; Thu, 02 Mar 2023 18:28:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677810504; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rnxm30NUvkihnPSw1f4RCVZm6Fi1t4ZQdmS4dfTGtLE=; b=JWRD8nvTyGTCLbOdt8gMD3vhkR6xlwt5JKM5O3oDm8aCgNp9NkPUxq1Tzq5qErlWTR ZR+Z0fnSmK803Qi9euXhdGa+kLobk1UdN3rVN4CD64SQkYiMDntIH6/QCOJYm/8r52tv ud+7tLzAxy4riRZVRUukMkM+FpFHpPh9XdE2wSjIsEeEzqZoTChW17DFr/UrZRzrekrm OJiuaYix62YXpKfemE5U4QSX4refrRQFh5XTDwp9izwHauq1w4K+Bl3Wj3xrv1gnb27w Bp1umzNnjwDWkiwe5Np09vh78M5YZZwTF/e5OPhjMC3vM+P4+dvvt2PaNcAico9b8S2m fycg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677810504; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Rnxm30NUvkihnPSw1f4RCVZm6Fi1t4ZQdmS4dfTGtLE=; b=lqBPytScCOCLbTjh3CDCLDZEeoI1tdL+9WvHTkgdOib2t4kbS7T5xTxtrhBAhWx2Cw GX4j1VKR6E7a+mFMpyrIGdG2qWU7rkWG+KWVdwjaMqYQKgVFY7rb4DSsy8vmYr8qLigN Zt0DP9tM6coWUerntlWx+xfgbk8I5kBco6uNGy/nvHqyDYe5Lc1R5SrqCPOVzRd3hidh UVwYSqcXH+UhCJ5ijpfzDASTW6iaaPU28n4xIMdJlGLn0WTvjMYtlNkOF80BrKq4k+Gx ryZSztcdy+Ac24QppQs9FHAop11DWOkiAf6FAkj6qQssmZ3ibt9mqBnqXV5ZMwWMxA8d +QBg== X-Gm-Message-State: AO0yUKVFPt5mZ4mxZ+NcV9nGJHJD7sZCXxD/NgkZFpRszlZ9UkMTp+ie ZqDmmOU5CZeH5988iOW7Vfs= X-Google-Smtp-Source: AK7set+mmKJvsfz3WVAx0F+uEL9a0/wpVOrPNjOVqLwgHPaaSXelkkWZnyt0Ji0ifCUY0yjfYVWMYQ== X-Received: by 2002:a17:902:d587:b0:19c:f7f2:6097 with SMTP id k7-20020a170902d58700b0019cf7f26097mr432219plh.37.1677810503944; Thu, 02 Mar 2023 18:28:23 -0800 (PST) Original-Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id lg16-20020a170902fb9000b00192a8b35fa3sm329071plb.122.2023.03.02.18.28.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 18:28:23 -0800 (PST) In-Reply-To: <87h6v3jgm8.fsf@ledu-giraud.fr> (Manuel Giraud via's message of "Thu, 02 Mar 2023 16:51:59 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257189 Archived-At: [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE=AE= =E0=AE=BE=E0=AE=B0=E0=AF=8D=E0=AE=9A=E0=AF=8D 02, 2023] Manuel Giraud via "= Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > Manuel Giraud writes: > >> Eli Zaretskii writes: >> >> [...] >> >>> You are right, of course. It just feels strange to need to cater to >>> themes in a core package, when the way themes are supposed to >>> customize Emacs exists and can be used in this case as well. >>> >>> Alternatively, maybe themes should have settings for features such as >>> this one? >> >> Maybe, we could customize doc-view-svg-\(fore\|back\)ground in the >> official Emacs themes for a start, WDYT? > > ... and in order to be able to use 'custom-theme-set-faces', we could > have a 'doc-view-svg-face' (used only for its foreground and > background). I'm caching you up slowly =F0=9F=98=85 Themes can also use `custom-theme-set-variables' so I did not see a need to introduce a face when I made the patch back then.