From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#63731: [PATCH] Support Emoji Variation Sequence 16 (FE0F) where appropriate Date: Fri, 26 May 2023 17:29:41 +0200 Message-ID: <871qj3m7q2.fsf@gmail.com> References: <87a5xrzsph.fsf@stebalien.com> <83pm6nlhll.fsf@gnu.org> <87lehbrv30.fsf@stebalien.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11455"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 63731@debbugs.gnu.org To: Steven Allen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 26 17:30:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2ZOd-0002o2-7l for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 May 2023 17:30:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2ZOJ-0003XX-0Z; Fri, 26 May 2023 11:30:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2ZOF-0003Wc-8C for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 11:30:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q2ZOE-0002sS-Hm for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 11:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q2ZOE-0004vS-7I for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 11:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 May 2023 15:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63731-submit@debbugs.gnu.org id=B63731.168511499218896 (code B ref 63731); Fri, 26 May 2023 15:30:02 +0000 Original-Received: (at 63731) by debbugs.gnu.org; 26 May 2023 15:29:52 +0000 Original-Received: from localhost ([127.0.0.1]:50592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2ZO3-0004ui-Jg for submit@debbugs.gnu.org; Fri, 26 May 2023 11:29:51 -0400 Original-Received: from mail-wm1-f46.google.com ([209.85.128.46]:47170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2ZO1-0004uO-2l for 63731@debbugs.gnu.org; Fri, 26 May 2023 11:29:49 -0400 Original-Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-3f6d01d390bso9540525e9.2 for <63731@debbugs.gnu.org>; Fri, 26 May 2023 08:29:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685114983; x=1687706983; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=xjIAPl1LsqSHt/KiXAw0ZJcMD3cF1uSTXAOt9MF1rpw=; b=TkjIlKxZ29k9ggFpnOhPUpX2Nfmm0Mv3SLJ0pGHi5ELbcNWtC8+bGN/A6p7ROJRn0f cQa1fzumkTrrs6ZhnpYS4XAEyYeLjLUQLocFsrTy3hY+4yCPPz8/1Ft6HJ8PphSSdRlH EsIQHK0wfy4MipjfLTOIk4W+yt0OcJ/9pDTtFXyLdpC9a8JN+pP2POqv3duRb5Dr73rp Fa2tCaP651geKd7Gk88OmooS7bjB3B1YfD3EQh0d6yI/jdk4c6DVns1+uAcLPOx5+m00 q4kDwzy1qo4O9M+pFZNyp8ZPOCIuGxrR7Ez6la1/NliKLKcv7gUyRPMqe7gcK7BJZkdg vliw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685114983; x=1687706983; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xjIAPl1LsqSHt/KiXAw0ZJcMD3cF1uSTXAOt9MF1rpw=; b=ABEfCTEF8Ca+TArDGy9hZTeU7fQGjX5SbrPVIvE+eSonNuLjxX1G93OcbCVEqwzIcr JHGNeBYuaaAjA7HWtma1MUnfWxsyunHdPpOTDL8Zh4gQF34MIF6BjFHQVzphVx1+lfrG YrM7D3Atr6HCTZFKM7g1qlN7+BgwGxPT6HRIygJ9Zije0j5kMTjbLavvDxUuSnorw+CN Q0K+HTiY40+/IGHeNWjt+yV/hZo+xmKiNZIq/mxzsdKUR5s8bixOYFDUGMVDoeZm5GXl SS4jl/5FBTunk8nKEZ03kCeNjqKLuyBs8oo5uxT87JwXvWkGfetq4jr9HotiDDh2378m BFWg== X-Gm-Message-State: AC+VfDxBQL4OHklf3n+w6RJO0vWqsTri9VkBaTbs22rYlxyiqDHwjUto A+ZmeRFNiefX5moWaCmGfDIRhzYiwCY= X-Google-Smtp-Source: ACHHUZ5KEq29JKZu9stARE2p85nTydxxRoDCVbajCkwMIQQNUM/CzrKgMdnUdCalGt8DJlJx856qNA== X-Received: by 2002:a7b:c388:0:b0:3f5:bc8:e398 with SMTP id s8-20020a7bc388000000b003f50bc8e398mr1867814wmj.13.1685114982704; Fri, 26 May 2023 08:29:42 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id y8-20020a7bcd88000000b003f6038faa19sm8982208wmj.19.2023.05.26.08.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 May 2023 08:29:42 -0700 (PDT) In-Reply-To: <87lehbrv30.fsf@stebalien.com> (Steven Allen's message of "Fri, 26 May 2023 08:06:11 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262441 Archived-At: >>>>> On Fri, 26 May 2023 08:06:11 -0700, Steven Allen said: Steven> Eli Zaretskii writes: >> AFAIU, this change will populate composition-function-table for many >> "normal" characters, including ASCII digits and symbol/punctuation >> characters from the 0x2xxx blocks. E.g., after you build Emacs with >> this patch, what do the following evaluations yield: >>=20 >> M-: (aref composition-function-table ?0) RET >> M-: (aref composition-function-table #x2122) RET >>=20 >> If they yield non-nil values, it could mean dramatic slowdown of >> redisplay with these characters. Steven> Both of these yield nil with this patch applied (and I haven't = noticed Steven> any performance regressions). But it looks like you and Robert = have a Steven> better patch so I'll leave you to it. It=CA=BCs smaller, that=CA=BCs for sure. And it will definitely be faster. Steven> However, I'd like to draw your attention to the existing hard-c= oded Steven> VS-16 table here: Steven> https://git.savannah.gnu.org/cgit/emacs.git/tree/admin/unidata/= emoji-zwj.awk?h=3D4b3de748b0b04407d2492500c77905de56de1180#n72 Steven> It feels like this should either be the full table (the one in = the Steven> patch) or it shouldn't exist at all. But again, I'm not the exp= ert here. Welcome to the wonderful world of Unicode. The reason the table exists is that there are codepoints that are *not* emoji, but they=CA=BCre part of emoji sequences, so we still need to treat them as emoji in some situations. Why Unicode didn=CA=BCt just make them emoji I don=CA=BCt know. Robert --=20