From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#60338: [PATCH] Add option to present server changes as diffs Date: Sun, 18 Jun 2023 11:38:19 +0000 Message-ID: <871qi9q9uc.fsf@posteo.net> References: <87ilhy1dub.fsf@posteo.net> <877cs97kgb.fsf@posteo.net> <83jzw8yjv5.fsf@gnu.org> <877cs8g8oy.fsf@posteo.net> <83fs6wyhak.fsf@gnu.org> <87y1koerm6.fsf@posteo.net> <83bkhkyeze.fsf@gnu.org> <87v8fr6o86.fsf@posteo.net> <87zg52e12n.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23027"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 60338@debbugs.gnu.org, joaotavora@gmail.com To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 18 13:39:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qAqka-0005p1-Dw for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Jun 2023 13:39:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qAqkK-0001DF-Ke; Sun, 18 Jun 2023 07:39:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAqkJ-0001Cz-5P for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2023 07:39:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qAqkI-0006EI-C4 for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2023 07:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qAqkI-0006Tc-7L for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2023 07:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jun 2023 11:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60338 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60338-submit@debbugs.gnu.org id=B60338.168708830824852 (code B ref 60338); Sun, 18 Jun 2023 11:39:02 +0000 Original-Received: (at 60338) by debbugs.gnu.org; 18 Jun 2023 11:38:28 +0000 Original-Received: from localhost ([127.0.0.1]:53420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAqjj-0006Sl-Tz for submit@debbugs.gnu.org; Sun, 18 Jun 2023 07:38:28 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:58615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAqji-0006SY-8j for 60338@debbugs.gnu.org; Sun, 18 Jun 2023 07:38:27 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 79DEA240028 for <60338@debbugs.gnu.org>; Sun, 18 Jun 2023 13:38:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1687088300; bh=mfjguq+Fc+ltO27+a9QGaKFoYthCMIFw3n8dyL7FAd8=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=lqMn+ZuCaL/jxDf6lcbILSRDCAnPk3uLdsstkoEEYuextXsX5YawGupaI4E9LKwL3 KfHCeb0w6zbZH3DC+KJwkXKAYjKmsjIf2ikz0vqgYz1CXCZJCviL5TpbLw+C02wNdb AOJ6NDL64KaUXgL+YcAP+8EPNj2xMUt1ndDKwvyowVLNXwGAMu0XjoU4KrX85zLrJa QmEH2kKeQ6ifDTjHYnb68c3VbHe5G5TnS4DQ+MHLxEdwx+2EMx10/JH/XoSeoOx6yV LiIsOWt3/jiIwPyhlG0pGb131uZHEjSmsUzq6RTM8x0KSdv99ymQQD+uE2obnN0cTa cltQoLiN1P8Hw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QkW9l4RLRz9rxG; Sun, 18 Jun 2023 13:38:19 +0200 (CEST) In-Reply-To: <87zg52e12n.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 14 Jun 2023 11:27:12 +0000") X-Hashcash: 1:20:230618:me@eshelyaron.com::IMPklKqe7ymEyvHZ:0dHe X-Hashcash: 1:20:230618:60338@debbugs.gnu.org::Vp2je59F26X2WvDi:0IQz X-Hashcash: 1:20:230618:joaotavora@gmail.com::lMORpwj4GzrHSijJ:1YvB X-Hashcash: 1:20:230618:eliz@gnu.org::s8OSvSlSznhwVBxK:2iAO Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263623 Archived-At: Jo=C3=A3o, do you have anything to add to this discussion? Philip Kaludercic writes: > Eshel Yaron writes: > >> FWIW I'd definitely want to use this feature when it lands. >> >>>> It doesn't necessarily have to be the full-fledged diffs, it could be >>>> something approximate. After all, this is for human consumption. >>> >>> Not really, the point is that you can apply these diffs directly. Also, >>> I would not say that diffs are not for human consumption. >> >> I agree, it'd be nice to get a proper diff buffer with all the benefits >> of `diff-mode`. > > Right. > >> I also see how it would be useful for Emacs to be able to generate such >> a diff buffer directly from the change description that the LSP server >> provides, without applying the change and running the diff program, but >> it doesn't seem quite trivial so I hope that can be implemented as an >> enhancement down the line. (I'd be happy to help with that, BTW.) > > Yes, and we were to do this, I'd rather add it to a pure-elisp `diff' to > diff.el so that it can be transparently reused anywhere where the "diff" > program is missing. --=20 Philip Kaludercic