From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: sbaugh@catern.com Newsgroups: gmane.emacs.devel Subject: Re: call-process should not block process filters from running Date: Wed, 05 Jul 2023 22:24:11 -0400 Message-ID: <871qhlojzo.fsf@catern.com> References: <83cz1fvjef.fsf@gnu.org> <83h6qnpieb.fsf@gnu.org> <837criq321.fsf@gnu.org> <87r0pprhfd.fsf@catern.com> <1f5d7e77-3ac0-6b6e-9bd6-73302114ebaa@gutov.dev> <875y6zo8b2.fsf@catern.com> <889b8238-be22-4cc0-5884-dcb055641be9@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29032"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:HntGu9cGZfyPKnVrUeMqBIWg95s= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 06 06:39:24 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHGm4-0007L9-69 for ged-emacs-devel@m.gmane-mx.org; Thu, 06 Jul 2023 06:39:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHGlF-00024t-Ip; Thu, 06 Jul 2023 00:38:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHEfd-0003Lr-Nn for emacs-devel@gnu.org; Wed, 05 Jul 2023 22:24:38 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHEfP-0007hS-9b for emacs-devel@gnu.org; Wed, 05 Jul 2023 22:24:36 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qHEfL-0009nL-6q for emacs-devel@gnu.org; Thu, 06 Jul 2023 04:24:19 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 06 Jul 2023 00:38:19 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307485 Archived-At: Dmitry Gutov writes: > On 04/07/2023 21:12, sbaugh@catern.com wrote: >> Dmitry Gutov writes: >>> On 03/07/2023 03:02, sbaugh@catern.com wrote: >>>> Since project-find-regexp can >>>> take many seconds on large repos, I think this is useful. >>>> However, my other main test case/use case, being able to paste while >>>> Emacs is in call-process, doesn't work with this change. Any idea on >>>> how to make that work? >>> >>> Do you have some particular aim related to project-find-regexp? >>> >>> Having Emacs interactive and responsive while the search is ongoing >>> would require a different direction in design. >>> >>> Is the goal simply to have other, unrelated code keep running? >> I merely use project-find-regexp as an example of an important >> function >> that uses call-process. The goal is indeed simply to have other >> unrelated code keep running. And to be able to paste in other X >> clients. And be able to call project-find-regexp (and other >> call-process using functions) from a Lisp thread. > > Cool. > > project-find-regexp also works over Tramp, though. Given Michael's > objections in the other subthread, do you expect the proposed change > might break that? If it simply keeps the current limitations (when > invoked on a remote host), that's probably fine. There are a number of possible alternative approaches. One is to change project-find-regexp to use start-file-process instead of process-file. This would make project-find-regexp only work with TRAMP backends that support start-file-process, which is a loss, but there aren't actually many such backends AFAIK. It would be nice if Michael would respond to the actual question I posed, which is "how to avoid this loss". >> Changing project-find-regexp to use asynchronous processes would be >> nice, but more work, requiring more design effort. Running processes >> synchronously is fine, if it doesn't block unrelated code. > > Sure. And there's some expected additional process handling overhead > after switching to asynchronous calling. Though it would be nice to do > some experiments, to measure the potential slowdown. I suppose if project-files has a process-based implementation this is something we'd want to do anyway, so it can be passed as stdin for project-find-regexp. But yes, certainly.