From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#64046: 30.0.50; Quoting in customize choice tags Date: Fri, 25 Aug 2023 23:50:00 +0200 Message-ID: <871qfqiygn.fsf@gmx.net> References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> <87fs48ppr8.fsf@gmx.net> <87bkewpogr.fsf@gmx.net> <87h6oo2may.fsf@gmx.net> <65eb4677-5ae3-5170-1b37-2e02f974c972@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7890"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Mauro Aranda , 64046@debbugs.gnu.org To: Ola x Nilsson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 25 23:51:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qZei7-0001n7-Vm for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Aug 2023 23:51:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZehm-0005OT-R6; Fri, 25 Aug 2023 17:50:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZehl-0005Ld-EH for bug-gnu-emacs@gnu.org; Fri, 25 Aug 2023 17:50:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qZehl-0007PY-61 for bug-gnu-emacs@gnu.org; Fri, 25 Aug 2023 17:50:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qZehp-0003Ra-OE for bug-gnu-emacs@gnu.org; Fri, 25 Aug 2023 17:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Aug 2023 21:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs Original-Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.169300022213164 (code B ref 64046); Fri, 25 Aug 2023 21:51:01 +0000 Original-Received: (at 64046) by debbugs.gnu.org; 25 Aug 2023 21:50:22 +0000 Original-Received: from localhost ([127.0.0.1]:41231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZehB-0003QF-Hy for submit@debbugs.gnu.org; Fri, 25 Aug 2023 17:50:21 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:36499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZeh4-0003Pp-QV for 64046@debbugs.gnu.org; Fri, 25 Aug 2023 17:50:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1693000201; x=1693605001; i=stephen.berman@gmx.net; bh=fCTTKTp3uSTQ/NnQjpfdKLLkz6AOLKRafIY103IfRDc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=AU87I5cMpurfIBxde3d59mRUMrLq0RPHjjkTZoPpGkrgGlMyDvy49Tovxw0vRVUjIeTjpck KPXT7Pv0ezvl02KdyPlaRNJpsiEimcRr4fpcQr5ksmMjNUccZCeVxfKwVLfkoCki5kURp4B8P SkQjr/+ZcovrnDQT6LS5iezbt2+DvgBIsZsokSOq6Lfs+AAXP1UhwR6v+iVzjYfY427wL1Al2 nSdfFkRlqUGX2ZUfzsghacyUK3Mw8Kt5zLLrU4Q9XNuVVveWXLR9/7aSqmd0IIdMLKdCY+MY/ 7if2fU93SWEih+iCHj3vB2BdXMDaszF/8k38/VBdgqz6S0+5/E7Q== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfssd ([89.246.36.101]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MTRMs-1q8Ckn33AC-00Tjnf; Fri, 25 Aug 2023 23:50:01 +0200 In-Reply-To: (Ola x. Nilsson's message of "Fri, 25 Aug 2023 10:02:35 +0200") X-Provags-ID: V03:K1:Cd6o4+O90/LM2SBxhDBQroAqQKbpXR8fUlD+b/poPILMHkYbG4t 2ewHVDf82otdjsgMbJwA5Jt7NOb5WCKwi7zRpMz2jwGEDLGnF9zIrersHOb3aHjiETo27EB 2yhNdZlfpb9u2XhhgvaMnLZVRYBeVcJJ6H63mtIJLegLpTUa8AO7F1gByWBPbe+Rn5rykzo t9aZFh4G46SFWkh3yOPDQ== UI-OutboundReport: notjunk:1;M01:P0:2d5XsllOb+4=;ysRsnw41Q6e2i1bDzJx22+/+dQX bdbAg/itHNMGveCaygxxQ1yiJpltfo53WbcwAjUeYZaPNSQS/pRxmhpVlC/Mry4D8NT10sR7I 6bURPoVubfphkGwd3oVql84vDZfmJDGfKpemj3hkUf0kS0kTbW2InJzf4pZllvcwtzMfpuSpG q0iZ15HdOlzx74PVjT1RJ+Dv4losKt95ZcSWGI4ZwgIsjjPpvdU1dsnxEmLjYMXYdZQIRI+cV tDa92nMkNz5qvAfSSK1Yfmq+ZGghbYAWxuInrEMrT11Aa2YeJA/lCIP8zQO2p2+Cd+QXR7AEz dJ5g68XA18KbJqOJ3htNKHd42lxEDxt6L1EL9O3gEN2g1egLcnmH+AkXEvLgiAIRrdAnx3pta XKAwT7JOwHTtF/0926W2Q3GuEuJTQJAgSTLsRJ3oxSYT+NO0T0p2DSXeoy15+DZjuk9kobKfX dGr4AI+jNJhNfHf3dceaKawFuq4aUNr7jwCccJaEnrwqcasklpfT4CoH8ZmLWlVoJJdIkaUZb 63HJzRgmFWIZ/sRE3Kb88RWjsALU9Q4Wr7vnLz5Um7PtnVlol84KJXtKHI+oGdfSiz9vjK5zZ /rgdLelo9bNeb/m2IjqiE0S8b2jESjZh3KO24EgJcCRWXValVAPGbm7AoaborfWg1xSlLoIA+ DQdHgR3YmpwB9mktxvxf1ltrShAo5rVPLSAlEVRcrVCqQ4pR1Iq3qYiILOGga/McW5ctgu6rS G7KnB4fFYtWgRvkrCKtH5p7oZkSfeq4E3Y/+RbKq8rxLnkj6gLmhxA7a5BBd4/RgA5f+6Xsi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268449 Archived-At: On Fri, 25 Aug 2023 10:02:35 +0200 Ola x Nilsson w= rote: > On Thu, Aug 24 2023, Mauro Aranda wrote: > >> Stephen Berman writes: >> >>> On Thu, 24 Aug 2023 17:14:53 -0300 Mauro Aranda >> wrote: [...] >>>> Thinking about it, why do we need to call substitute-command-keys on t= he >>>> VALUE part (i.e., the cdr of the cons cell), in case of simple item >>>> definitions? >>>> >>>> I re-read the bug report, but I didn't find any reference to why that = is >>>> a need.=C2=A0 Did I miss something? >>> >>> Well, the VALUE is displayed on entering a choice.=C2=A0 That is, when = I do >>> >>> M-: (widget-choose "Title" '(("Use `a'" . "Use `1'") ("Use `b'" >> . "Use `2'"))) >>> >>> I see curve-quoting in the widget-choose buffer: >>> >>>=C2=A0=C2=A0=C2=A0 Available choices: >>> >>>=C2=A0=C2=A0=C2=A0 0 =3D Use =E2=80=98a=E2=80=99 >>>=C2=A0=C2=A0=C2=A0 1 =3D Use =E2=80=98b=E2=80=99 >>> >>>=C2=A0=C2=A0=C2=A0 C-g =3D Quit >>> >>> and when I enter e.g. `0' at the "Title: " prompt in the minibuffer, it >>> displays "Use =E2=80=981=E2=80=99", i.e., with curve-quoting.=C2=A0 But= if I omit the call to >>> substitute-command-keys on the cdr in widget-choose, then typing `0' at >>> the "Title: " prompt displays "Use `1'", i.e. with grave-quoting.=C2=A0= But I >>> don't know which one is the intended result. >> >> I see, thank you.=C2=A0 Your last patch looks good to me, then. > > The cdr is the return value, I would expect widget-choose to not > modify that.=20 I think this is indeed the correct expectation and I should have recognized it instead of looking only at appearances. But do you agree that applying (at least) quote substitution to the car of the simple item definition is appropriate here? If so, there is still the question of whether to use substitute-command-keys or just substitute-quotes. I'm inclined to stick with the former but would be fine with going with the latter. Steve Berman