From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items Date: Wed, 13 Sep 2023 18:48:11 +0200 Message-ID: <871qf22f5g.fsf@ledu-giraud.fr> References: <87zg4d56l8.fsf@ledu-giraud.fr> <87ilaz1wol.fsf@ledu-giraud.fr> <87fs3xo13z.fsf@yahoo.com> <83zg259iwz.fsf@gnu.org> <878r9losil.fsf@ledu-giraud.fr> <83tts2scvp.fsf@gnu.org> <87cyyo28m0.fsf@ledu-giraud.fr> <83cyyorfnr.fsf@gnu.org> <87r0n4sqm8.fsf@ledu-giraud.fr> <835y4gr9ao.fsf@gnu.org> <87jzswsfmi.fsf@ledu-giraud.fr> <83v8cgplqo.fsf@gnu.org> <87sf7kh1rg.fsf@ledu-giraud.fr> <87wmwv7hur.fsf@yahoo.com> <83edj3png3.fsf@gnu.org> <877cov7d7b.fsf@yahoo.com> <83bke7pm6m.fsf@gnu.org> <87y1hb5y0x.fsf@yahoo.com> <83a5trplax.fsf@gnu.org> <87pm2n5wyk.fsf@yahoo.com> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31459"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , stefankangas@gmail.com, 64440@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 13 18:49:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qgT3G-0007fx-OC for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Sep 2023 18:49:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgT2z-0007tj-64; Wed, 13 Sep 2023 12:49:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgT2x-0007tW-7Z for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 12:48:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgT2v-0002rO-De for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 12:48:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qgT30-0002BA-B2 for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 12:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Sep 2023 16:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64440-submit@debbugs.gnu.org id=B64440.16946237048211 (code B ref 64440); Wed, 13 Sep 2023 16:49:02 +0000 Original-Received: (at 64440) by debbugs.gnu.org; 13 Sep 2023 16:48:24 +0000 Original-Received: from localhost ([127.0.0.1]:35805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgT2N-00028K-P6 for submit@debbugs.gnu.org; Wed, 13 Sep 2023 12:48:24 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:39708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgT2J-00027l-BF for 64440@debbugs.gnu.org; Wed, 13 Sep 2023 12:48:22 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=4NGjcnma rOiNe8d39VwaGcpnHcpLz0JeFxxqIFpFqNI=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=VCUp685plq2kVOy6l3N8hs1OaEznnF g3CiJCeCYwOhkp2OPJWGgwlqus7uT7uywvwQqjnwW5GQS1qjdKsMsKAQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=4NGjcnmarOiNe8d3 9VwaGcpnHcpLz0JeFxxqIFpFqNI=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=U4DQqieHizYJrL3vrmD+jtOC0XUndzEQz2t6BJ Ln9vIqRhuZ+EGrM7IiZsqmkzV31zHsAw2ondz+Sii6JdZ7C8U79oBnSkUYqTJ84brzZ6dd aKzemkCnV+Pzx+u4QvwIP+jQkvydNl46ryE30/TGkn4lfhCl50JPEf5OsiNzsED7bd6BfP 75z7ucqhZmKN0jia7ihqcKrxo7JpDSntTbZNn1WmjsW5lyNePjGK3kHEmcwKObl+DDRfgo MCgPwtL5L08NAk/yvpjvGRg+BOpN6b4/BruRHXMeOxyHw64QMOekgJZznWWbABl9ufIkDb y0OJVzyClfivJeMUkeownVRg== Original-Received: from computer (93-158-28-210.subs.ibrowse.com [93.158.28.210]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id d0c23cbc (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 13 Sep 2023 18:48:12 +0200 (CEST) In-Reply-To: <87pm2n5wyk.fsf@yahoo.com> (Po Lu's message of "Tue, 12 Sep 2023 21:42:59 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270335 Archived-At: Po Lu writes: > Eli Zaretskii writes: > >>> From: Po Lu >>> Cc: manuel@ledu-giraud.fr, stefankangas@gmail.com, 64440@debbugs.gnu.org >>> Date: Tue, 12 Sep 2023 21:19:58 +0800 >>> >>> Please, let's not argue over this, when the alternative is to >>> introduce what is at the maximum 10 lines of straightforward code. >> >> I could agree if you applied the same standards and criteria to >> arguments where you are the party that is being asked to write or >> change a few lines. There, you tend to argue endlessly, it seems. > > I try my best, but sometimes it's challenging not to get worked up over > these things. I hope that doesn't happen here: no other program on Unix > systems highlight menu bar entries as the mouse pointer enters them. Ok. I'm going to explain my history behind this patch: I was annoyed by the fact that moving the mouse pointer from a buffer to the menu bar most of the time (in no toolkit build anyway), the mouse pointer keeps its "vertical bar" form. So that was, at first, what I wanted to change. I then look at the code and discover those 'note_*_highlight' functions and how they are used to highlight areas (buttons) on the tool bar or the tab bar. And I thought "why not use this feature? it could be even better than what I wanted!" But now, I'm not so sure. Just changing the mouse pointer (to an arrow, for instance) when entering the menu bar might be sufficient (and what was my first intent). And I don't think that it should respect 'mouse-highlight' BTW. What do you think, if I rework my patch with this idea in mind? -- Manuel Giraud