From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#66743: 30.0.50; Crash when dumping reftex Date: Thu, 26 Oct 2023 11:55:38 +0000 Message-ID: <871qdhd2dh.fsf@localhost> References: <875y2v592c.fsf@localhost> <83a5s6kgxx.fsf@gnu.org> <87wmvadfkw.fsf@localhost> <87cyx1d91n.fsf@localhost> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22882"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 66743@debbugs.gnu.org, Stefan Kangas To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 26 13:54:52 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qvywt-0005hN-U5 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Oct 2023 13:54:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qvywa-0005vO-Fl; Thu, 26 Oct 2023 07:54:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvywZ-0005v6-69 for bug-gnu-emacs@gnu.org; Thu, 26 Oct 2023 07:54:31 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qvywY-0005sl-UZ for bug-gnu-emacs@gnu.org; Thu, 26 Oct 2023 07:54:30 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qvyx3-0005DM-KE for bug-gnu-emacs@gnu.org; Thu, 26 Oct 2023 07:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Oct 2023 11:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66743 X-GNU-PR-Package: emacs Original-Received: via spool by 66743-submit@debbugs.gnu.org id=B66743.169832129020019 (code B ref 66743); Thu, 26 Oct 2023 11:55:01 +0000 Original-Received: (at 66743) by debbugs.gnu.org; 26 Oct 2023 11:54:50 +0000 Original-Received: from localhost ([127.0.0.1]:60698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvywg-0005Cc-Vh for submit@debbugs.gnu.org; Thu, 26 Oct 2023 07:54:50 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:48503) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvywd-0005CM-If for 66743@debbugs.gnu.org; Thu, 26 Oct 2023 07:54:36 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id C623A24002E for <66743@debbugs.gnu.org>; Thu, 26 Oct 2023 13:53:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1698321238; bh=TPKVZoF46nYJrhxiIn4BDYBYzrhJ+Wr4sdeHGS4IH8M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=cJLrluqE3ieNlY+KNTGdUOU6QLPV6AIXRNlKl9DXvH70on/lB0Op+zY7p/B6kVIQ0 L94hexp8C0lFJdrxsj5SsK9a9192+YfRhlINMrrhs2T0sNNV3fxODxeXxbvEuW5Ams HUlHKTvBq/N0VA9QbH8yTbAl2tzccuFTTgxsRlm8QHxJLSN9WScwe7T/n4xD2Yi6uL M3IaioAi5IETo+qFcgAwig3YyOzp4k5nTXP5n9iY8klKdLHOI7EuKDPLNDdMtFYCPK foQrzepOHsCcaNW50Qwhu+NBcADcWS7XENa6P4Y6DFSE9rfg1lZfu/FZXMyKldjZbf ly+iET8Eq6qoA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SGPMn4gGLz9rxD; Thu, 26 Oct 2023 13:53:57 +0200 (CEST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273267 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Gerd M=C3=B6llmann writes: >>> Patches to do that are welcome, I think. >> >> May you please point me to a way to output warning to stderr from inside >> pdumper code? > > fprintf (stderr, ...) I'd say. That's more obvious than I thought :) See the attached patch. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-src-pdumper.c-dump_buffer-Print-message-before-abort.patch >From c777b76ec544b33cd94e0d945554b9c6aeb785f1 Mon Sep 17 00:00:00 2001 Message-ID: From: Ihor Radchenko Date: Thu, 26 Oct 2023 14:52:32 +0300 Subject: [PATCH] * src/pdumper.c (dump_buffer): Print message before aborting (bug#66743) When the buffer contains overlays, it cannot be dumped. Print a message describing this fact before aborting Emacs. --- src/pdumper.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/pdumper.c b/src/pdumper.c index 315a31e2bcb..cd5a50f9b48 100644 --- a/src/pdumper.c +++ b/src/pdumper.c @@ -2862,8 +2862,11 @@ dump_buffer (struct dump_context *ctx, const struct buffer *in_buffer) DUMP_FIELD_COPY (out, buffer, long_line_optimizations_p); if (!itree_empty_p (buffer->overlays)) - /* We haven't implemented the code to dump overlays. */ - emacs_abort (); + { + /* We haven't implemented the code to dump overlays. */ + fprintf(stderr, "Dumping overlays in buffers is not yet implemented. Aborting...\n"); + emacs_abort (); + } else out->overlays = NULL; -- 2.42.0 --=-=-= Content-Type: text/plain -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at --=-=-=--