bug#66743: 30.0.50; Crash when dumping reftex

[Ihor Radchenko <yantar92@posteo.net>]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

Gerd Möllmann <gerd.moellmann@gmail.com> writes:

>>> Patches to do that are welcome, I think.
>>
>> May you please point me to a way to output warning to stderr from inside
>> pdumper code?
>
> fprintf (stderr, ...) I'd say.

That's more obvious than I thought :)

See the attached patch.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-src-pdumper.c-dump_buffer-Print-message-before-abort.patch --]
[-- Type: text/x-patch, Size: 1179 bytes --]

From c777b76ec544b33cd94e0d945554b9c6aeb785f1 Mon Sep 17 00:00:00 2001
Message-ID: <c777b76ec544b33cd94e0d945554b9c6aeb785f1.1698321284.git.yantar92@posteo.net>
From: Ihor Radchenko <yantar92@posteo.net>
Date: Thu, 26 Oct 2023 14:52:32 +0300
Subject: [PATCH] * src/pdumper.c (dump_buffer): Print message before aborting
 (bug#66743)

When the buffer contains overlays, it cannot be dumped.  Print a
message describing this fact before aborting Emacs.
---
 src/pdumper.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/pdumper.c b/src/pdumper.c
index 315a31e2bcb..cd5a50f9b48 100644
--- a/src/pdumper.c
+++ b/src/pdumper.c
@@ -2862,8 +2862,11 @@ dump_buffer (struct dump_context *ctx, const struct buffer *in_buffer)
   DUMP_FIELD_COPY (out, buffer, long_line_optimizations_p);
 
   if (!itree_empty_p (buffer->overlays))
-    /* We haven't implemented the code to dump overlays.  */
-    emacs_abort ();
+    {
+      /* We haven't implemented the code to dump overlays.  */
+      fprintf(stderr, "Dumping overlays in buffers is not yet implemented.  Aborting...\n");
+      emacs_abort ();
+    }
   else
     out->overlays = NULL;
 
-- 
2.42.0


[-- Attachment #3: Type: text/plain, Size: 224 bytes --]


-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>