From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jens Schmidt via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67005: 30.0.50; improve nadivce/comp/trampoline handling Date: Sat, 25 Nov 2023 13:41:16 +0100 Message-ID: <871qcegg43.fsf@sappc2.fritz.box> References: <874jhv9921.fsf@sappc2.fritz.box> <875y24zrt1.fsf@sappc2.fritz.box> <87ttpmwuxi.fsf@sappc2.fritz.box> <877cmct4a1.fsf@sappc2.fritz.box> <87bkbmiwpf.fsf@sappc2.fritz.box> <87leap8n1z.fsf@sappc2.fritz.box> <87leaob192.fsf@sappc2.fritz.box> Reply-To: Jens Schmidt Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21161"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: Andrea Corallo , 67005@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 25 13:42:07 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6rz5-0005Jw-6d for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Nov 2023 13:42:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6ryy-0000JT-9u; Sat, 25 Nov 2023 07:42:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6ryv-0000J3-9W for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 07:41:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6ryu-0000QQ-RX for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 07:41:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r6ryz-0006RN-Sh for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 07:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jens Schmidt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Nov 2023 12:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67005 X-GNU-PR-Package: emacs Original-Received: via spool by 67005-submit@debbugs.gnu.org id=B67005.170091609524714 (code B ref 67005); Sat, 25 Nov 2023 12:42:01 +0000 Original-Received: (at 67005) by debbugs.gnu.org; 25 Nov 2023 12:41:35 +0000 Original-Received: from localhost ([127.0.0.1]:38094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6ryZ-0006QY-DU for submit@debbugs.gnu.org; Sat, 25 Nov 2023 07:41:35 -0500 Original-Received: from mr5.vodafonemail.de ([145.253.228.165]:48820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6ryX-0006QK-6W for 67005@debbugs.gnu.org; Sat, 25 Nov 2023 07:41:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-23sep; t=1700916082; bh=0aSOBk91lcRBRqVZuG9voszXJznmLCgOdnHn88lRbTs=; h=From:To:Subject:References:Date:In-Reply-To:Message-ID:User-Agent: Content-Type:From; b=BUsIvsAiGqoa0GsRHph3vGQB8cMKXac/8mRdoagNxS8bA/UyI1dXOP1B2uyhf61be CXd8Uw5mO0xA62zet4blL2eFXK+ETYaqBf0BIdqJ1WKO2Tg7zo2UEuLHDoT1OZKCqm FzZtXT4x7oNtOsg0Ncuj/xTq/45oCBBASzycjXL4= Original-Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr5.vodafonemail.de (Postfix) with ESMTPS id 4Scs0f4s9jz1y4Y; Sat, 25 Nov 2023 12:41:22 +0000 (UTC) Original-Received: from sappc2 (port-83-236-12-16.dynamic.as20676.net [83.236.12.16]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4Scs0Z0QvkzKm4T; Sat, 25 Nov 2023 12:41:17 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Thu, 23 Nov 2023 18:48:49 -0500") X-purgate-type: clean X-purgate: clean X-purgate-size: 1260 X-purgate-ID: 155817::1700916078-1A7FE58E-528A04DD/0/0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274970 Archived-At: Stefan Monnier writes: >> How would one warn during bootstrap? > > `message` That simple. >> And would this be noticed? > > Yes. The build should not emit any warning, so unless the warning is > particularly discrete, we do notice it. What about this one? Too indiscrete? (when purify-flag (message "\a\nWarning: Invalid pre-dump advice on %s\n" symbol)) Plus another idea: Instead of placing the test into `advice-add', how about checking functions for advices in loadup.el? We could place that check just before site-load.el gets loaded, to avoid trouble for Emacs modders. I tried the following, and it seemed to do the trick: diff --git a/lisp/loadup.el b/lisp/loadup.el index 07895228d0d..49d675dc5cb 100644 --- a/lisp/loadup.el +++ b/lisp/loadup.el @@ -393,6 +393,11 @@ ;; from the repository. It is generated just after temacs is built. (load "leim/leim-list.el" t) +(mapatoms + (lambda (f) + (and (advice--p (symbol-function f)) + (error "Pre-dump advice on %s" f)))) + ;; If you want additional libraries to be preloaded and their ;; doc strings kept in the DOC file rather than in core, ;; you may load them with a "site-load.el" file. Thanks.