From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 1ef8b90ae06: Simplify imenu setup for {cmake, dockerfile}-ts-modes Date: Sat, 27 Jan 2024 16:37:48 +0800 Message-ID: <871qa3kw83.fsf@yahoo.com> References: <170633049046.30614.86278647904102476@vcs2.savannah.gnu.org> <20240127044130.C6F37C4068B@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6929"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Randy Taylor To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 27 09:38:45 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rTeD7-0001gS-05 for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Jan 2024 09:38:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTeCU-0002L8-RZ; Sat, 27 Jan 2024 03:38:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTeCO-0002K8-Tz for emacs-devel@gnu.org; Sat, 27 Jan 2024 03:38:00 -0500 Original-Received: from sonic305-20.consmr.mail.ne1.yahoo.com ([66.163.185.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rTeCM-00033M-TV for emacs-devel@gnu.org; Sat, 27 Jan 2024 03:38:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706344675; bh=1zTpUwdqpRTk7d92K1AtFjThL4E2piz/Cmc0oME5BYE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=Ad42mKePFw62FWktMLO/EoE17xMe94wuE/6MU8h6sMqyhVClryPV48t0eXSGaoHQoPkkJ1Y86GNRva716d6CphbC4P25ifznLDomdAVBuXDNCpQjCH/JO9OKzlOOTp/pvX0fXv/Ttm7ei902zrEmHWaOL6Da9jxkXmkWj6JMavxpDYizBy4Ec9SWhpGzF1WzmNYIr7T0/pyD0mMFnI/uI596bw5RAxPPx83cBgIw9Nwg6dqpY63MCHAyW/GQ0KbbRNzoZtp1rjyD6EDsC0ZJhfJmaDdn+fc+aL7Dj+9H8vDBhDsUGL4tNIxYWj0/R/yYUYpstUGiMd2QazuVS780qg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706344675; bh=0hl3PrgxYIVuY24xhVz4zb3vcPSNKk10sHX8zwwTmwp=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=FYRUU7mdd2HTVWNfHEXDymyR2COsO7QvyCCdGYtRP1BVZ1foxwQSyb8ijklRzs7w7J7rz6Qp8ynCNbm0kLvH2GUjjKFiZRzCqn+OLlez0QR3OsSBkHsAQCSjUjLgfjC/YkY8VDme7TeOpS1ml8DxnKso5O87KpZi2qq5NNzxhHjyQloGWn2g6JY7Mijrj/CWBtD5ZX51lgJtUKBxU8nwVFALJeSduwYyPx+tw3YXIUHZyt6lNw+i84MNOpnk/rxxNDwGJME+MWdgG4u2AzpvDCxB0igTjwVNpinH4rqHfeXcqGQgaqzUr6ppRZ5lbrXamr6UDPqRM5KDWbgZCinuGg== X-YMail-OSG: WYBSHFYVM1nYJeGxfZhblhk6zZ.LZW.Tefczb6LGMQ9QumU4aCBsFxgaU93XO9z thWVuG0rVrKOhwepoDgMJaiCSE3P7W0GVhwiJWGhrRLIDZxqFiEzIA.FkC4Lan2yj89YAb4pXXpx rr8hq8nmO18c8FqQCANih82u2Gw3Sgyt8cwc84rL0R50C4yK5z4yzIdZ31c2ZhRrPb3XaDJ9GFby lK1MzinKvftoRjVwHWGzA.OtfS9KndSVzvmuuJa4_BZpfvdJ9X6imSi26hqwuIfxzrx.dwTVYK1q lmU4mQ.nOz.IwqzELRbaLoBSu5PGdv_GTtxKa5RuEcgcRuo5zEMVtHWB1pDDu2ISj5m5EYyo1pde 6b3UKbN0Z_jJSii.DPINGpdX2fTnQ3AthwAVdgLSYXIU9CdU4Mz_cviXTwctcCHUn66jxch0F8bZ qTko_pvAozs51.pyN9S.R6Z6KJscV0Knq1DGBbAE6Clyf5QBzl.p32AGRqZmYMEXLdxj9lIitWsS AL5P7ctgdompHC.HSnJ_XtO5pCVYW_pAgz6r1TVde8f7DWnDDvF8LASeAi7_zVkcpvLDwWgENbxx M8dXnWARpkqTao6zH3HKLeo208RgfC9kP97KcNfTqQ2LXpLUlCvXahgFrQTbndFywe1nVHIEq.PG PuIHIR7nkpOI_yyFppYd_H33dLlHs36PdN_QLZM0PRN7IntVyj_3bACg5MNc8l0sONLaKjyTfssd xt2z9lQBzGQLUGslvV7Gp387A1RACIpwPATspNwNVrdYKXjEDVSTF6X53fNrvShi8wnVWM4DbkCi HuhHZnAcqgoUBNZSmWMtoVqp4eoCkQmoA8puveK0vV X-Sonic-MF: X-Sonic-ID: 379866b5-7304-4368-8dd7-694f7c1577c5 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ne1.yahoo.com with HTTP; Sat, 27 Jan 2024 08:37:55 +0000 Original-Received: by hermes--production-sg3-6dc75bc8fb-67hzc (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 1c9ad9c91c1d4c14e5d0df31d1ddbcd9; Sat, 27 Jan 2024 08:37:53 +0000 (UTC) In-Reply-To: <20240127044130.C6F37C4068B@vcs2.savannah.gnu.org> (Yuan Fu's message of "Fri, 26 Jan 2024 23:41:30 -0500 (EST)") X-Mailer: WebService/1.1.22046 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.185.146; envelope-from=luangruo@yahoo.com; helo=sonic305-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315470 Archived-At: Yuan Fu writes: > * lisp/progmodes/cmake-ts-mode.el (treesit-induce-sparse-tree, > treesit-node-child, treesit-node-start, cmake-ts-mode--imenu, > cmake-ts-mode--imenu-1): Remove. > (treesit-search-subtree): Declare. > (cmake-ts-mode--function-name): New function. > (cmake-ts-mode): Use it. > > * lisp/progmodes/dockerfile-ts-mode.el (treesit-induce-sparse-tree, > treesit-node-start, dockerfile-ts-mode--imenu, > dockerfile-ts-mode--imenu-1): Remove. > (dockerfile-ts-mode--stage-name): New function. > (dockerfile-ts-mode): Use it. On another score, this ChangeLog entry is formatted incorrectly. Newlines should never be inserted inside a pair of parentheses! I see that the `M-q' command in vc-log-mode can fill ChangeLog entries in this manner, which will be fixed, but for now please take care to repair any improperly formatted entries it might produce.