From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/org-contrib eaef050f28: lisp/ox-bibtex.el (org-bibtex-goto-citation): Add missing require Date: Tue, 30 Jan 2024 15:19:47 +0000 Message-ID: <871q9yonl8.fsf@localhost> References: <170661605561.6823.12101770977814458206@vcs2.savannah.gnu.org> <20240130120056.91DA8C0EFEF@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23193"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 30 16:17:56 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rUps4-0005qO-6W for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Jan 2024 16:17:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUprH-0003cd-Ua; Tue, 30 Jan 2024 10:17:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUpqZ-0002vc-TW for emacs-devel@gnu.org; Tue, 30 Jan 2024 10:16:24 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUpqY-0004Dr-6L for emacs-devel@gnu.org; Tue, 30 Jan 2024 10:16:23 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 4A914240103 for ; Tue, 30 Jan 2024 16:16:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1706627777; bh=pZZgPZBuNysoJKjRE3mvHnMw+Vc8EiaN6cBAI2t+uZE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=LBGTOYdbgYrHHlMobkm1vsXutspXCaptpyXfj6QmF1C/C+aZ4vxFWWbGI/HqC+9Vd PC95us1GjYo7HfV4sbtkMw/LMw5F/dILM8e6Ahspj2311Ot9rxGuZ+Mqr7pR90F8O9 LNx4VP9eWMBAwgzzYoNks1fyLwsfh1ql9BWVNTqBSghV80LbXIScpKN/szJ0cSOixc FjxBR8HsZKL1lejZIrhAAVEp5Q7PKBv83kv9cPrOZ5AHL+PXcAvtEOdvLwnziNGtcK yFLx2PyFcW4isLw9N4HyEyjpIdwegjErvjCuMD/fu5FJlqvi/4mIAoqtOxtleusMNT lGXYv3HDmUdYg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TPTJw4BHjz6tvd; Tue, 30 Jan 2024 16:16:16 +0100 (CET) In-Reply-To: Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315640 Archived-At: Stefan Monnier writes: > The `declare-function` should be placed right next (after) the > `require`. In practice it (currently) makes no difference (because of > technical details of how `declare-function` is (currently) implemented), > but in theory it clarifies that you do not intend to claim that it's safe > to call `obe-citations` from anywhere within `ox-bibtex`, but only from > within `org-bibtex-goto-citation`. Interesting. I am wondering if byte-compiler can somehow detect such scenarios and throw a warning. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at