From: Ihor Radchenko <yantar92@posteo.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [nongnu] elpa/org-contrib eaef050f28: lisp/ox-bibtex.el (org-bibtex-goto-citation): Add missing require
Date: Tue, 30 Jan 2024 15:19:47 +0000 [thread overview]
Message-ID: <871q9yonl8.fsf@localhost> (raw)
In-Reply-To: <jwvwmrratcn.fsf-monnier+emacs@gnu.org>
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> The `declare-function` should be placed right next (after) the
> `require`. In practice it (currently) makes no difference (because of
> technical details of how `declare-function` is (currently) implemented),
> but in theory it clarifies that you do not intend to claim that it's safe
> to call `obe-citations` from anywhere within `ox-bibtex`, but only from
> within `org-bibtex-goto-citation`.
Interesting.
I am wondering if byte-compiler can somehow detect such scenarios and
throw a warning.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2024-01-30 15:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170661605561.6823.12101770977814458206@vcs2.savannah.gnu.org>
[not found] ` <20240130120056.91DA8C0EFEF@vcs2.savannah.gnu.org>
2024-01-30 12:41 ` [nongnu] elpa/org-contrib eaef050f28: lisp/ox-bibtex.el (org-bibtex-goto-citation): Add missing require Stefan Monnier
2024-01-30 15:19 ` Ihor Radchenko [this message]
2024-01-30 17:31 ` Stefan Monnier
2024-01-30 18:59 ` Ihor Radchenko
2024-01-30 21:41 ` Stefan Monnier
2024-01-30 22:11 ` Ihor Radchenko
2024-01-30 22:57 ` Stefan Monnier
2024-01-31 14:51 ` Emanuel Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q9yonl8.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.