Re: master f2bccae22bd 2/2: Use a dedicated type to represent interpreted-function values

Re: master f2bccae22bd 2/2: Use a dedicated type to represent interpreted-function values

[Michael Albinus]

Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:

Hi,

I don't know whether it is due to *this* commit, but we have now an
error in oclusure-tests:

> branch: master
> commit f2bccae22bd47a2e7e0937b78ea06131711b935a
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     Use a dedicated type to represent interpreted-function values

--8<---------------cut here---------------start------------->8---
# make -C test oclosure-tests
make: Entering directory '/home/albinus/src/emacs/test'
make[1]: Entering directory '/home/albinus/src/emacs/test'
  ELC+ELN  lisp/emacs-lisp/oclosure-tests.elc
  GEN      lisp/emacs-lisp/oclosure-tests.log
Running 5 tests (2024-04-29 18:03:40+0200, selector `(not (tag :unstable))')
Test oclosure-test backtrace:
  signal(cl-no-next-method (oclosure-test-gen #s(cl--generic-method :s
  apply(signal (cl-no-next-method (oclosure-test-gen #s(cl--generic-me
  (setq value-47 (apply fn-45 args-46))
  (unwind-protect (setq value-47 (apply fn-45 args-46)) (setq form-des
  (if (unwind-protect (setq value-47 (apply fn-45 args-46)) (setq form
  (let (form-description-49) (if (unwind-protect (setq value-47 (apply
  (let ((value-47 'ert-form-evaluation-aborted-48)) (let (form-descrip
  (let* ((fn-45 #'member) (args-46 (condition-case err (list (oclosure
  (let* ((i 42) (ocl1 (let ((temp0 1) (temp1 2) (temp2 "hi")) (let ((n
  #f(lambda () [t] (let* ((i 42) (ocl1 (let ... ...)) (ocl2 (let ... .
  #f(compiled-function () #<bytecode 0x71b0182d7e06f0c>)()
  handler-bind-1(#f(compiled-function () #<bytecode 0x71b0182d7e06f0c>
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name oclosure-test :documentation nil :bod
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
  ert-run-tests-batch((not (tag :unstable)))
  ert-run-tests-batch-and-exit((not (tag :unstable)))
  eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
  command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
  command-line()
  normal-top-level()
Test oclosure-test condition:
    (cl-no-next-method oclosure-test-gen
		       #s(cl--generic-method (oclosure) nil curried
					     #[(cl--nm) ((let ... ...))
					       (t)])
		       #[nil
			 ((if t nil fst snd (setq name name))
			  (list fst snd i))
			 ((fst . 1) (snd . 2) (name . "hi") (i . 44)) nil
			 oclosure-test])
   FAILED  1/5  oclosure-test (0.000352 sec) at lisp/emacs-lisp/oclosure-tests.el:27
   passed  2/5  oclosure-test-interactive-form (0.000501 sec)
   passed  3/5  oclosure-test-limits (0.000585 sec)
   passed  4/5  oclosure-test-mutate (0.000284 sec)
   passed  5/5  oclosure-test-slot-value (0.000413 sec)

Ran 5 tests, 4 results as expected, 1 unexpected (2024-04-29 18:03:41+0200, 0.886731 sec)

1 unexpected results:
   FAILED  oclosure-test
--8<---------------cut here---------------end--------------->8---

Best regards, Michael.

Re: master f2bccae22bd 2/2: Use a dedicated type to represent interpreted-function values

[Mattias Engdegård]

29 apr. 2024 kl. 18.11 skrev Michael Albinus <michael.albinus@gmx.de>:

> I don't know whether it is due to *this* commit, but we have now an
> error in oclusure-tests:

Confirmed. This error occurs iff the test code is run interpreted (TEST_LOAD_EL=yes).

Re: master f2bccae22bd 2/2: Use a dedicated type to represent interpreted-function values

[Stefan Monnier]

> I don't know whether it is due to *this* commit, but we have now an
> error in oclosure-tests:

Indeed, the test needed some tweak.  Should be fixed now, thanks,


        Stefan

Re: master f2bccae22bd 2/2: Use a dedicated type to represent interpreted-function values

[Michael Albinus]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

Hi Stefan,

>> I don't know whether it is due to *this* commit, but we have now an
>> error in oclosure-tests:
>
> Indeed, the test needed some tweak.  Should be fixed now, thanks,

Confirmed.

>         Stefan

Best regards, Michael.