From: Andreas Schwab <schwab@linux-m68k.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Po Lu <luangruo@yahoo.com>, emacs-devel@gnu.org
Subject: Re: master 6d4179957a8: Fix test of whether to insert lexical-binding cookies in custom files
Date: Sat, 11 May 2024 18:58:22 +0200 [thread overview]
Message-ID: <871q68cmkx.fsf@igel.home> (raw)
In-Reply-To: <875xvkcmp7.fsf@igel.home> (Andreas Schwab's message of "Sat, 11 May 2024 18:55:48 +0200")
On Mai 11 2024, Andreas Schwab wrote:
> On Mai 11 2024, Eli Zaretskii wrote:
>
>>> + ;; The previous test `eobp' was written with an appalling
>>> + ;; lack of forethought or testing, being easily misled if
>>> + ;; the user should have left point at eob in a buffer
>>> + ;; visiting the custom file.
>>> + (when (eq (point-min) (point-max))
>>
>> Is this test robust enough? Why not use buffer-size instead?
>
> buffer-size also ignores narrowing.
I missed the preceding (widen), though.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2024-05-11 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 16:36 master 6d4179957a8: Fix test of whether to insert lexical-binding cookies in custom files Eli Zaretskii
2024-05-11 16:55 ` Andreas Schwab
2024-05-11 16:58 ` Andreas Schwab [this message]
2024-05-11 17:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q68cmkx.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.