From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61549: 30.0.50; [PATCH] New keyboard macro counter functions Date: Tue, 04 Jun 2024 02:56:21 +0200 Message-ID: <871q5da5l6.fsf@web.de> References: <83sff41zgm.fsf@gnu.org> <83fsb2xhzp.fsf@gnu.org> <86ed9t5btc.fsf@gnu.org> <87h6eahqcd.fsf@web.de> <864jaamfb3.fsf@gnu.org> Reply-To: Michael Heerdegen Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5127"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61549@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca, alex@bochannek.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 04 02:57:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sEIU8-00015d-Qj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Jun 2024 02:57:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEITr-0000Ly-VQ; Mon, 03 Jun 2024 20:56:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEITq-0000K7-1z for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2024 20:56:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEITp-0005TH-Ox for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2024 20:56:49 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sEIU2-0001Jp-JD for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2024 20:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Jun 2024 00:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61549 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61549-submit@debbugs.gnu.org id=B61549.17174625765004 (code B ref 61549); Tue, 04 Jun 2024 00:57:02 +0000 Original-Received: (at 61549) by debbugs.gnu.org; 4 Jun 2024 00:56:16 +0000 Original-Received: from localhost ([127.0.0.1]:55998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEITI-0001Ie-CP for submit@debbugs.gnu.org; Mon, 03 Jun 2024 20:56:16 -0400 Original-Received: from mout.web.de ([212.227.15.3]:58785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEITG-0001IP-9i for 61549@debbugs.gnu.org; Mon, 03 Jun 2024 20:56:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1717462538; x=1718067338; i=michael_heerdegen@web.de; bh=+i0qR6dYgDk1AAVLumlgb5UkLAt2PcH331N6WYOvDNE=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=euRz/N5cj8w13yO8ZPakKjtGIzneg9Bxv3Dvvsp7g0tK9Y70z+9kjopOzqjA4S+C gXEdFUS2a/kzMw+2GAmxqafJ11MK8udfdvGzMsjEnpy8dUtRoQv6eHJ0ITRkV1Y/B TLB0Bp38DKDBEAFDdVEbb1r0UcZhNJuvfHO2CpK522YH2CFAP3n7jRsuE1aZh7BPR K4D2yBWBNIAPINMhMvmhFQ++baWTfgLITV0y/niy/RrK4bTAf6IabifG9O87d370v oTwtz+NN6rWwEWlXGiCxLpSfFxi0HncAlY6Eb+8WlOZcequojkrK8/dkN1IuTBkyP TAQwJKiqfIfgUC0ZGg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([84.59.210.113]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1Mho04-1sjFZC1Tfs-00db4e; Tue, 04 Jun 2024 02:55:38 +0200 In-Reply-To: <864jaamfb3.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 03 Jun 2024 14:33:20 +0300") X-Provags-ID: V03:K1:qJNKPD0+Bo7/1/ivp1q8uDk0nY4voNravONuxEgmUR98DsWF66r wvzYaf/23tCkwYBf+upK9bnMa/HJwDPxoWiy/POhQtTnamPs+KZ1Wut3XLfRXZgLFGXaMDI rML/vgWkF+MViz7Wl0OPhkw2MT6P2vOJPMjPeLRqxq4hhoJGXKkQYh+1/p/9jwYkNYHmZZi Nqevs0RU4Or5dQTxn3GgQ== UI-OutboundReport: notjunk:1;M01:P0:IBhYvQgr44w=;gtjkNsa0gXthx5Ii+uP5wH0y9tN P6Ugr5oFG9d+3nWrXZEgJUc0G4jb5NtyAk1ifbUsYJFKvu6lvZ8p2WThGlH2sDOG+dsLgmawe +Aa4feRgCmJywRvrqXrhuBYx1/47/XlliIM0PihJvAh2R+sW53ri5ltaqRDVkOu/Z1wYp0X7o 4HrWxXs737+nX39YgrBVypi2jLbRUGBM3EYcSAnHzSY8FvTttI54AxqEcBLKzZYjykmB6+V1d cGFtJ1utyY6sEJhbYud3i4IvuOxqtLWF9BZTO9eqwcN6d36jFn9g7wSqglUyrAQhyeGD+7DN2 7JIW4Cwyrcr7Xxlh0x1TznZhqOyYYs3Csro5Y5z6phF8K4qWPZ4sx9jdAKimFvDkbn270yvR6 BJOJVjdVn0ablT5uxuvBo+/C7Ah6i2T62uf6AlGDABf+c9RqIlWhYy3/a3qHp68ABX7hcdCbX 5tRNz8SVm9wT5Q3sIZu3arOv5INvlUHpQKSvtXbD4/nBwG5YJPDZ7eFVMVjw/hXKxir6ulz0d xqggLkyrkzqcSeFqYrmDcd35+cmfKx33Aoku+TrwJbkBVHdpVlCRKkXI49cRmGw4vdXb+T4xM lPChZUOaY9ZMcQlGE+yzKfdjh6fx4th9R9Y0gkODVga/hBHuAhJZEsv8pGziZnP7zOV1gWkp/ EhoLVTXz+Tfz/LBJPzPvun8baSohEL+2TdJ7HYXkItVvyGUJ4eSLMzql1e/CBUrDyvAR6PFLQ Wa/wGcSMnkal+D4JqPB7aSJ3nsFKOG/pMHyoRh6mamZRUk2GBF4bNgzEWV7Li2HBHdf+eHIb X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286498 Archived-At: Eli Zaretskii writes: > Thanks, but please in the future try to chime in earlier [...] Sure - I'm sorry that I failed this time. > > (1) "kmacro-add-counter" and related functions... I wonder why these are > > not named "kmacro-increase-counter" [...] > If we want to rename this, IMO kmacro-add-to-counter is a better name. Sounds reasonable. > > (3) I actually don't understand the usage of the > > `kmacro-reg-add-counter-*' named functions (did you, Eli?). An example > > would maybe help. > > Did you read the doc string before or after I install the changes? Both times in this case, actually. My question was more about how this is supposed to be used, not what it does. Maybe it's obvious when one uses kmacros often. > > In addition I want to say the suggested manual additions are useful. > > Would it make sense to add at least some parts to the file header or > > some pieces to the docstrings, or as comments? > > No, I think these are sufficiently obscure to not be in the manual. I agree - but the focus here was on the second sentence. Thanks, Michael.